| Message ID | 1419397600-7431-5-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Bin, On 23 December 2014 at 22:06, Bin Meng <bmeng.cn@gmail.com> wrote: > Right now all dts files under arch/x86/dts are compiled. This is > not necessary so update the Makefile to only compile dts file for > a specific board. I'd rather that we go the other way - making the boards more common. If I can get the Minnowmax spun up I am going to try to unify the support such that we can build an image that will boot on all the x86 boards. This would require: - a set of operations and data provided by each board (how to do CAR, whether to use FSP, how to detect the board, etc.) - allowing a board config to enable multiple arch types, like ivybridge and atom, for example - allow multiple device trees, FSPs, microcodes, etc. to reside in the image One benefit is easier programming, if we can have an image that is common to many boards - we don't need to worry so much about breaking a different board if most things are common. Also we retain the option to build just for a single target. I feel that if we get the structure for this in place now, it will be relatively easy to build on, whereas trying to retrofit it later would be too hard. Regards, Simon
Hi Simon, On Sun, Dec 28, 2014 at 9:07 AM, Simon Glass <sjg@chromium.org> wrote: > Hi Bin, > > On 23 December 2014 at 22:06, Bin Meng <bmeng.cn@gmail.com> wrote: >> Right now all dts files under arch/x86/dts are compiled. This is >> not necessary so update the Makefile to only compile dts file for >> a specific board. > > I'd rather that we go the other way - making the boards more common. > If I can get the Minnowmax spun up I am going to try to unify the > support such that we can build an image that will boot on all the x86 > boards. This would require: > > - a set of operations and data provided by each board (how to do CAR, > whether to use FSP, how to detect the board, etc.) > - allowing a board config to enable multiple arch types, like > ivybridge and atom, for example > - allow multiple device trees, FSPs, microcodes, etc. to reside in the image > > One benefit is easier programming, if we can have an image that is > common to many boards - we don't need to worry so much about breaking > a different board if most things are common. Also we retain the option > to build just for a single target. > > I feel that if we get the structure for this in place now, it will be > relatively easy to build on, whereas trying to retrofit it later would > be too hard. > The idea of making the boards support more common sounds good to me. We will see how far we can go. Regards, Bin
diff --git a/arch/x86/dts/Makefile b/arch/x86/dts/Makefile index 5525094..1291e69 100644 --- a/arch/x86/dts/Makefile +++ b/arch/x86/dts/Makefile @@ -1,6 +1,6 @@ -dtb-y += link.dtb \ - chromebook_link.dtb \ - crownbay.dtb +dtb-$(CONFIG_TARGET_COREBOOT) += link.dtb +dtb-$(CONFIG_TARGET_CHROMEBOOK_LINK) += chromebook_link.dtb +dtb-$(CONFIG_TARGET_CROWNBAY) += crownbay.dtb targets += $(dtb-y)
Right now all dts files under arch/x86/dts are compiled. This is not necessary so update the Makefile to only compile dts file for a specific board. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- arch/x86/dts/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)