diff mbox

package/cairo: uses fork(), so requires an MMU

Message ID 1400104601-31625-1-git-send-email-yann.morin.1998@free.fr
State Rejected
Headers show

Commit Message

Yann E. MORIN May 14, 2014, 9:56 p.m. UTC 
From: "Yann E. MORIN" <yann.morin.1998@free.fr>

Fixes:
    http://autobuild.buildroot.net/results/038/038371cc8548b3d39d8174289bedc9aae4076303/

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/cairo/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN May 14, 2014, 10:15 p.m. UTC | #1 
On 2014-05-14 23:56 +0200, Yann E. MORIN spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Fixes:
>     http://autobuild.buildroot.net/results/038/038371cc8548b3d39d8174289bedc9aae4076303/

Also fixes:
    http://autobuild.buildroot.net/results/d93/d9374c1bd08eae5db60e6939ce5e9e4c8ff8cbd5/
    http://autobuild.buildroot.net/results/574/5746e7e3b2bc36f31dee1acf71e59dc4d6c90af2/
    http://autobuild.buildroot.net/results/b66/b66d7125ea7e10313221462097ae6c22ede963e5/
    [...]

> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/cairo/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/cairo/Config.in b/package/cairo/Config.in
> index 0c87a29..2742855 100644
> --- a/package/cairo/Config.in
> +++ b/package/cairo/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_CAIRO
>  	select BR2_PACKAGE_FONTCONFIG
>  	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
>  	select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7
> +	depends on BR2_USE_MMU # fork()
>  	help
>  	  Cairo is a 2D graphics library with support for multiple
>  	  output devices. Currently supported output targets include
> -- 
> 1.8.3.2
>
Eric Le Bihan May 15, 2014, 7:44 a.m. UTC | #2 
Hi!
On Thu, May 15, 2014 at 12:15:37AM +0200, Yann E. MORIN wrote:
> On 2014-05-14 23:56 +0200, Yann E. MORIN spake thusly:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > Fixes:
> >     http://autobuild.buildroot.net/results/038/038371cc8548b3d39d8174289bedc9aae4076303/
>
> Also fixes:
>     http://autobuild.buildroot.net/results/d93/d9374c1bd08eae5db60e6939ce5e9e4c8ff8cbd5/
>     http://autobuild.buildroot.net/results/574/5746e7e3b2bc36f31dee1acf71e59dc4d6c90af2/
>     http://autobuild.buildroot.net/results/b66/b66d7125ea7e10313221462097ae6c22ede963e5/
>     [...]

A few weeks ago, I posted a fix to cairo for these issues:

http://patchwork.ozlabs.org/patch/342715/

The problem occurs on one of the test program, not on cairo itself, so cairo
should be usable on Blackfin (I do not own one, so I have not tested it).

I opened a bug at freedesktop.org too:

https://bugs.freedesktop.org/show_bug.cgi?id=78709

Best regards,
ELB
Thomas Petazzoni May 15, 2014, 8:02 a.m. UTC | #3 
Dear Eric Le Bihan,

On Thu, 15 May 2014 09:44:08 +0200, Eric Le Bihan wrote:

> On Thu, May 15, 2014 at 12:15:37AM +0200, Yann E. MORIN wrote:
> > On 2014-05-14 23:56 +0200, Yann E. MORIN spake thusly:
> > > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > >
> > > Fixes:
> > >     http://autobuild.buildroot.net/results/038/038371cc8548b3d39d8174289bedc9aae4076303/
> >
> > Also fixes:
> >     http://autobuild.buildroot.net/results/d93/d9374c1bd08eae5db60e6939ce5e9e4c8ff8cbd5/
> >     http://autobuild.buildroot.net/results/574/5746e7e3b2bc36f31dee1acf71e59dc4d6c90af2/
> >     http://autobuild.buildroot.net/results/b66/b66d7125ea7e10313221462097ae6c22ede963e5/
> >     [...]
> 
> A few weeks ago, I posted a fix to cairo for these issues:
> 
> http://patchwork.ozlabs.org/patch/342715/
> 
> The problem occurs on one of the test program, not on cairo itself, so cairo
> should be usable on Blackfin (I do not own one, so I have not tested it).
> 
> I opened a bug at freedesktop.org too:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=78709

Yep, I agree Eric's patch is better. I've therefore marked Yann's patch
as rejected (hope you won't mind Yann).

Thanks,

Thomas
Yann E. MORIN May 15, 2014, 4:24 p.m. UTC | #4 
Thomas, All,

On 2014-05-15 10:02 +0200, Thomas Petazzoni spake thusly:
> On Thu, 15 May 2014 09:44:08 +0200, Eric Le Bihan wrote:
> > On Thu, May 15, 2014 at 12:15:37AM +0200, Yann E. MORIN wrote:
> > > On 2014-05-14 23:56 +0200, Yann E. MORIN spake thusly:
> > > > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > > >
> > > > Fixes:
> > > >     http://autobuild.buildroot.net/results/038/038371cc8548b3d39d8174289bedc9aae4076303/
> > >
> > > Also fixes:
> > >     http://autobuild.buildroot.net/results/d93/d9374c1bd08eae5db60e6939ce5e9e4c8ff8cbd5/
> > >     http://autobuild.buildroot.net/results/574/5746e7e3b2bc36f31dee1acf71e59dc4d6c90af2/
> > >     http://autobuild.buildroot.net/results/b66/b66d7125ea7e10313221462097ae6c22ede963e5/
> > >     [...]
> > 
> > A few weeks ago, I posted a fix to cairo for these issues:
> > 
> > http://patchwork.ozlabs.org/patch/342715/
> > 
> > The problem occurs on one of the test program, not on cairo itself, so cairo
> > should be usable on Blackfin (I do not own one, so I have not tested it).
> > 
> > I opened a bug at freedesktop.org too:
> > 
> > https://bugs.freedesktop.org/show_bug.cgi?id=78709
> 
> Yep, I agree Eric's patch is better. I've therefore marked Yann's patch
> as rejected (hope you won't mind Yann).

He, of course not! I even was doubtful of that patch to begin with
anyway. I just forgot to mention it in a '---' note.

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/package/cairo/Config.in b/package/cairo/Config.in
index 0c87a29..2742855 100644
--- a/package/cairo/Config.in
+++ b/package/cairo/Config.in
@@ -4,6 +4,7 @@  config BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_FONTCONFIG
 	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_XORG7
+	depends on BR2_USE_MMU # fork()
 	help
 	  Cairo is a 2D graphics library with support for multiple
 	  output devices. Currently supported output targets include