[v5] bluez5_utils: new package

This patch adds Bluez 5.x.
API is not backwards compatible with BlueZ 4.x

BlueZ utils will use systemd and/or udev if enabled.
Contains a hook for installing GATT support tool, wchich is always
build but not installed by default.

Signed-off-by: Marcin Bis <marcin@bis.org.pl>
---
 package/Config.in                    |    1 +
 package/bluez5_utils/Config.in       |   54 ++++++++++++++++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk |   54 ++++++++++++++++++++++++++++++++++
 3 files changed, 109 insertions(+)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

Dear Marcin Bis,

On Mon, 31 Mar 2014 10:58:00 +0200, Marcin Bis wrote:
> This patch adds Bluez 5.x.
> API is not backwards compatible with BlueZ 4.x

... so it is packaged as a separate package.

> BlueZ utils will use systemd and/or udev if enabled.
> Contains a hook for installing GATT support tool, wchich is always

which

> build but not installed by default.

build -> built


> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
> new file mode 100644
> index 0000000..809dd8a
> --- /dev/null
> +++ b/package/bluez5_utils/Config.in
> @@ -0,0 +1,54 @@
> +config BR2_PACKAGE_BLUEZ5_UTILS
> +	bool "bluez-utils 5.x"
> +	depends on !BR2_avr32
> +	depends on BR2_USE_WCHAR # libglib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
> +	depends on BR2_USE_MMU # dbus
> +	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_LIBICAL
> +	select BR2_PACKAGE_READLINE
> +	help
> +	  bluez utils version 5.x
> +
> +	  With this release BlueZ only supports the new Bluetooth Management
> +	  kernel interface (introduced in Linux 3.4).

Does it need kernel headers >= 3.4 ?


> +# install gatttool (For some reason upstream choose not to do it by default)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
> +define BLUEZ5_UTILS_INSTALL_GATTTOOL
> +	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin

The destination path should be a full path, i.e:

	$(TARGET_DIR)/usr/bin/gatttool

> +# use udev if available
> +ifeq ($(BR2_PACKAGE_UDEV),y)

You should instead rely on BR2_PACKAGE_HAS_UDEV, so that it works with
both eudev, or the udev built into systemd.

Thomas

Hi Thomas

On Thu, Apr 3, 2014 at 10:00 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Marcin Bis,

>> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
>> new file mode 100644
>> index 0000000..809dd8a
>> --- /dev/null
>> +++ b/package/bluez5_utils/Config.in
>> @@ -0,0 +1,54 @@
>> +config BR2_PACKAGE_BLUEZ5_UTILS
>> +     bool "bluez-utils 5.x"
>> +     depends on !BR2_avr32
>> +     depends on BR2_USE_WCHAR # libglib2
>> +     depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
>> +     depends on BR2_USE_MMU # dbus
>> +     depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
>> +     select BR2_PACKAGE_DBUS
>> +     select BR2_PACKAGE_LIBGLIB2
>> +     select BR2_PACKAGE_LIBICAL
>> +     select BR2_PACKAGE_READLINE
>> +     help
>> +       bluez utils version 5.x
>> +
>> +       With this release BlueZ only supports the new Bluetooth Management
>> +       kernel interface (introduced in Linux 3.4).
>
> Does it need kernel headers >= 3.4 ?

I am checking this.
It seems that it needs kernel >= 3.4 for BLE.
In older kernels BLE wont work, but older Bluetooth spec. should.

>> +# install gatttool (For some reason upstream choose not to do it by default)
>> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
>> +define BLUEZ5_UTILS_INSTALL_GATTTOOL
>> +     $(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
>
> The destination path should be a full path, i.e:
>
>         $(TARGET_DIR)/usr/bin/gatttool
OK

>> +# use udev if available
>> +ifeq ($(BR2_PACKAGE_UDEV),y)
>
> You should instead rely on BR2_PACKAGE_HAS_UDEV, so that it works with
> both eudev, or the udev built into systemd.
OK

I will fix it over the weekend.

--
 Marcin Bis

Dear Marcin Bis,

On Mon, 31 Mar 2014 10:58:00 +0200, Marcin Bis wrote:
> This patch adds Bluez 5.x.
> API is not backwards compatible with BlueZ 4.x
> 
> BlueZ utils will use systemd and/or udev if enabled.
> Contains a hook for installing GATT support tool, wchich is always
> build but not installed by default.
> 
> Signed-off-by: Marcin Bis <marcin@bis.org.pl>
> ---
>  package/Config.in                    |    1 +
>  package/bluez5_utils/Config.in       |   54 ++++++++++++++++++++++++++++++++++
>  package/bluez5_utils/bluez5_utils.mk |   54 ++++++++++++++++++++++++++++++++++
>  3 files changed, 109 insertions(+)
>  create mode 100644 package/bluez5_utils/Config.in
>  create mode 100644 package/bluez5_utils/bluez5_utils.mk

I've applied your patch, after making a number of changes:

    [Thomas:
     - Add dependency on 3.4 kernel headers
     - Add options for OBEX support and client support, to make the
       libical and readline dependencies optional.
     - Rewrap Config.in help text.
     - Adapt indentation in .mk file.
     - Bump to version 5.21.
     - Use BR2_PACKAGE_HAS_UDEV instead of BR2_PACKAGE_UDEV.]

It would be great if you could test the latest master and confirm that
it works for you.

Thanks a lot for this contribution!

Thomas Petazzoni