| Message ID | f2f1b59c4cfbf80a1592.1386240846@argentina |
|---|---|
| State | Accepted |
| Headers | show |
On 05/12/13 11:54, Thomas De Schampheleire wrote: > diff --git a/docs/manual/package-make-target.txt b/docs/manual/package-make-target.txt > --- a/docs/manual/package-make-target.txt > +++ b/docs/manual/package-make-target.txt > @@ -63,9 +63,7 @@ Additionally, there are some other usefu > | +show-depends+ | Displays the dependencies required to build the > package > > -| +clean+ | Run the clean command of the package, also > -uninstall the package from both the target and the staging directory; _note > -that this is not implemented for all packages_ > +| +clean+ | Run the clean command of the package The note should stay, I think. Clean is still not implemented for all packages. By the way, weren't we going to remove clean as well? Regards, Arnout > > | +dirclean+ | Remove the whole package build directory
Dear Arnout Vandecappelle, On Thu, 05 Dec 2013 23:08:11 +0100, Arnout Vandecappelle wrote: > On 05/12/13 11:54, Thomas De Schampheleire wrote: > > diff --git a/docs/manual/package-make-target.txt b/docs/manual/package-make-target.txt > > --- a/docs/manual/package-make-target.txt > > +++ b/docs/manual/package-make-target.txt > > @@ -63,9 +63,7 @@ Additionally, there are some other usefu > > | +show-depends+ | Displays the dependencies required to build the > > package > > > > -| +clean+ | Run the clean command of the package, also > > -uninstall the package from both the target and the staging directory; _note > > -that this is not implemented for all packages_ > > +| +clean+ | Run the clean command of the package > > The note should stay, I think. Clean is still not implemented for all > packages. By the way, weren't we going to remove clean as well? Yes, we should remove them as well. Can be done as part of a separate series, I believe. Removing the uninstall commands is already a good step forward. Thomas
Hi, On Thu, Dec 5, 2013 at 11:30 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Arnout Vandecappelle, > > On Thu, 05 Dec 2013 23:08:11 +0100, Arnout Vandecappelle wrote: >> On 05/12/13 11:54, Thomas De Schampheleire wrote: >> > diff --git a/docs/manual/package-make-target.txt b/docs/manual/package-make-target.txt >> > --- a/docs/manual/package-make-target.txt >> > +++ b/docs/manual/package-make-target.txt >> > @@ -63,9 +63,7 @@ Additionally, there are some other usefu >> > | +show-depends+ | Displays the dependencies required to build the >> > package >> > >> > -| +clean+ | Run the clean command of the package, also >> > -uninstall the package from both the target and the staging directory; _note >> > -that this is not implemented for all packages_ >> > +| +clean+ | Run the clean command of the package >> >> The note should stay, I think. Clean is still not implemented for all >> packages. By the way, weren't we going to remove clean as well? > > Yes, we should remove them as well. Can be done as part of a separate > series, I believe. Removing the uninstall commands is already a good > step forward. Thanks for mentioning, I wasn't aware that -clean was also deprecated. To be sure, foo-dirclean will still be supported, right? I will create another patch series to remove -clean, but as ThomasP said this should not block integration of this series already. Best regards, Thomas
Dear Thomas De Schampheleire, On Fri, 6 Dec 2013 08:38:28 +0100, Thomas De Schampheleire wrote: > Thanks for mentioning, I wasn't aware that -clean was also deprecated. > To be sure, foo-dirclean will still be supported, right? foo-dirclean is implemented in a generic way in the package infrastructure, so there is no problem with foo-dirclean and it should be kept, IMO. The main problem with foo-uninstall and foo-clean is that it had to be implemented by each package, but it was barely tested, especially during package bumps. > I will create another patch series to remove -clean, but as ThomasP > said this should not block integration of this series already. Indeed. Thomas
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes: > Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Committed with the clean comment keep as pointed out by Arnout, thanks.
diff --git a/docs/manual/adding-packages-autotools.txt b/docs/manual/adding-packages-autotools.txt --- a/docs/manual/adding-packages-autotools.txt +++ b/docs/manual/adding-packages-autotools.txt @@ -148,14 +148,6 @@ cases, typical packages will therefore o * +LIBFOO_CLEAN_OPT+ contains the make options used to clean the package. By default, the value is +clean+. -* +LIBFOO_UNINSTALL_STAGING_OPT+, contains the make - options used to uninstall the package from the staging directory. By - default, the value is +DESTDIR=$$(STAGING_DIR) uninstall+. - -* +LIBFOO_UNINSTALL_TARGET_OPT+, contains the make - options used to uninstall the package from the target directory. By - default, the value is +DESTDIR=$$(TARGET_DIR) uninstall+. - With the autotools infrastructure, all the steps required to build and install the packages are already defined, and they generally work well for most autotools-based packages. However, when required, it is diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt --- a/docs/manual/adding-packages-generic.txt +++ b/docs/manual/adding-packages-generic.txt @@ -415,12 +415,6 @@ different steps of the build process. * +LIBFOO_CLEAN_CMDS+, lists the actions to perform to clean up the build directory of the package. -* +LIBFOO_UNINSTALL_TARGET_CMDS+ lists the actions to - uninstall the package from the target directory +$(TARGET_DIR)+ - -* +LIBFOO_UNINSTALL_STAGING_CMDS+ lists the actions to - uninstall the package from the staging directory +$(STAGING_DIR)+. - * +LIBFOO_INSTALL_INIT_SYSV+ and +LIBFOO_INSTALL_INIT_SYSTEMD+ list the actions to install init scripts either for the systemV-like init systems (busybox, sysvinit, etc.) or for the systemd units. These commands diff --git a/docs/manual/package-make-target.txt b/docs/manual/package-make-target.txt --- a/docs/manual/package-make-target.txt +++ b/docs/manual/package-make-target.txt @@ -63,9 +63,7 @@ Additionally, there are some other usefu | +show-depends+ | Displays the dependencies required to build the package -| +clean+ | Run the clean command of the package, also -uninstall the package from both the target and the staging directory; _note -that this is not implemented for all packages_ +| +clean+ | Run the clean command of the package | +dirclean+ | Remove the whole package build directory
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> --- docs/manual/adding-packages-autotools.txt | 8 -------- docs/manual/adding-packages-generic.txt | 6 ------ docs/manual/package-make-target.txt | 4 +--- 3 files changed, 1 insertions(+), 17 deletions(-)