Message ID | 1365761909-15305-7-git-send-email-sonic.adi@gmail.com |
---|---|
State | Changes Requested |
Headers | show |
Dear Sonic Zhang, On Fri, 12 Apr 2013 18:18:29 +0800, Sonic Zhang wrote: > ifeq ($(BR2_BINFMT_FLAT),y) > TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE)) > + > +ifneq ($(BR2_USE_MMU), y) There shouldn't be any space between the comma and the y. > +TARGET_CFLAGS += -D__NOMMU__ > endif > > ifeq ($(BR2_BINFMT_FLAT_SHARED),y) And you're adding a ifneq condition without adding any endif. Smells like untested code :) Thomas
Hi Thomas, On Wed, Apr 17, 2013 at 5:30 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Sonic Zhang, > > On Fri, 12 Apr 2013 18:18:29 +0800, Sonic Zhang wrote: > >> ifeq ($(BR2_BINFMT_FLAT),y) >> TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE)) >> + >> +ifneq ($(BR2_USE_MMU), y) > > There shouldn't be any space between the comma and the y. > >> +TARGET_CFLAGS += -D__NOMMU__ >> endif >> >> ifeq ($(BR2_BINFMT_FLAT_SHARED),y) > > And you're adding a ifneq condition without adding any endif. Smells > like untested code :) > That's an error when I rebase this patch automatically. Should be fixed soon. Regards, Sonic
diff --git a/package/Makefile.in b/package/Makefile.in index a449089..e7bb61f 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -105,6 +105,9 @@ TARGET_LDFLAGS = $(call qstrip,$(BR2_TARGET_LDFLAGS)) ifeq ($(BR2_BINFMT_FLAT),y) TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE)) + +ifneq ($(BR2_USE_MMU), y) +TARGET_CFLAGS += -D__NOMMU__ endif ifeq ($(BR2_BINFMT_FLAT_SHARED),y)