Message ID | 1352883977-16288-1-git-send-email-noel.vellemans@visionbms.com |
---|---|
State | Superseded |
Headers | show |
Noel, On Wed, 14 Nov 2012 10:06:17 +0100, Noel vellemans wrote: > +config BR2_PACKAGE_HOST_LIBXML2_PYTHON > + bool > \ No newline at end of file I don't know if we want to introduce sub-options for host packages. > diff --git a/package/libxml2/libxml2.mk b/package/libxml2/libxml2.mk > index 71f2bd1..fde3735 100644 > --- a/package/libxml2/libxml2.mk > +++ b/package/libxml2/libxml2.mk > @@ -26,7 +26,15 @@ LIBXML2_POST_INSTALL_STAGING_HOOKS += > LIBXML2_STAGING_LIBXML2_CONFIG_FIXUP > HOST_LIBXML2_DEPENDENCIES = host-pkgconf > > -HOST_LIBXML2_CONF_OPT = --without-debug --without-python > +HOST_LIBXML2_CONF_OPT = --without-debug > + > +ifeq ($(BR2_PACKAGE_HOST_LIBXML2_PYTHON),y) > +HOST_LIBXML2_DEPENDENCIES += host-python > +HOST_LIBXML2_CONF_OPT += --with-python=$(HOST_DIR)/usr > +else > +HOST_LIBXML2_CONF_OPT += --without-python > +endif I'm confused here. I thought mesa required a Python that has xml2 support. But here you're building xml2 with Python support. Could you enlighten me? :-) Thanks! Thomas
Hi thomas, >> I don't know if we want to introduce sub-options for host packages. Well, I first did HARD-code this option into my "test"-build, but based on (a previous) patch from Will and based on the comments of Arnout, I kind of did agree on the sub-option. I know its not that good-looking, but at this time, it looks a 'reasonable' way of getting this done. Ref to : [Buildroot] mesa3d: "ImportError: No module named libxml2" >>I'm confused here. I thought mesa required a Python that has xml2 support. But here you're building xml2 with Python support. >>Could you enlighten me? :-) Please have a look at this http://lists.busybox.net/pipermail/buildroot/2012-November/061334.html ... Hope is clears out some questions... Again, open to comments and/or better solutions, but at this time it looked acceptable (if you ask me). Regards Noel -----Original Message----- From: Thomas Petazzoni [mailto:thomas.petazzoni@free-electrons.com] Sent: 14Nov12 10:26 To: Vellemans, Noel Cc: buildroot@busybox.net; willw@carallon.com Subject: Re: [Buildroot] [PATCH 1/1] libxml2: add support for building host library with python support Noel, On Wed, 14 Nov 2012 10:06:17 +0100, Noel vellemans wrote: > +config BR2_PACKAGE_HOST_LIBXML2_PYTHON > + bool > \ No newline at end of file I don't know if we want to introduce sub-options for host packages. > diff --git a/package/libxml2/libxml2.mk b/package/libxml2/libxml2.mk > index 71f2bd1..fde3735 100644 > --- a/package/libxml2/libxml2.mk > +++ b/package/libxml2/libxml2.mk > @@ -26,7 +26,15 @@ LIBXML2_POST_INSTALL_STAGING_HOOKS += > LIBXML2_STAGING_LIBXML2_CONFIG_FIXUP > HOST_LIBXML2_DEPENDENCIES = host-pkgconf > > -HOST_LIBXML2_CONF_OPT = --without-debug --without-python > +HOST_LIBXML2_CONF_OPT = --without-debug > + > +ifeq ($(BR2_PACKAGE_HOST_LIBXML2_PYTHON),y) > +HOST_LIBXML2_DEPENDENCIES += host-python HOST_LIBXML2_CONF_OPT += > +--with-python=$(HOST_DIR)/usr else HOST_LIBXML2_CONF_OPT += > +--without-python endif I'm confused here. I thought mesa required a Python that has xml2 support. But here you're building xml2 with Python support. Could you enlighten me? :-) Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
diff --git a/package/libxml2/Config.in b/package/libxml2/Config.in index ebd63fe..ea62663 100644 --- a/package/libxml2/Config.in +++ b/package/libxml2/Config.in @@ -4,3 +4,6 @@ config BR2_PACKAGE_LIBXML2 XML C Parser http://xmlsoft.org/ + +config BR2_PACKAGE_HOST_LIBXML2_PYTHON + bool \ No newline at end of file diff --git a/package/libxml2/libxml2.mk b/package/libxml2/libxml2.mk index 71f2bd1..fde3735 100644 --- a/package/libxml2/libxml2.mk +++ b/package/libxml2/libxml2.mk @@ -26,7 +26,15 @@ LIBXML2_POST_INSTALL_STAGING_HOOKS += LIBXML2_STAGING_LIBXML2_CONFIG_FIXUP HOST_LIBXML2_DEPENDENCIES = host-pkgconf -HOST_LIBXML2_CONF_OPT = --without-debug --without-python +HOST_LIBXML2_CONF_OPT = --without-debug + +ifeq ($(BR2_PACKAGE_HOST_LIBXML2_PYTHON),y) +HOST_LIBXML2_DEPENDENCIES += host-python +HOST_LIBXML2_CONF_OPT += --with-python=$(HOST_DIR)/usr +else +HOST_LIBXML2_CONF_OPT += --without-python +endif + define LIBXML2_REMOVE_CONFIG_SCRIPTS $(RM) -f $(TARGET_DIR)/usr/bin/xml2-config