| Message ID | 20210131161707.1649123-1-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 77f898d04095cdccb69c476ba0aa19f257fca64d |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | x86: Reduce size of samus image | expand |
On Mon, Feb 1, 2021 at 12:17 AM Simon Glass <sjg@chromium.org> wrote: > > With the recent addition of ACPI generation, the image size has got beyond > its current limit. > > Samus does not actually use this, nor x86 emulation for PCI ROMs, so > disable both features. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > configs/chromebook_samus_defconfig | 1 + > include/configs/chromebook_samus.h | 3 +++ > 2 files changed, 4 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Mon, Feb 1, 2021 at 2:18 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Mon, Feb 1, 2021 at 12:17 AM Simon Glass <sjg@chromium.org> wrote: > > > > With the recent addition of ACPI generation, the image size has got beyond > > its current limit. > > > > Samus does not actually use this, nor x86 emulation for PCI ROMs, so > > disable both features. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > configs/chromebook_samus_defconfig | 1 + > > include/configs/chromebook_samus.h | 3 +++ > > 2 files changed, 4 insertions(+) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> applied to u-boot-x86, thanks!
diff --git a/configs/chromebook_samus_defconfig b/configs/chromebook_samus_defconfig index c0d2b04ccdf..71b5f8bdfea 100644 --- a/configs/chromebook_samus_defconfig +++ b/configs/chromebook_samus_defconfig @@ -54,6 +54,7 @@ CONFIG_ENV_OVERWRITE=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_REGMAP=y CONFIG_SYSCON=y +# CONFIG_ACPIGEN is not set CONFIG_CPU=y CONFIG_DM_I2C=y CONFIG_SYS_I2C_DW=y diff --git a/include/configs/chromebook_samus.h b/include/configs/chromebook_samus.h index dfeede7e91a..2fe3e721993 100644 --- a/include/configs/chromebook_samus.h +++ b/include/configs/chromebook_samus.h @@ -15,6 +15,9 @@ #include <configs/x86-common.h> #include <configs/x86-chromebook.h> +/* We can rely on running natively, and this saves code size */ +#undef CONFIG_BIOSEMU + #undef CONFIG_STD_DEVICES_SETTINGS #define CONFIG_STD_DEVICES_SETTINGS "stdin=usbkbd,i8042-kbd,serial\0" \ "stdout=vidconsole,serial\0" \
With the recent addition of ACPI generation, the image size has got beyond its current limit. Samus does not actually use this, nor x86 emulation for PCI ROMs, so disable both features. Signed-off-by: Simon Glass <sjg@chromium.org> --- configs/chromebook_samus_defconfig | 1 + include/configs/chromebook_samus.h | 3 +++ 2 files changed, 4 insertions(+)