| Message ID | 20200108075945.20347-1-acelan.kao@canonical.com |
|---|---|
| Headers | show |
| Series | Dell AIO can't adjust brightness | expand |
On 8.1.2020 9.59, AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1858761 > > [Impact] > Found on new platforms that UART require more than 1 second to respond > commands in the first 10 seconds after booted. > And the first command we send to scalar is dell_uart_get_scalar_status() > to tell if scalar is in charge of the backlight, and it always fails to get > response because of timeout. > > [Fix] > Adding retry and increasing read timeout for dell_uart_get_scalar_status() > > [Test] > Verified on the target Dell AIO, it can now read the response from scalar. > > [Regression Potential] > Low, adding retry and increasing read timeout doesn't change the code flow. > > AceLan Kao (1): > UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add retry for get > scalar status > > drivers/platform/x86/dell-uart-backlight.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > applied to osp1 oem-next, thanks
On 10.01.20 07:08, Timo Aaltonen wrote: > On 8.1.2020 9.59, AceLan Kao wrote: >> BugLink: https://bugs.launchpad.net/bugs/1858761 >> >> [Impact] >> Found on new platforms that UART require more than 1 second to respond >> commands in the first 10 seconds after booted. >> And the first command we send to scalar is dell_uart_get_scalar_status() >> to tell if scalar is in charge of the backlight, and it always fails to get >> response because of timeout. >> >> [Fix] >> Adding retry and increasing read timeout for dell_uart_get_scalar_status() >> >> [Test] >> Verified on the target Dell AIO, it can now read the response from scalar. >> >> [Regression Potential] >> Low, adding retry and increasing read timeout doesn't change the code flow. >> >> AceLan Kao (1): >> UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add retry for get >> scalar status >> >> drivers/platform/x86/dell-uart-backlight.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> > > applied to osp1 oem-next, thanks > You should not apply anything without having a bug task for it... just saying.
On 16.1.2020 15.58, Stefan Bader wrote: > On 10.01.20 07:08, Timo Aaltonen wrote: >> On 8.1.2020 9.59, AceLan Kao wrote: >>> BugLink: https://bugs.launchpad.net/bugs/1858761 >>> >>> [Impact] >>> Found on new platforms that UART require more than 1 second to respond >>> commands in the first 10 seconds after booted. >>> And the first command we send to scalar is dell_uart_get_scalar_status() >>> to tell if scalar is in charge of the backlight, and it always fails to get >>> response because of timeout. >>> >>> [Fix] >>> Adding retry and increasing read timeout for dell_uart_get_scalar_status() >>> >>> [Test] >>> Verified on the target Dell AIO, it can now read the response from scalar. >>> >>> [Regression Potential] >>> Low, adding retry and increasing read timeout doesn't change the code flow. >>> >>> AceLan Kao (1): >>> UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add retry for get >>> scalar status >>> >>> drivers/platform/x86/dell-uart-backlight.c | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >> >> applied to osp1 oem-next, thanks >> > You should not apply anything without having a bug task for it... just saying. good point, forgot to update the status back then
On 2020-01-08 15:59:44 , AceLan Kao wrote: > BugLink: https://bugs.launchpad.net/bugs/1858761 > > [Impact] > Found on new platforms that UART require more than 1 second to respond > commands in the first 10 seconds after booted. > And the first command we send to scalar is dell_uart_get_scalar_status() > to tell if scalar is in charge of the backlight, and it always fails to get > response because of timeout. > > [Fix] > Adding retry and increasing read timeout for dell_uart_get_scalar_status() > > [Test] > Verified on the target Dell AIO, it can now read the response from scalar. > > [Regression Potential] > Low, adding retry and increasing read timeout doesn't change the code flow. > > AceLan Kao (1): > UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add retry for get > scalar status > > drivers/platform/x86/dell-uart-backlight.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
BugLink: https://bugs.launchpad.net/bugs/1858761 [Impact] Found on new platforms that UART require more than 1 second to respond commands in the first 10 seconds after booted. And the first command we send to scalar is dell_uart_get_scalar_status() to tell if scalar is in charge of the backlight, and it always fails to get response because of timeout. [Fix] Adding retry and increasing read timeout for dell_uart_get_scalar_status() [Test] Verified on the target Dell AIO, it can now read the response from scalar. [Regression Potential] Low, adding retry and increasing read timeout doesn't change the code flow. AceLan Kao (1): UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add retry for get scalar status drivers/platform/x86/dell-uart-backlight.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)