From patchwork Wed Jan 8 07:59:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1219428 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TBpEKln4"; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47t1r14V02z9sRl; Wed, 8 Jan 2020 18:59:59 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ip6Fs-0008Oj-1P; Wed, 08 Jan 2020 07:59:52 +0000 Received: from mail-pl1-f170.google.com ([209.85.214.170]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ip6Fp-0008OT-ET for kernel-team@lists.ubuntu.com; Wed, 08 Jan 2020 07:59:49 +0000 Received: by mail-pl1-f170.google.com with SMTP id b22so780760pls.12 for ; Tue, 07 Jan 2020 23:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=s37vvC8QJKPpszCBTNST67SEZUJARJZMVYRx//Ghl44=; b=TBpEKln4jMBdsP+Iyv2G3Bdyt4hZRtNgXWN1xOd2g64bd/DGgWksqzh1vn4yQtoTO/ vygQNlIFjL/QXjcDif5Q0BpJ2FN+lAdLxDi+1MIuubV2sSCCgfBSdh4Soa1hBAY97Dqe 13ijzsHdo2bS2qHcAxXnbF0B0Tu/kIjdM4BUxkTn6YDev2LfKNiMEAnPhQrCwy5xralL JaMsJVYMTfASwffN34L6umkNluSqa9Ai8xisMpFyNULL2HnyIz6uj3GNfiwcxc7+Y4cT kNHZcYiIx/Jx4XPfKYhMBcwDXfr9z6CC8xU787g3quUJcd2wHEKzWrLWwkrmSpZvgv72 Ozew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=s37vvC8QJKPpszCBTNST67SEZUJARJZMVYRx//Ghl44=; b=bMtNHNRvdK8jqpQ3PmPTiTwmGKv5/9tSnkH/NMUYrQi3LtZFcGAS2jTrCCGkKS0J5Z WmhyRedgPgu104hAV02py8npxwVJExfZINewS24NCtwun94dpd/2AVeqIoou1mQbcHR4 Wo03OlhYsVXpvHOmPMO9GX35z7hFhmfJ7Tpp3KOYBub9MfiuO+GfIjwR4itFYao/yeFQ vfqEl3mt61hbTMPGuO9B7pKVQkEhWAIiv41UfRd8Hvr1CikJBazat3MitKTuxpzRh4cE 3Xx1MfBUtXNcVa4IotMj4CuXBO1QUyDbjE4BVau92AuhZERFOzFVTkQ2Y4KE48F3hwBf oKfg== X-Gm-Message-State: APjAAAXjzQ7IZlKNYSd+vzsWoo8reorjHbbERAhLHJcjae2E9amdHrkU gLyyc4H/TZthz6JjvOo1hlov7N0CJfE= X-Google-Smtp-Source: APXvYqyWlzrV/F9e0kYBZ5JF69mk2FvUeXXoKADrOdKP2XJgtGh99KYc5V5Z4OhA/2br+xc3z9/s5g== X-Received: by 2002:a17:90a:d986:: with SMTP id d6mr3012708pjv.78.1578470387470; Tue, 07 Jan 2020 23:59:47 -0800 (PST) Received: from localhost (220-135-95-34.HINET-IP.hinet.net. [220.135.95.34]) by smtp.gmail.com with ESMTPSA id y197sm2305070pfc.79.2020.01.07.23.59.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Jan 2020 23:59:46 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/1][SRU][B][D][E][F] Dell AIO can't adjust brightness Date: Wed, 8 Jan 2020 15:59:44 +0800 Message-Id: <20200108075945.20347-1-acelan.kao@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1858761 [Impact] Found on new platforms that UART require more than 1 second to respond commands in the first 10 seconds after booted. And the first command we send to scalar is dell_uart_get_scalar_status() to tell if scalar is in charge of the backlight, and it always fails to get response because of timeout. [Fix] Adding retry and increasing read timeout for dell_uart_get_scalar_status() [Test] Verified on the target Dell AIO, it can now read the response from scalar. [Regression Potential] Low, adding retry and increasing read timeout doesn't change the code flow. AceLan Kao (1): UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add retry for get scalar status drivers/platform/x86/dell-uart-backlight.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)