diff mbox series

[12/27] sbbr: acpitables: make function sbbr_search_acpi_tables static

Message ID 20180815131129.24146-13-colin.king@canonical.com
State Accepted
Headers show
Series [01/27] lib: fwts_framework: ensure src pointer is const | expand

Commit Message

Colin Ian King Aug. 15, 2018, 1:11 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Function sbbr_search_acpi_tables is local to the source and
does not need to be in the global namespace so make it static

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/sbbr/acpitables/acpitables.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Aug. 15, 2018, 6:10 p.m. UTC | #1 
On 2018-08-15 06:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Function sbbr_search_acpi_tables is local to the source and
> does not need to be in the global namespace so make it static
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/sbbr/acpitables/acpitables.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
> index e6786eec..0f83747a 100644
> --- a/src/sbbr/acpitables/acpitables.c
> +++ b/src/sbbr/acpitables/acpitables.c
> @@ -214,7 +214,7 @@ static const char *recommended_acpi_tables[] = {
>   };
>   
>   /* Searches ACPI tables by signature. */
> -fwts_acpi_table_info *sbbr_search_acpi_tables(fwts_framework *fw, const char *signature)
> +static fwts_acpi_table_info *sbbr_search_acpi_tables(fwts_framework *fw, const char *signature)
>   {
>   	uint32_t i;
>   	fwts_acpi_table_info *info;
> 



Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Aug. 16, 2018, 9:15 a.m. UTC | #2 
On 08/15/2018 09:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function sbbr_search_acpi_tables is local to the source and
> does not need to be in the global namespace so make it static
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/sbbr/acpitables/acpitables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
> index e6786eec..0f83747a 100644
> --- a/src/sbbr/acpitables/acpitables.c
> +++ b/src/sbbr/acpitables/acpitables.c
> @@ -214,7 +214,7 @@ static const char *recommended_acpi_tables[] = {
>  };
>  
>  /* Searches ACPI tables by signature. */
> -fwts_acpi_table_info *sbbr_search_acpi_tables(fwts_framework *fw, const char *signature)
> +static fwts_acpi_table_info *sbbr_search_acpi_tables(fwts_framework *fw, const char *signature)
>  {
>  	uint32_t i;
>  	fwts_acpi_table_info *info;

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/sbbr/acpitables/acpitables.c b/src/sbbr/acpitables/acpitables.c
index e6786eec..0f83747a 100644
--- a/src/sbbr/acpitables/acpitables.c
+++ b/src/sbbr/acpitables/acpitables.c
@@ -214,7 +214,7 @@  static const char *recommended_acpi_tables[] = {
 };
 
 /* Searches ACPI tables by signature. */
-fwts_acpi_table_info *sbbr_search_acpi_tables(fwts_framework *fw, const char *signature)
+static fwts_acpi_table_info *sbbr_search_acpi_tables(fwts_framework *fw, const char *signature)
 {
 	uint32_t i;
 	fwts_acpi_table_info *info;