diff mbox series

[17/27] acpi: method: make function method_test_CRS_return static

Message ID 20180815131129.24146-18-colin.king@canonical.com
State Accepted
Headers show
Series [01/27] lib: fwts_framework: ensure src pointer is const | expand

Commit Message

Colin Ian King Aug. 15, 2018, 1:11 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Function method_test_CRS_return is local to the source and does not
need to be in the global namespace so make it static

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/method/method.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Aug. 15, 2018, 6:11 p.m. UTC | #1 
On 2018-08-15 06:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Function method_test_CRS_return is local to the source and does not
> need to be in the global namespace so make it static
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpi/method/method.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 79328306..c42ec02d 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -820,7 +820,7 @@ static int method_test_UID(fwts_framework *fw)
>   			"_UID", NULL, 0, fwts_method_test_UID_return, NULL);
>   }
>   
> -void method_test_CRS_return(
> +static void method_test_CRS_return(
>   	fwts_framework *fw,
>   	char *name,
>   	ACPI_BUFFER *buf,
> 



Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Aug. 16, 2018, 9:17 a.m. UTC | #2 
On 08/15/2018 09:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function method_test_CRS_return is local to the source and does not
> need to be in the global namespace so make it static
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/method/method.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 79328306..c42ec02d 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -820,7 +820,7 @@ static int method_test_UID(fwts_framework *fw)
>  			"_UID", NULL, 0, fwts_method_test_UID_return, NULL);
>  }
>  
> -void method_test_CRS_return(
> +static void method_test_CRS_return(
>  	fwts_framework *fw,
>  	char *name,
>  	ACPI_BUFFER *buf,

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 79328306..c42ec02d 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -820,7 +820,7 @@  static int method_test_UID(fwts_framework *fw)
 			"_UID", NULL, 0, fwts_method_test_UID_return, NULL);
 }
 
-void method_test_CRS_return(
+static void method_test_CRS_return(
 	fwts_framework *fw,
 	char *name,
 	ACPI_BUFFER *buf,