diff mbox series

[05/27] lib: fwts_summary: remove redundant redefinition of fwts_summary_deinit

Message ID 20180815131129.24146-6-colin.king@canonical.com
State Accepted
Headers show
Series [01/27] lib: fwts_framework: ensure src pointer is const | expand

Commit Message

Colin Ian King Aug. 15, 2018, 1:11 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The function fwts_summary_deinit is already in fwts_summary.h, so
we can remove the redundant duplicate.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_summary.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Alex Hung Aug. 15, 2018, 5:54 p.m. UTC | #1 
On 2018-08-15 06:11 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The function fwts_summary_deinit is already in fwts_summary.h, so
> we can remove the redundant duplicate.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/fwts_summary.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_summary.c b/src/lib/src/fwts_summary.c
> index 924e9b81..9202be3b 100644
> --- a/src/lib/src/fwts_summary.c
> +++ b/src/lib/src/fwts_summary.c
> @@ -57,8 +57,6 @@ static const int summary_levels[] = {
>   /* list of summary items per error level */
>   static fwts_list *fwts_summaries[SUMMARY_MAX];
>   
> -void fwts_summary_deinit(void);
> -
>   /*
>    *  fwts_summary_init()
>    *	initialise
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Aug. 16, 2018, 9:12 a.m. UTC | #2 
On 08/15/2018 09:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function fwts_summary_deinit is already in fwts_summary.h, so
> we can remove the redundant duplicate.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_summary.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_summary.c b/src/lib/src/fwts_summary.c
> index 924e9b81..9202be3b 100644
> --- a/src/lib/src/fwts_summary.c
> +++ b/src/lib/src/fwts_summary.c
> @@ -57,8 +57,6 @@ static const int summary_levels[] = {
>  /* list of summary items per error level */
>  static fwts_list *fwts_summaries[SUMMARY_MAX];
>  
> -void fwts_summary_deinit(void);
> -
>  /*
>   *  fwts_summary_init()
>   *	initialise

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/lib/src/fwts_summary.c b/src/lib/src/fwts_summary.c
index 924e9b81..9202be3b 100644
--- a/src/lib/src/fwts_summary.c
+++ b/src/lib/src/fwts_summary.c
@@ -57,8 +57,6 @@  static const int summary_levels[] = {
 /* list of summary items per error level */
 static fwts_list *fwts_summaries[SUMMARY_MAX];
 
-void fwts_summary_deinit(void);
-
 /*
  *  fwts_summary_init()
  *	initialise