Message ID | 20171203125619.30919-1-daggs@gmx.com |
---|---|
State | Superseded |
Headers | show |
Series | [1/8] meson-tools: New Package | expand |
Hello, Thanks for this patch series! On Sun, 3 Dec 2017 14:56:12 +0200, Dagg Stompler wrote: > all amlogic's meson based soc require a signed firmware to boot, this > package provides a binary to do so. > > Signed-off-by: Dagg Stompler <daggs@gmx.com> I was confused originally when reading this patch, because I thought you were talking about the Meson build system (http://mesonbuild.com/) and not the Meson family of SoC (http://linux-meson.com/doku.php). Minor nit on the commit title, I prefer lower-case "new" rather than you. For your other commits in the same series, please drop the leading "." in the commit titles. > diff --git a/package/meson-tools/0001-support_crosscompile.patch b/package/meson-tools/0001-support_crosscompile.patch > new file mode 100644 > index 0000000000..ef937f78ab > --- /dev/null > +++ b/package/meson-tools/0001-support_crosscompile.patch We want this to be a Git formatted patch (i.e generated with git format-patch), to have a description and Signed-off-by. Note that those requirements for package patches are detailed in the Buildroot documentation. > diff --git a/package/meson-tools/Config.in.host b/package/meson-tools/Config.in.host > new file mode 100644 > index 0000000000..d97a14ac41 > --- /dev/null > +++ b/package/meson-tools/Config.in.host > @@ -0,0 +1,9 @@ > +config BR2_PACKAGE_HOST_MESON_TOOLS > + bool "host meson tools" bool "host meson-tools" instead. > + help > + meson-tools is a collection of tools for use with > + the Amlogic Meson family of ARM based SoCs. > + it allows managment of signatures which are required "It allows the management of..." > + for booting amlogic based boards with u-boot. > + > + https://github.com/afaerber/meson-tools > diff --git a/package/meson-tools/meson-tools.hash b/package/meson-tools/meson-tools.hash > new file mode 100644 > index 0000000000..b5f844ab58 > --- /dev/null > +++ b/package/meson-tools/meson-tools.hash > @@ -0,0 +1,2 @@ > +# Locally calculated > +sha256 5a956f5a6ff8c45fc79d649982287c4548a1df4f0ef9e5aa6584493d552a54a3 meson-tools-5e01cbadc6f6f21ad88a63492a83182fc4b19d37.tar.gz > diff --git a/package/meson-tools/meson-tools.mk b/package/meson-tools/meson-tools.mk > new file mode 100644 > index 0000000000..19f5bf543b > --- /dev/null > +++ b/package/meson-tools/meson-tools.mk > @@ -0,0 +1,31 @@ > +################################################################################ > +# > +# meson-tools > +# > +################################################################################ > + > +HOST_MESON_TOOLS_VERSION = 5e01cbadc6f6f21ad88a63492a83182fc4b19d37 > +HOST_MESON_TOOLS_SITE = $(call github,afaerber,meson-tools,$(HOST_MESON_TOOLS_VERSION)) > +HOST_MESON_TOOLS_LICENSE = GPL-2.0+ > +HOST_MESON_TOOLS_LICENSE_FILES = COPYING README.md > +HOST_MESON_TOOLS_DEPENDENCIES += host-openssl = instead of +=. > + > +HOST_MESON_TOOLS_MAKE_OPTS = CC="$(HOSTCC)" \ > + CFLAGS="$(HOST_CFLAGS)" \ > + LDFLAGS="$(HOST_LDFLAGS)" Can you try passing $(HOST_CONFIGURE_OPTS) instead ? > + > +define HOST_MESON_TOOLS_BUILD_CMDS > + $(MAKE) -C $(@D) $(HOST_MESON_TOOLS_MAKE_OPTS) > +endef > + > +define HOST_MESON_TOOLS_INSTALL_BIN > + $(INSTALL) -m 0755 $(@D)/$(1) $(HOST_DIR)/bin > +endef > + > +define HOST_MESON_TOOLS_INSTALL_CMDS > + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlbootsig) > + $(call HOST_MESON_TOOLS_INSTALL_BIN,unamlbootsig) > + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlinfo) Better: HOST_MESON_TOOLS_PROGS = amlbootsig unamlbootsig amlinfo define HOST_MESON_TOOLS_INSTALL_CMDS $(foreach f,$(HOST_MESON_TOOLS_PROGS), $(INSTALL) -D -m 0755 $(@D)/$(f) $(HOST_DIR)/bin/$(f) ) endef Best regards, Thomas Petazzoni
Greetings Thomas, > Sent: Sunday, December 03, 2017 at 3:23 PM > From: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com> > To: "Dagg Stompler" <daggs@gmx.com> > Cc: buildroot@buildroot.org > Subject: Re: [Buildroot] [PATCH 1/8] meson-tools: New Package > > Hello, > > Thanks for this patch series! > > On Sun, 3 Dec 2017 14:56:12 +0200, Dagg Stompler wrote: > > all amlogic's meson based soc require a signed firmware to boot, this > > package provides a binary to do so. > > > > Signed-off-by: Dagg Stompler <daggs@gmx.com> > > I was confused originally when reading this patch, because I thought > you were talking about the Meson build system (http://mesonbuild.com/) > and not the Meson family of SoC (http://linux-meson.com/doku.php). > > Minor nit on the commit title, I prefer lower-case "new" rather than > you. For your other commits in the same series, please drop the leading > "." in the commit titles. sure. > > > > diff --git a/package/meson-tools/0001-support_crosscompile.patch b/package/meson-tools/0001-support_crosscompile.patch > > new file mode 100644 > > index 0000000000..ef937f78ab > > --- /dev/null > > +++ b/package/meson-tools/0001-support_crosscompile.patch > > We want this to be a Git formatted patch (i.e generated with git > format-patch), to have a description and Signed-off-by. Note that those > requirements for package patches are detailed in the Buildroot > documentation. I'll convert it. > > > diff --git a/package/meson-tools/Config.in.host b/package/meson-tools/Config.in.host > > new file mode 100644 > > index 0000000000..d97a14ac41 > > --- /dev/null > > +++ b/package/meson-tools/Config.in.host > > @@ -0,0 +1,9 @@ > > +config BR2_PACKAGE_HOST_MESON_TOOLS > > + bool "host meson tools" > > bool "host meson-tools" instead. > > > + help > > + meson-tools is a collection of tools for use with > > + the Amlogic Meson family of ARM based SoCs. > > + it allows managment of signatures which are required > > "It allows the management of..." > > > + for booting amlogic based boards with u-boot. > > + > > + https://github.com/afaerber/meson-tools > > diff --git a/package/meson-tools/meson-tools.hash b/package/meson-tools/meson-tools.hash > > new file mode 100644 > > index 0000000000..b5f844ab58 > > --- /dev/null > > +++ b/package/meson-tools/meson-tools.hash > > @@ -0,0 +1,2 @@ > > +# Locally calculated > > +sha256 5a956f5a6ff8c45fc79d649982287c4548a1df4f0ef9e5aa6584493d552a54a3 meson-tools-5e01cbadc6f6f21ad88a63492a83182fc4b19d37.tar.gz > > diff --git a/package/meson-tools/meson-tools.mk b/package/meson-tools/meson-tools.mk > > new file mode 100644 > > index 0000000000..19f5bf543b > > --- /dev/null > > +++ b/package/meson-tools/meson-tools.mk > > @@ -0,0 +1,31 @@ > > +################################################################################ > > +# > > +# meson-tools > > +# > > +################################################################################ > > + > > +HOST_MESON_TOOLS_VERSION = 5e01cbadc6f6f21ad88a63492a83182fc4b19d37 > > +HOST_MESON_TOOLS_SITE = $(call github,afaerber,meson-tools,$(HOST_MESON_TOOLS_VERSION)) > > +HOST_MESON_TOOLS_LICENSE = GPL-2.0+ > > +HOST_MESON_TOOLS_LICENSE_FILES = COPYING README.md > > +HOST_MESON_TOOLS_DEPENDENCIES += host-openssl > > = instead of +=. > > > + > > +HOST_MESON_TOOLS_MAKE_OPTS = CC="$(HOSTCC)" \ > > + CFLAGS="$(HOST_CFLAGS)" \ > > + LDFLAGS="$(HOST_LDFLAGS)" > > Can you try passing $(HOST_CONFIGURE_OPTS) instead ? > > > + > > +define HOST_MESON_TOOLS_BUILD_CMDS > > + $(MAKE) -C $(@D) $(HOST_MESON_TOOLS_MAKE_OPTS) > > +endef > > + > > +define HOST_MESON_TOOLS_INSTALL_BIN > > + $(INSTALL) -m 0755 $(@D)/$(1) $(HOST_DIR)/bin > > +endef > > + > > +define HOST_MESON_TOOLS_INSTALL_CMDS > > + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlbootsig) > > + $(call HOST_MESON_TOOLS_INSTALL_BIN,unamlbootsig) > > + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlinfo) > > Better: > > HOST_MESON_TOOLS_PROGS = amlbootsig unamlbootsig amlinfo > > define HOST_MESON_TOOLS_INSTALL_CMDS > $(foreach f,$(HOST_MESON_TOOLS_PROGS), > $(INSTALL) -D -m 0755 $(@D)/$(f) $(HOST_DIR)/bin/$(f) > ) > endef good idea, will adjust all. > > Best regards, > > Thomas Petazzoni > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com >
Hi Dagg, On Sun, Dec 03, 2017 at 02:56:12PM +0200, Dagg Stompler wrote: > all amlogic's meson based soc require a signed firmware to boot, this > package provides a binary to do so. > > Signed-off-by: Dagg Stompler <daggs@gmx.com> > --- > package/Config.in.host | 2 +- > .../meson-tools/0001-support_crosscompile.patch | 12 +++++++++ > package/meson-tools/Config.in.host | 9 +++++++ > package/meson-tools/meson-tools.hash | 2 ++ > package/meson-tools/meson-tools.mk | 31 ++++++++++++++++++++++ > 5 files changed, 55 insertions(+), 1 deletion(-) > create mode 100644 package/meson-tools/0001-support_crosscompile.patch > create mode 100644 package/meson-tools/Config.in.host > create mode 100644 package/meson-tools/meson-tools.hash > create mode 100644 package/meson-tools/meson-tools.mk > > diff --git a/package/Config.in.host b/package/Config.in.host > index 48b6f8c7a8..78d085d44d 100644 > --- a/package/Config.in.host > +++ b/package/Config.in.host > @@ -20,13 +20,13 @@ menu "Host utilities" > source "package/genpart/Config.in.host" > source "package/go/Config.in.host" > source "package/go-bootstrap/Config.in.host" > - source "package/google-breakpad/Config.in.host" Is this change intentional? > source "package/gptfdisk/Config.in.host" > source "package/imx-usb-loader/Config.in.host" > source "package/jq/Config.in.host" > source "package/jsmin/Config.in.host" > source "package/lpc3250loader/Config.in.host" > source "package/lttng-babeltrace/Config.in.host" > + source "package/meson-tools/Config.in.host" > source "package/mfgtools/Config.in.host" > source "package/mkpasswd/Config.in.host" > source "package/mtd/Config.in.host" > diff --git a/package/meson-tools/0001-support_crosscompile.patch b/package/meson-tools/0001-support_crosscompile.patch > new file mode 100644 > index 0000000000..ef937f78ab > --- /dev/null > +++ b/package/meson-tools/0001-support_crosscompile.patch Since you are only adding a host package this patch should be named something else. But ... > @@ -0,0 +1,12 @@ > +--- a/Makefile 2017-07-22 15:51:00.000000000 +0300 > ++++ b/Makefile 2017-07-22 15:51:26.000000000 +0300 > +@@ -1,7 +1,7 @@ > + all: amlbootsig unamlbootsig amlinfo > + > +-CFLAGS = -g > +-LDFLAGS = -lcrypto > ++override CFLAGS += -g > ++override LDFLAGS += -lssl -lcrypto ... you do not actually use this override capability as far as I can see ... [snip] > diff --git a/package/meson-tools/meson-tools.mk b/package/meson-tools/meson-tools.mk > new file mode 100644 > index 0000000000..19f5bf543b > --- /dev/null > +++ b/package/meson-tools/meson-tools.mk > @@ -0,0 +1,31 @@ > +################################################################################ > +# > +# meson-tools > +# > +################################################################################ > + > +HOST_MESON_TOOLS_VERSION = 5e01cbadc6f6f21ad88a63492a83182fc4b19d37 > +HOST_MESON_TOOLS_SITE = $(call github,afaerber,meson-tools,$(HOST_MESON_TOOLS_VERSION)) > +HOST_MESON_TOOLS_LICENSE = GPL-2.0+ > +HOST_MESON_TOOLS_LICENSE_FILES = COPYING README.md > +HOST_MESON_TOOLS_DEPENDENCIES += host-openssl > + > +HOST_MESON_TOOLS_MAKE_OPTS = CC="$(HOSTCC)" \ > + CFLAGS="$(HOST_CFLAGS)" \ > + LDFLAGS="$(HOST_LDFLAGS)" > + > +define HOST_MESON_TOOLS_BUILD_CMDS > + $(MAKE) -C $(@D) $(HOST_MESON_TOOLS_MAKE_OPTS) ... because you pass the make variables as options, thus forcing their value. So the patch might not be needed. > +endef > + > +define HOST_MESON_TOOLS_INSTALL_BIN > + $(INSTALL) -m 0755 $(@D)/$(1) $(HOST_DIR)/bin > +endef > + > +define HOST_MESON_TOOLS_INSTALL_CMDS > + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlbootsig) > + $(call HOST_MESON_TOOLS_INSTALL_BIN,unamlbootsig) > + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlinfo) > +endef > + > +$(eval $(host-generic-package)) baruch
Greetings Baruch, > Sent: Sunday, December 03, 2017 at 9:06 PM > From: "Baruch Siach" <baruch@tkos.co.il> > To: "Dagg Stompler" <daggs@gmx.com> > Cc: buildroot@buildroot.org > Subject: Re: [Buildroot] [PATCH 1/8] meson-tools: New Package > > Hi Dagg, > > On Sun, Dec 03, 2017 at 02:56:12PM +0200, Dagg Stompler wrote: > > all amlogic's meson based soc require a signed firmware to boot, this > > package provides a binary to do so. > > > > Signed-off-by: Dagg Stompler <daggs@gmx.com> > > --- > > package/Config.in.host | 2 +- > > .../meson-tools/0001-support_crosscompile.patch | 12 +++++++++ > > package/meson-tools/Config.in.host | 9 +++++++ > > package/meson-tools/meson-tools.hash | 2 ++ > > package/meson-tools/meson-tools.mk | 31 ++++++++++++++++++++++ > > 5 files changed, 55 insertions(+), 1 deletion(-) > > create mode 100644 package/meson-tools/0001-support_crosscompile.patch > > create mode 100644 package/meson-tools/Config.in.host > > create mode 100644 package/meson-tools/meson-tools.hash > > create mode 100644 package/meson-tools/meson-tools.mk > > > > diff --git a/package/Config.in.host b/package/Config.in.host > > index 48b6f8c7a8..78d085d44d 100644 > > --- a/package/Config.in.host > > +++ b/package/Config.in.host > > @@ -20,13 +20,13 @@ menu "Host utilities" > > source "package/genpart/Config.in.host" > > source "package/go/Config.in.host" > > source "package/go-bootstrap/Config.in.host" > > - source "package/google-breakpad/Config.in.host" > > Is this change intentional? no, it got slipped in by mistake, thanks. > > > source "package/gptfdisk/Config.in.host" > > source "package/imx-usb-loader/Config.in.host" > > source "package/jq/Config.in.host" > > source "package/jsmin/Config.in.host" > > source "package/lpc3250loader/Config.in.host" > > source "package/lttng-babeltrace/Config.in.host" > > + source "package/meson-tools/Config.in.host" > > source "package/mfgtools/Config.in.host" > > source "package/mkpasswd/Config.in.host" > > source "package/mtd/Config.in.host" > > diff --git a/package/meson-tools/0001-support_crosscompile.patch b/package/meson-tools/0001-support_crosscompile.patch > > new file mode 100644 > > index 0000000000..ef937f78ab > > --- /dev/null > > +++ b/package/meson-tools/0001-support_crosscompile.patch > > Since you are only adding a host package this patch should be named something > else. But ... good point, look like leftovers from previous iteration. > > > @@ -0,0 +1,12 @@ > > +--- a/Makefile 2017-07-22 15:51:00.000000000 +0300 > > ++++ b/Makefile 2017-07-22 15:51:26.000000000 +0300 > > +@@ -1,7 +1,7 @@ > > + all: amlbootsig unamlbootsig amlinfo > > + > > +-CFLAGS = -g > > +-LDFLAGS = -lcrypto > > ++override CFLAGS += -g > > ++override LDFLAGS += -lssl -lcrypto > > ... you do not actually use this override capability as far as I can see ... > > [snip] indeed. > > > diff --git a/package/meson-tools/meson-tools.mk b/package/meson-tools/meson-tools.mk > > new file mode 100644 > > index 0000000000..19f5bf543b > > --- /dev/null > > +++ b/package/meson-tools/meson-tools.mk > > @@ -0,0 +1,31 @@ > > +################################################################################ > > +# > > +# meson-tools > > +# > > +################################################################################ > > + > > +HOST_MESON_TOOLS_VERSION = 5e01cbadc6f6f21ad88a63492a83182fc4b19d37 > > +HOST_MESON_TOOLS_SITE = $(call github,afaerber,meson-tools,$(HOST_MESON_TOOLS_VERSION)) > > +HOST_MESON_TOOLS_LICENSE = GPL-2.0+ > > +HOST_MESON_TOOLS_LICENSE_FILES = COPYING README.md > > +HOST_MESON_TOOLS_DEPENDENCIES += host-openssl > > + > > +HOST_MESON_TOOLS_MAKE_OPTS = CC="$(HOSTCC)" \ > > + CFLAGS="$(HOST_CFLAGS)" \ > > + LDFLAGS="$(HOST_LDFLAGS)" > > + > > +define HOST_MESON_TOOLS_BUILD_CMDS > > + $(MAKE) -C $(@D) $(HOST_MESON_TOOLS_MAKE_OPTS) > > ... because you pass the make variables as options, thus forcing their value. > So the patch might not be needed. correct. > > > +endef > > + > > +define HOST_MESON_TOOLS_INSTALL_BIN > > + $(INSTALL) -m 0755 $(@D)/$(1) $(HOST_DIR)/bin > > +endef > > + > > +define HOST_MESON_TOOLS_INSTALL_CMDS > > + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlbootsig) > > + $(call HOST_MESON_TOOLS_INSTALL_BIN,unamlbootsig) > > + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlinfo) > > +endef > > + > > +$(eval $(host-generic-package)) > > baruch > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - >
diff --git a/package/Config.in.host b/package/Config.in.host index 48b6f8c7a8..78d085d44d 100644 --- a/package/Config.in.host +++ b/package/Config.in.host @@ -20,13 +20,13 @@ menu "Host utilities" source "package/genpart/Config.in.host" source "package/go/Config.in.host" source "package/go-bootstrap/Config.in.host" - source "package/google-breakpad/Config.in.host" source "package/gptfdisk/Config.in.host" source "package/imx-usb-loader/Config.in.host" source "package/jq/Config.in.host" source "package/jsmin/Config.in.host" source "package/lpc3250loader/Config.in.host" source "package/lttng-babeltrace/Config.in.host" + source "package/meson-tools/Config.in.host" source "package/mfgtools/Config.in.host" source "package/mkpasswd/Config.in.host" source "package/mtd/Config.in.host" diff --git a/package/meson-tools/0001-support_crosscompile.patch b/package/meson-tools/0001-support_crosscompile.patch new file mode 100644 index 0000000000..ef937f78ab --- /dev/null +++ b/package/meson-tools/0001-support_crosscompile.patch @@ -0,0 +1,12 @@ +--- a/Makefile 2017-07-22 15:51:00.000000000 +0300 ++++ b/Makefile 2017-07-22 15:51:26.000000000 +0300 +@@ -1,7 +1,7 @@ + all: amlbootsig unamlbootsig amlinfo + +-CFLAGS = -g +-LDFLAGS = -lcrypto ++override CFLAGS += -g ++override LDFLAGS += -lssl -lcrypto + + amlbootsig.o unamlbootsig.o amlinfo.o: meson.h fip.h + diff --git a/package/meson-tools/Config.in.host b/package/meson-tools/Config.in.host new file mode 100644 index 0000000000..d97a14ac41 --- /dev/null +++ b/package/meson-tools/Config.in.host @@ -0,0 +1,9 @@ +config BR2_PACKAGE_HOST_MESON_TOOLS + bool "host meson tools" + help + meson-tools is a collection of tools for use with + the Amlogic Meson family of ARM based SoCs. + it allows managment of signatures which are required + for booting amlogic based boards with u-boot. + + https://github.com/afaerber/meson-tools diff --git a/package/meson-tools/meson-tools.hash b/package/meson-tools/meson-tools.hash new file mode 100644 index 0000000000..b5f844ab58 --- /dev/null +++ b/package/meson-tools/meson-tools.hash @@ -0,0 +1,2 @@ +# Locally calculated +sha256 5a956f5a6ff8c45fc79d649982287c4548a1df4f0ef9e5aa6584493d552a54a3 meson-tools-5e01cbadc6f6f21ad88a63492a83182fc4b19d37.tar.gz diff --git a/package/meson-tools/meson-tools.mk b/package/meson-tools/meson-tools.mk new file mode 100644 index 0000000000..19f5bf543b --- /dev/null +++ b/package/meson-tools/meson-tools.mk @@ -0,0 +1,31 @@ +################################################################################ +# +# meson-tools +# +################################################################################ + +HOST_MESON_TOOLS_VERSION = 5e01cbadc6f6f21ad88a63492a83182fc4b19d37 +HOST_MESON_TOOLS_SITE = $(call github,afaerber,meson-tools,$(HOST_MESON_TOOLS_VERSION)) +HOST_MESON_TOOLS_LICENSE = GPL-2.0+ +HOST_MESON_TOOLS_LICENSE_FILES = COPYING README.md +HOST_MESON_TOOLS_DEPENDENCIES += host-openssl + +HOST_MESON_TOOLS_MAKE_OPTS = CC="$(HOSTCC)" \ + CFLAGS="$(HOST_CFLAGS)" \ + LDFLAGS="$(HOST_LDFLAGS)" + +define HOST_MESON_TOOLS_BUILD_CMDS + $(MAKE) -C $(@D) $(HOST_MESON_TOOLS_MAKE_OPTS) +endef + +define HOST_MESON_TOOLS_INSTALL_BIN + $(INSTALL) -m 0755 $(@D)/$(1) $(HOST_DIR)/bin +endef + +define HOST_MESON_TOOLS_INSTALL_CMDS + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlbootsig) + $(call HOST_MESON_TOOLS_INSTALL_BIN,unamlbootsig) + $(call HOST_MESON_TOOLS_INSTALL_BIN,amlinfo) +endef + +$(eval $(host-generic-package))
all amlogic's meson based soc require a signed firmware to boot, this package provides a binary to do so. Signed-off-by: Dagg Stompler <daggs@gmx.com> --- package/Config.in.host | 2 +- .../meson-tools/0001-support_crosscompile.patch | 12 +++++++++ package/meson-tools/Config.in.host | 9 +++++++ package/meson-tools/meson-tools.hash | 2 ++ package/meson-tools/meson-tools.mk | 31 ++++++++++++++++++++++ 5 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 package/meson-tools/0001-support_crosscompile.patch create mode 100644 package/meson-tools/Config.in.host create mode 100644 package/meson-tools/meson-tools.hash create mode 100644 package/meson-tools/meson-tools.mk