| Message ID | 20170225204439.2gqs2rnnmlrck22s@tarshish |
|---|---|
| State | Not Applicable |
| Headers | show |
Baruch, All, On 2017-02-25 22:44 +0200, Baruch Siach spake thusly: > On Sat, Feb 25, 2017 at 07:51:29PM +0100, Yann E. MORIN wrote: > > cmake 3.7 causes serious regressions in some cmake-based packages, > > related to how RPATH is handled. > > > > See for example: > > > > - domoticz : http://autobuild.buildroot.org/results/fd0/fd0ba54c7abf973691b39a0ca1bb4e07d749593a/ > > - freerdp : http://autobuild.buildroot.org/results/5d4/5d429d0e288754a541ee5d8be515454c5fccd28b/ > > - libcec : http://autobuild.buildroot.org/results/3f3/3f3593bab7734dd274faf5b5690895e9424cbb89/ > > > > (and many others) > > > > All causes the link to be attemped against host libraries, which is > > definitely not appropriate... > > > > Properly fixing this so close to the release is problematic; we'd risk > > having to hunt down packages one by one. > > What about host installed cmake? Maybe do something like the following > (untested) to blacklist version 3.7.x? Good catch, indeed. > diff --git a/support/dependencies/check-host-cmake.sh b/support/dependencies/check-host-cmake.sh > index 9b63b0648d97..1c4fec8cae41 100755 > --- a/support/dependencies/check-host-cmake.sh > +++ b/support/dependencies/check-host-cmake.sh > @@ -27,6 +27,10 @@ version="$(${cmake} --version \ > major="${version%.*}" > minor="${version#*.}" > > +if [ ${version} = 3.7 ]; then > + exit 1 Minor nit: the rest of the script uses leading spaces. Also, we should probably catch >= 3.7, no? Regards, Yann E. MORIN. > +fi > + > if [ ${major} -gt ${major_min} ]; then > echo "${cmake}" > else > > baruch > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Hi Yann, On Sat, Feb 25, 2017 at 11:10:07PM +0100, Yann E. MORIN wrote: > On 2017-02-25 22:44 +0200, Baruch Siach spake thusly: > > On Sat, Feb 25, 2017 at 07:51:29PM +0100, Yann E. MORIN wrote: > > > cmake 3.7 causes serious regressions in some cmake-based packages, > > > related to how RPATH is handled. > > > > > > See for example: > > > > > > - domoticz : http://autobuild.buildroot.org/results/fd0/fd0ba54c7abf973691b39a0ca1bb4e07d749593a/ > > > - freerdp : http://autobuild.buildroot.org/results/5d4/5d429d0e288754a541ee5d8be515454c5fccd28b/ > > > - libcec : http://autobuild.buildroot.org/results/3f3/3f3593bab7734dd274faf5b5690895e9424cbb89/ > > > > > > (and many others) > > > > > > All causes the link to be attemped against host libraries, which is > > > definitely not appropriate... > > > > > > Properly fixing this so close to the release is problematic; we'd risk > > > having to hunt down packages one by one. > > > > What about host installed cmake? Maybe do something like the following > > (untested) to blacklist version 3.7.x? > > Good catch, indeed. > > > diff --git a/support/dependencies/check-host-cmake.sh b/support/dependencies/check-host-cmake.sh > > index 9b63b0648d97..1c4fec8cae41 100755 > > --- a/support/dependencies/check-host-cmake.sh > > +++ b/support/dependencies/check-host-cmake.sh > > @@ -27,6 +27,10 @@ version="$(${cmake} --version \ > > major="${version%.*}" > > minor="${version#*.}" > > > > +if [ ${version} = 3.7 ]; then > > + exit 1 > > Minor nit: the rest of the script uses leading spaces. > > Also, we should probably catch >= 3.7, no? The latest cmake release is 3.7.2. Let's hope that this issue gets fixed before 3.8. If not, we can always add more blacklisted versions. baruch
diff --git a/support/dependencies/check-host-cmake.sh b/support/dependencies/check-host-cmake.sh index 9b63b0648d97..1c4fec8cae41 100755 --- a/support/dependencies/check-host-cmake.sh +++ b/support/dependencies/check-host-cmake.sh @@ -27,6 +27,10 @@ version="$(${cmake} --version \ major="${version%.*}" minor="${version#*.}" +if [ ${version} = 3.7 ]; then + exit 1 +fi + if [ ${major} -gt ${major_min} ]; then echo "${cmake}" else