From patchwork Sat Feb 25 20:44:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baruch Siach X-Patchwork-Id: 732440 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vW0Mt282wz9s85 for ; Sun, 26 Feb 2017 07:44:57 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E2A7627E0B; Sat, 25 Feb 2017 20:44:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id slk89saTYisv; Sat, 25 Feb 2017 20:44:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 98BB627594; Sat, 25 Feb 2017 20:44:49 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id F02251BFDAD for ; Sat, 25 Feb 2017 20:44:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id EC4B388BA0 for ; Sat, 25 Feb 2017 20:44:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k3E82Pp3tHyZ for ; Sat, 25 Feb 2017 20:44:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx.tkos.co.il (guitar.tcltek.co.il [192.115.133.116]) by hemlock.osuosl.org (Postfix) with ESMTPS id B2C2588B7A for ; Sat, 25 Feb 2017 20:44:45 +0000 (UTC) Received: from tarshish (unknown [10.0.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id BB5704406EE; Sat, 25 Feb 2017 22:44:22 +0200 (IST) Date: Sat, 25 Feb 2017 22:44:39 +0200 From: Baruch Siach To: "Yann E. MORIN" Message-ID: <20170225204439.2gqs2rnnmlrck22s@tarshish> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Cc: Thomas Petazzoni , buildroot@buildroot.org Subject: Re: [Buildroot] [PATCH 0/4] package/cmake: revert the bump to 3.7 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Hi Yann, On Sat, Feb 25, 2017 at 07:51:29PM +0100, Yann E. MORIN wrote: > cmake 3.7 causes serious regressions in some cmake-based packages, > related to how RPATH is handled. > > See for example: > > - domoticz : http://autobuild.buildroot.org/results/fd0/fd0ba54c7abf973691b39a0ca1bb4e07d749593a/ > - freerdp : http://autobuild.buildroot.org/results/5d4/5d429d0e288754a541ee5d8be515454c5fccd28b/ > - libcec : http://autobuild.buildroot.org/results/3f3/3f3593bab7734dd274faf5b5690895e9424cbb89/ > > (and many others) > > All causes the link to be attemped against host libraries, which is > definitely not appropriate... > > Properly fixing this so close to the release is problematic; we'd risk > having to hunt down packages one by one. What about host installed cmake? Maybe do something like the following (untested) to blacklist version 3.7.x? baruch diff --git a/support/dependencies/check-host-cmake.sh b/support/dependencies/check-host-cmake.sh index 9b63b0648d97..1c4fec8cae41 100755 --- a/support/dependencies/check-host-cmake.sh +++ b/support/dependencies/check-host-cmake.sh @@ -27,6 +27,10 @@ version="$(${cmake} --version \ major="${version%.*}" minor="${version#*.}" +if [ ${version} = 3.7 ]; then + exit 1 +fi + if [ ${major} -gt ${major_min} ]; then echo "${cmake}" else