diff mbox

[2/2,v2] kodi: enable optional dependency on libamcodec

Message ID 20160610115151.19226-2-daggs@gmx.com
State Superseded
Headers show

Commit Message

Dagg Stompler June 10, 2016, 11:51 a.m. UTC
This is based on what LibreELEC is doing.

v1 -> v2:
 - fixed mail title and comment

Signed-off-by: Dagg Stompler <daggs@gmx.com>
---
 package/kodi/kodi.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bernd Kuhls June 10, 2016, 4:33 p.m. UTC | #1
Am Fri, 10 Jun 2016 14:51:51 +0300 schrieb Dagg Stompler:

> +else ifeq ($(BR2_PACKAGE_LIBAMCODEC),y)
> +KODI_DEPENDENCIES += libamcodec
> +KODI_CONF_OPTS += --enable-codec=amcodec

Hi,

did you find out whether this option is necessary in the future?
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/150321

Regards, Bernd
Dagg Stompler June 11, 2016, 4:46 a.m. UTC | #2
Greetings,
> Am Fri, 10 Jun 2016 14:51:51 +0300 schrieb Dagg Stompler:
> 
> > +else ifeq ($(BR2_PACKAGE_LIBAMCODEC),y)
> > +KODI_DEPENDENCIES += libamcodec
> > +KODI_CONF_OPTS += --enable-codec=amcodec
> 
> Hi,
> 
> did you find out whether this option is necessary in the future?
> http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/150321
> 
> Regards, Bernd
> 

not sure I follow, the change described here is regarding andorid.
unless I'm mistaken, my change only affects linux.
am I wrong?

Dagg.
James Knight June 25, 2016, 4:29 a.m. UTC | #3
Daggs, Bernd;

On Sat, Jun 11, 2016 at 12:46 AM, daggs <daggs@gmx.com> wrote:
> the change described here is regarding andorid.
> unless I'm mistaken

I believe you are correct. Examining the commit [1] shows that the
change is really Android specific (whether or not the merge's
description [2] doesn't indicate so).

[1]: https://github.com/xbmc/xbmc/pull/9688/commits/1015c480966d786eb050ce3d3701cdbf5231d1f5
[2]: https://github.com/xbmc/xbmc/pull/9688
diff mbox

Patch

diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index e163c24..d0b2c22 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -56,6 +56,9 @@  endif
 ifeq ($(BR2_PACKAGE_LIBFSLVPUWRAP),y)
 KODI_DEPENDENCIES += libfslvpuwrap
 KODI_CONF_OPTS += --enable-codec=imxvpu
+else ifeq ($(BR2_PACKAGE_LIBAMCODEC),y)
+KODI_DEPENDENCIES += libamcodec
+KODI_CONF_OPTS += --enable-codec=amcodec
 endif
 
 ifeq ($(BR2_PACKAGE_LIBCAP),y)