diff mbox

[08/32] package/systemd: remove networkd depends from timesyncd

Message ID 1456437341-19025-9-git-send-email-gabe@hashrabbit.co
State Accepted
Headers show

Commit Message

Gabe Evans Feb. 25, 2016, 9:55 p.m. UTC
systemd-timesyncd can function without systemd-networkd.

Signed-off-by: Gabe Evans <gabe@hashrabbit.co>
---
 package/systemd/Config.in | 1 -
 1 file changed, 1 deletion(-)

Comments

Arnout Vandecappelle Feb. 26, 2016, 12:10 a.m. UTC | #1
On 02/25/16 22:55, Gabe Evans wrote:
> systemd-timesyncd can function without systemd-networkd.

 Assuming that this is true:

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 However,

> 
> Signed-off-by: Gabe Evans <gabe@hashrabbit.co>
> ---
>  package/systemd/Config.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index 6edfba1..5d6759d 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -98,7 +98,6 @@ config BR2_PACKAGE_SYSTEMD_NETWORKD
>  
>  config BR2_PACKAGE_SYSTEMD_TIMESYNCD
>  	bool "enable SNTP client"

 SNTP?

> -	depends on BR2_PACKAGE_SYSTEMD_NETWORKD
>  	help
>  	  systemd-timesyncd is a service that may be used to synchronize the
>  	  local system clock with a Network Time Protocol Server.

 Server -> server?

 Those are separate patches, obviously.

 Regards,
 Arnout

>
Thomas Petazzoni Feb. 29, 2016, 9:50 p.m. UTC | #2
Dear Gabe Evans,

On Thu, 25 Feb 2016 21:55:17 +0000, Gabe Evans wrote:
> systemd-timesyncd can function without systemd-networkd.
> 
> Signed-off-by: Gabe Evans <gabe@hashrabbit.co>
> ---
>  package/systemd/Config.in | 1 -
>  1 file changed, 1 deletion(-)

Applied to next, thanks.

Thomas
Thomas Petazzoni Feb. 29, 2016, 9:52 p.m. UTC | #3
Arnout,

On Fri, 26 Feb 2016 01:10:00 +0100, Arnout Vandecappelle wrote:

> >  config BR2_PACKAGE_SYSTEMD_TIMESYNCD
> >  	bool "enable SNTP client"
> 
>  SNTP?

https://tools.ietf.org/html/rfc4330

> > -	depends on BR2_PACKAGE_SYSTEMD_NETWORKD
> >  	help
> >  	  systemd-timesyncd is a service that may be used to synchronize the
> >  	  local system clock with a Network Time Protocol Server.
> 
>  Server -> server?

Fixed.

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/systemd/Config.in b/package/systemd/Config.in
index 6edfba1..5d6759d 100644
--- a/package/systemd/Config.in
+++ b/package/systemd/Config.in
@@ -98,7 +98,6 @@  config BR2_PACKAGE_SYSTEMD_NETWORKD
 
 config BR2_PACKAGE_SYSTEMD_TIMESYNCD
 	bool "enable SNTP client"
-	depends on BR2_PACKAGE_SYSTEMD_NETWORKD
 	help
 	  systemd-timesyncd is a service that may be used to synchronize the
 	  local system clock with a Network Time Protocol Server.