| Message ID | 1456336840-14890-2-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Changes Requested |
| Headers | show |
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes: > It's been deprecated for some time now. > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > Config.in.legacy | 9 +++++++++ > package/gcc/Config.in.host | 26 -------------------------- > 2 files changed, 9 insertions(+), 26 deletions(-) > diff --git a/Config.in.legacy b/Config.in.legacy > index 081bacd..7d2e5e7 100644 > --- a/Config.in.legacy > +++ b/Config.in.legacy > @@ -143,6 +143,15 @@ comment "----------------------------------------------------" > endif > ############################################################################### > +comment "Legacy options removed in 2016.05" > + > +config BR2_GCC_VERSION_4_5_X > + bool "gcc 4.5.x has been removed" > + select BR2_LEGACY > + help > + The 4.5.x version of gcc has been removed. Use a newer > + version instead. > + > comment "Legacy options removed in 2016.02" > config BR2_PACKAGE_DOVECOT_BZIP2 > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > index c677c65..f86a12e 100644 > --- a/package/gcc/Config.in.host > +++ b/package/gcc/Config.in.host > @@ -13,31 +13,6 @@ choice > help > Select the version of gcc you wish to use. > - config BR2_GCC_VERSION_4_5_X > - bool "gcc 4.5.x" > - depends on BR2_DEPRECATED_SINCE_2015_05 > - # Broken or unsupported architectures > - depends on !BR2_microblaze && !BR2_aarch64 && !BR2_arc \ > - && !BR2_powerpc64le && !BR2_nios2 > - # Broken or unsupported ARM cores > - depends on !BR2_cortex_a7 && !BR2_cortex_a12 && \ > - !BR2_cortex_a15 && !BR2_fa526 && !BR2_pj4 This doesn't apply (seems like you you don't have the commit adding the A17 ARM variant), and you forgot to remove our gcc patches. What do we do with our 4.5 based external toolchains and BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 (used by directfb)? Care to send a v2?
On 24/02/16 17:02, Peter Korsgaard wrote: > This doesn't apply (seems like you you don't have the commit adding the > A17 ARM variant), and you forgot to remove our gcc patches. > > What do we do with our 4.5 based external toolchains and > BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 (used by directfb)? > > Care to send a v2? Sure. I normally pile up on master since the next branch doesn't last much. Regards.
Dear Peter Korsgaard, On Wed, 24 Feb 2016 21:02:40 +0100, Peter Korsgaard wrote: > What do we do with our 4.5 based external toolchains and > BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 (used by directfb)? I think the BR2_TOOLCHAIN_GCC_AT_LEAST_* must be kept for pretty much all versions of gcc. This symbol is not related to whether we support that gcc version in our internal toolchain backend or not. Possibly any gcc version can be used with the external toolchain backend. Best regards, Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Dear Peter Korsgaard, > On Wed, 24 Feb 2016 21:02:40 +0100, Peter Korsgaard wrote: >> What do we do with our 4.5 based external toolchains and >> BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 (used by directfb)? > I think the BR2_TOOLCHAIN_GCC_AT_LEAST_* must be kept for pretty much > all versions of gcc. This symbol is not related to whether we support > that gcc version in our internal toolchain backend or not. Possibly any > gcc version can be used with the external toolchain backend. True, but we might consider removing preconfigured external toolchains using ancient versions if there's sensible newer alternatives available.
Hello, On Thu, 25 Feb 2016 10:57:28 +0100, Peter Korsgaard wrote: > > Dear Peter Korsgaard, > > On Wed, 24 Feb 2016 21:02:40 +0100, Peter Korsgaard wrote: > > >> What do we do with our 4.5 based external toolchains and > >> BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 (used by directfb)? > > > I think the BR2_TOOLCHAIN_GCC_AT_LEAST_* must be kept for pretty much > > all versions of gcc. This symbol is not related to whether we support > > that gcc version in our internal toolchain backend or not. Possibly any > > gcc version can be used with the external toolchain backend. > > True, but we might consider removing preconfigured external toolchains > using ancient versions if there's sensible newer alternatives available. Right. But I like to keep those crappy old preconfigured external toolchains, because it forces us to test things with old gcc versions, old kernel headers and all. Some users are probably forced to use old gcc version for some reason, so I like to keep testing a bit the old stuff. You could object that we could continue to do this testing in the autobuilders by supporting those toolchains as "custom external toolchains" and not have them as preconfigured toolchains :-) Thomas
On 25/02/16 06:57, Peter Korsgaard wrote: > >> What do we do with our 4.5 based external toolchains and > >> BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 (used by directfb)? > > > I think the BR2_TOOLCHAIN_GCC_AT_LEAST_* must be kept for pretty much > > all versions of gcc. This symbol is not related to whether we support > > that gcc version in our internal toolchain backend or not. Possibly any > > gcc version can be used with the external toolchain backend. > > True, but we might consider removing preconfigured external toolchains > using ancient versions if there's sensible newer alternatives available. Blackfin is 4.5.x so at least this low we must keep. Regards.
Dear Gustavo Zacarias, On Thu, 25 Feb 2016 07:53:05 -0300, Gustavo Zacarias wrote: > On 25/02/16 06:57, Peter Korsgaard wrote: > > > >> What do we do with our 4.5 based external toolchains and > > >> BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 (used by directfb)? > > > > > I think the BR2_TOOLCHAIN_GCC_AT_LEAST_* must be kept for pretty much > > > all versions of gcc. This symbol is not related to whether we support > > > that gcc version in our internal toolchain backend or not. Possibly any > > > gcc version can be used with the external toolchain backend. > > > > True, but we might consider removing preconfigured external toolchains > > using ancient versions if there's sensible newer alternatives available. > > Blackfin is 4.5.x so at least this low we must keep. Blackfin is actually 4.3. They have an alpha 4.5 compiler, but when we switched to it, many things broke and the ADI guys told us to stay on 4.3. Best regards, Thomas
On 25/02/16 09:43, Thomas Petazzoni wrote: > Blackfin is actually 4.3. > > They have an alpha 4.5 compiler, but when we switched to it, many > things broke and the ADI guys told us to stay on 4.3. > > Best regards, > > Thomas Ah yes, i took a random peek at the bfin tarballs i have cached. Anyway, the more reason to keep 4.5 if 4.3 is still used. Regards.
diff --git a/Config.in.legacy b/Config.in.legacy index 081bacd..7d2e5e7 100644 --- a/Config.in.legacy +++ b/Config.in.legacy @@ -143,6 +143,15 @@ comment "----------------------------------------------------" endif ############################################################################### +comment "Legacy options removed in 2016.05" + +config BR2_GCC_VERSION_4_5_X + bool "gcc 4.5.x has been removed" + select BR2_LEGACY + help + The 4.5.x version of gcc has been removed. Use a newer + version instead. + comment "Legacy options removed in 2016.02" config BR2_PACKAGE_DOVECOT_BZIP2 diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host index c677c65..f86a12e 100644 --- a/package/gcc/Config.in.host +++ b/package/gcc/Config.in.host @@ -13,31 +13,6 @@ choice help Select the version of gcc you wish to use. - config BR2_GCC_VERSION_4_5_X - bool "gcc 4.5.x" - depends on BR2_DEPRECATED_SINCE_2015_05 - # Broken or unsupported architectures - depends on !BR2_microblaze && !BR2_aarch64 && !BR2_arc \ - && !BR2_powerpc64le && !BR2_nios2 - # Broken or unsupported ARM cores - depends on !BR2_cortex_a7 && !BR2_cortex_a12 && \ - !BR2_cortex_a15 && !BR2_fa526 && !BR2_pj4 - # Broken or unsupported PPC cores - depends on !BR2_powerpc_e5500 && !BR2_powerpc_e6500 && \ - !BR2_powerpc_power8 - # SPARC -mcpu=leon3 appeared in gcc 4.8.x - depends on !BR2_sparc_leon3 - # Broken or unsupported X86 cores - depends on !BR2_x86_corei7 && !BR2_x86_jaguar && !BR2_x86_steamroller - # ARM EABIhf support appeared in gcc 4.6 - depends on !BR2_ARM_EABIHF - # Unsupported for MIPS R6 - depends on !BR2_mips_32r6 && !BR2_mips_64r6 - # musl patches only for gcc 4.7+ - depends on !BR2_TOOLCHAIN_BUILDROOT_MUSL - select BR2_GCC_NEEDS_MPC - select BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 - config BR2_GCC_VERSION_4_7_X bool "gcc 4.7.x" depends on BR2_DEPRECATED_SINCE_2016_05 @@ -110,7 +85,6 @@ config BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE config BR2_GCC_VERSION string - default "4.5.4" if BR2_GCC_VERSION_4_5_X default "4.7.4" if BR2_GCC_VERSION_4_7_X default "4.8.5" if BR2_GCC_VERSION_4_8_X default "4.9.3" if BR2_GCC_VERSION_4_9_X
It's been deprecated for some time now. Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- Config.in.legacy | 9 +++++++++ package/gcc/Config.in.host | 26 -------------------------- 2 files changed, 9 insertions(+), 26 deletions(-)