| Message ID | 1444597369-27828-1-git-send-email-joerg.krause@embedded.rocks |
|---|---|
| State | Accepted |
| Headers | show |
Jörg, All, On 2015-10-11 23:02 +0200, Jörg Krause spake thusly: > Remove backported from upstream patch. You could have added something like: Fix autoreconf comment that was wrong. (No need to resend, it can be fixed at commit time by a maintainer). > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > Changes v1 -> v2: > - Fix autoreconf comment (Baruch Siach) > --- > package/shairport-sync/shairport-sync.mk | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/package/shairport-sync/shairport-sync.mk b/package/shairport-sync/shairport-sync.mk > index 36d5b82..fa7100a 100644 > --- a/package/shairport-sync/shairport-sync.mk > +++ b/package/shairport-sync/shairport-sync.mk > @@ -4,15 +4,14 @@ > # > ################################################################################ > > -SHAIRPORT_SYNC_VERSION = 2.4 > +SHAIRPORT_SYNC_VERSION = 2.4.1 > SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION)) > > SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c > SHAIRPORT_SYNC_LICENSE_FILES = LICENSES > SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf > -SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch > > -# Touching configure.ac with the patches > +# git clone, no configure > SHAIRPORT_SYNC_AUTORECONF = YES > > SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \ > -- > 2.6.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Yann, On So, 2015-10-11 at 23:07 +0200, Yann E. MORIN wrote: > Jörg, All, > > On 2015-10-11 23:02 +0200, Jörg Krause spake thusly: > > Remove backported from upstream patch. > > You could have added something like: > > Fix autoreconf comment that was wrong. > > (No need to resend, it can be fixed at commit time by a maintainer). > > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Regards, > Yann E. MORIN. > > > --- > > Changes v1 -> v2: > > - Fix autoreconf comment (Baruch Siach) I did it in the changelog... Best regards Jörg Krause
Jörg, All, On 2015-10-11 23:11 +0200, Jörg Krause spake thusly: > On So, 2015-10-11 at 23:07 +0200, Yann E. MORIN wrote: > > Jörg, All, > > > > On 2015-10-11 23:02 +0200, Jörg Krause spake thusly: > > > Remove backported from upstream patch. > > > > You could have added something like: > > > > Fix autoreconf comment that was wrong. > > > > (No need to resend, it can be fixed at commit time by a maintainer). > > > > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > > > > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > > > Regards, > > Yann E. MORIN. > > > > > --- > > > Changes v1 -> v2: > > > - Fix autoreconf comment (Baruch Siach) > > I did it in the changelog... Yeah, I saw that. However, the commit-changelog in good for noting changes between versions of the patch, so that reviewers quickly notice what has changed between those two revisions of the patch. The commitlog proper is good for historical records, like "why on Earth did we change that comment 6 months ago?". The commit-changelog does not end-up in the history of the project (i.e. it is dropped when a maintainer applies the patch), while the commitlog is preserved. Regards, Yann E. MORIN.
Dear Jörg Krause, On Sun, 11 Oct 2015 23:02:49 +0200, Jörg Krause wrote: > Remove backported from upstream patch. > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > --- > Changes v1 -> v2: > - Fix autoreconf comment (Baruch Siach) > --- > package/shairport-sync/shairport-sync.mk | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Applied after tweaking the commit log as suggested by Yann, thanks! Thomas
diff --git a/package/shairport-sync/shairport-sync.mk b/package/shairport-sync/shairport-sync.mk index 36d5b82..fa7100a 100644 --- a/package/shairport-sync/shairport-sync.mk +++ b/package/shairport-sync/shairport-sync.mk @@ -4,15 +4,14 @@ # ################################################################################ -SHAIRPORT_SYNC_VERSION = 2.4 +SHAIRPORT_SYNC_VERSION = 2.4.1 SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION)) SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c SHAIRPORT_SYNC_LICENSE_FILES = LICENSES SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf -SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch -# Touching configure.ac with the patches +# git clone, no configure SHAIRPORT_SYNC_AUTORECONF = YES SHAIRPORT_SYNC_CONF_OPTS = --with-alsa \
Remove backported from upstream patch. Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- Changes v1 -> v2: - Fix autoreconf comment (Baruch Siach) --- package/shairport-sync/shairport-sync.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)