| Message ID | 12995385.iRNRCdloQv@deathstar |
|---|---|
| State | Superseded |
| Headers | show |
Dear Francesco Nwokeka, could you please send the patch in-line using "git send-email" instead of attaching the patch to the email? Also, one comment regarding your patch: > @@ -1509,6 +1506,9 @@ endif > if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS > source "package/sysvinit/Config.in" > endif > +if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS > + source "package/tar/Config.in" > +endif > source "package/util-linux/Config.in" > endmenu Since there are two packages in a row which are inside an "if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS", it would be better if you put them together into the same if clause. Something like this: > @@ -1509,6 +1506,9 @@ endif > if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS > source "package/sysvinit/Config.in" > + source "package/tar/Config.in" > endif > source "package/util-linux/Config.in" > endmenu Please label your next patch as v2 ([PATCHv2]) when you send it :-) Regards, Vincent. On 09/01/2015 01:44 PM, Francesco Nwokeka wrote: > > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot >
Hello,
On Tue, 1 Sep 2015 13:51:40 +0100, Vicente Olivert Riera wrote:
> Please label your next patch as v2 ([PATCHv2]) when you send it :-)
And also use the usual convention for the commit title:
<package>: <description>
so, something like:
tar: move to the "System tools" menu
Thanks,
Thomas
From 9077a0643a2803a67d510f90ab9d83a0960a6bcb Mon Sep 17 00:00:00 2001 From: Francesco Nwokeka <francesco.nwokeka@gmail.com> Date: Tue, 1 Sep 2015 14:37:59 +0200 Subject: [PATCH 1/1] Move tar package location to 'system-tools' This change was made because the tar package is not considered a development tool Signed-off-by: Francesco Nwokeka <francesco.nwokeka@gmail.com> --- package/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/Config.in b/package/Config.in index 6ba21a1..521deb4 100644 --- a/package/Config.in +++ b/package/Config.in @@ -140,9 +140,6 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS endif source "package/sstrip/Config.in" source "package/subversion/Config.in" -if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS - source "package/tar/Config.in" -endif source "package/tree/Config.in" source "package/yasm/Config.in" endmenu @@ -1509,6 +1506,9 @@ endif if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS source "package/sysvinit/Config.in" endif +if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS + source "package/tar/Config.in" +endif source "package/util-linux/Config.in" endmenu -- 2.5.0