| Message ID | 1438917500-12100-2-git-send-email-dja@axtens.net (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Michael Ellerman |
| Headers | show |
On Fri, 2015-08-07 at 13:18 +1000, Daniel Axtens wrote: > A few declarations were identified by sparse as needing to be static: > > /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:408:6: warning: symbol 'afu_irq_name_free' was not declared. Should it be static? > /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:467:6: warning: symbol 'afu_register_hwirqs' was not declared. Should it be static? > /scratch/dja/linux-capi/drivers/misc/cxl/file.c:254:6: warning: symbol 'afu_compat_ioctl' was not declared. Should it be static? > /scratch/dja/linux-capi/drivers/misc/cxl/file.c:399:30: warning: symbol 'afu_master_fops' was not declared. Should it be static? > > Make them static. > > Signed-off-by: Daniel Axtens <dja@axtens.net> Acked-by: Michael Neuling <mikey@neuling.org> > --- > drivers/misc/cxl/file.c | 4 ++-- > drivers/misc/cxl/irq.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/misc/cxl/file.c b/drivers/misc/cxl/file.c > index e3f4b69527a9..c8c8bfa2679b 100644 > --- a/drivers/misc/cxl/file.c > +++ b/drivers/misc/cxl/file.c > @@ -251,7 +251,7 @@ long afu_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > return -EINVAL; > } > > -long afu_compat_ioctl(struct file *file, unsigned int cmd, > +static long afu_compat_ioctl(struct file *file, unsigned int cmd, > unsigned long arg) > { > return afu_ioctl(file, cmd, arg); > @@ -396,7 +396,7 @@ const struct file_operations afu_fops = { > .mmap = afu_mmap, > }; > > -const struct file_operations afu_master_fops = { > +static const struct file_operations afu_master_fops = { > .owner = THIS_MODULE, > .open = afu_master_open, > .poll = afu_poll, > diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c > index 680cd263436d..77e5d0e7ebe1 100644 > --- a/drivers/misc/cxl/irq.c > +++ b/drivers/misc/cxl/irq.c > @@ -405,7 +405,7 @@ void cxl_release_psl_irq(struct cxl_afu *afu) > kfree(afu->psl_irq_name); > } > > -void afu_irq_name_free(struct cxl_context *ctx) > +static void afu_irq_name_free(struct cxl_context *ctx) > { > struct cxl_irq_name *irq_name, *tmp; > > @@ -464,7 +464,7 @@ out: > return -ENOMEM; > } > > -void afu_register_hwirqs(struct cxl_context *ctx) > +static void afu_register_hwirqs(struct cxl_context *ctx) > { > irq_hw_number_t hwirq; > struct cxl_irq_name *irq_name;
On Fri, 2015-07-08 at 03:18:18 UTC, Daniel Axtens wrote: > A few declarations were identified by sparse as needing to be static: > > /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:408:6: warning: symbol 'afu_irq_name_free' was not declared. Should it be static? > /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:467:6: warning: symbol 'afu_register_hwirqs' was not declared. Should it be static? > /scratch/dja/linux-capi/drivers/misc/cxl/file.c:254:6: warning: symbol 'afu_compat_ioctl' was not declared. Should it be static? > /scratch/dja/linux-capi/drivers/misc/cxl/file.c:399:30: warning: symbol 'afu_master_fops' was not declared. Should it be static? > > Make them static. > > Signed-off-by: Daniel Axtens <dja@axtens.net> > Acked-by: Michael Neuling <mikey@neuling.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/3d6b040e73387570521d cheers
diff --git a/drivers/misc/cxl/file.c b/drivers/misc/cxl/file.c index e3f4b69527a9..c8c8bfa2679b 100644 --- a/drivers/misc/cxl/file.c +++ b/drivers/misc/cxl/file.c @@ -251,7 +251,7 @@ long afu_ioctl(struct file *file, unsigned int cmd, unsigned long arg) return -EINVAL; } -long afu_compat_ioctl(struct file *file, unsigned int cmd, +static long afu_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) { return afu_ioctl(file, cmd, arg); @@ -396,7 +396,7 @@ const struct file_operations afu_fops = { .mmap = afu_mmap, }; -const struct file_operations afu_master_fops = { +static const struct file_operations afu_master_fops = { .owner = THIS_MODULE, .open = afu_master_open, .poll = afu_poll, diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c index 680cd263436d..77e5d0e7ebe1 100644 --- a/drivers/misc/cxl/irq.c +++ b/drivers/misc/cxl/irq.c @@ -405,7 +405,7 @@ void cxl_release_psl_irq(struct cxl_afu *afu) kfree(afu->psl_irq_name); } -void afu_irq_name_free(struct cxl_context *ctx) +static void afu_irq_name_free(struct cxl_context *ctx) { struct cxl_irq_name *irq_name, *tmp; @@ -464,7 +464,7 @@ out: return -ENOMEM; } -void afu_register_hwirqs(struct cxl_context *ctx) +static void afu_register_hwirqs(struct cxl_context *ctx) { irq_hw_number_t hwirq; struct cxl_irq_name *irq_name;
A few declarations were identified by sparse as needing to be static: /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:408:6: warning: symbol 'afu_irq_name_free' was not declared. Should it be static? /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:467:6: warning: symbol 'afu_register_hwirqs' was not declared. Should it be static? /scratch/dja/linux-capi/drivers/misc/cxl/file.c:254:6: warning: symbol 'afu_compat_ioctl' was not declared. Should it be static? /scratch/dja/linux-capi/drivers/misc/cxl/file.c:399:30: warning: symbol 'afu_master_fops' was not declared. Should it be static? Make them static. Signed-off-by: Daniel Axtens <dja@axtens.net> --- drivers/misc/cxl/file.c | 4 ++-- drivers/misc/cxl/irq.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)