From patchwork Fri Aug 7 03:18:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Axtens X-Patchwork-Id: 504975 X-Patchwork-Delegate: michael@ellerman.id.au Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7CB641402A8 for ; Fri, 7 Aug 2015 13:24:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.b=fbE0eqG7; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 5A3A31A1DAF for ; Fri, 7 Aug 2015 13:24:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.b=fbE0eqG7; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 50AED1A1DB4 for ; Fri, 7 Aug 2015 13:20:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.b=fbE0eqG7; dkim-atps=neutral Received: by ozlabs.org (Postfix) id 376261402B0; Fri, 7 Aug 2015 13:20:56 +1000 (AEST) Delivered-To: linuxppc-dev@ozlabs.org Received: from mail-pa0-x232.google.com (mail-pa0-x232.google.com [IPv6:2607:f8b0:400e:c03::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BC3821402AD for ; Fri, 7 Aug 2015 13:20:55 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.b=fbE0eqG7; dkim-atps=neutral Received: by pabyb7 with SMTP id yb7so45095282pab.0 for ; Thu, 06 Aug 2015 20:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GSqxDHh6Okm/5YzYfl1p0Eej2sNRY+XIqjw5yV6rNDI=; b=fbE0eqG71/IIK30Ljusf9WsS3soRmtkREXKPDyg92zX1LVVTbws+wfM6OnWDbs6FEi Q0qChsRxtbm8CI/uF96rALg7EpMEWFms4hfBX28f/DprX5KxLlIu1xm9NU3bnqTgN2ZK n/qETfXnCnhq5NbVCz6vPFbRcRd7qc22zMI7Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GSqxDHh6Okm/5YzYfl1p0Eej2sNRY+XIqjw5yV6rNDI=; b=ONaOHl1YzF/ZEc6/XYRrlN+EXsrdmj5qIW+bfjfGHeHkIK7cSb9HZA9bg5Dn5wnWT4 jWQ7i1iWxnfuLeHaXyN+CX2wprYdxqISK3k5zRcxNVDUwwBvKEVUR7OOiu9DoOhbYFjf 3KtEee32sdwFIPwqfEtJ/GbrgyGKdpREOCf+Hea9F/HHKvwmOkvB9W4nUyZ9+tn5nKNZ St8fOH2YCZ2TLHELK/UE5yn57G31ggCm1JXQ62RGm32ExFeydrvvQoJUEEQ8HUh2BtEa QXHhKo2yzWfk5WhRWGrpqJHzYE+cO0er9TH76xV2i3zMHc4MjWfkucvWUw7aEOpZ04xR rJsA== X-Gm-Message-State: ALoCoQmHx2PWvXk398U1H9UNk3D17nLzIoWmRX46Q3ywThE9MT+buZvDSD7ymWtr12DJsNbPjW4s X-Received: by 10.66.118.237 with SMTP id kp13mr10172880pab.9.1438917654117; Thu, 06 Aug 2015 20:20:54 -0700 (PDT) Received: from gamma.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id ss2sm8121681pbc.45.2015.08.06.20.20.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Aug 2015 20:20:53 -0700 (PDT) From: Daniel Axtens To: linuxppc-dev@ozlabs.org Subject: [PATCH 2/4] cxl: sparse: Make declarations static Date: Fri, 7 Aug 2015 13:18:18 +1000 Message-Id: <1438917500-12100-2-git-send-email-dja@axtens.net> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1438917500-12100-1-git-send-email-dja@axtens.net> References: <1438917500-12100-1-git-send-email-dja@axtens.net> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikey@neuling.org, Daniel Axtens , imunsie@au.ibm.com MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" A few declarations were identified by sparse as needing to be static: /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:408:6: warning: symbol 'afu_irq_name_free' was not declared. Should it be static? /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:467:6: warning: symbol 'afu_register_hwirqs' was not declared. Should it be static? /scratch/dja/linux-capi/drivers/misc/cxl/file.c:254:6: warning: symbol 'afu_compat_ioctl' was not declared. Should it be static? /scratch/dja/linux-capi/drivers/misc/cxl/file.c:399:30: warning: symbol 'afu_master_fops' was not declared. Should it be static? Make them static. Signed-off-by: Daniel Axtens Acked-by: Michael Neuling --- drivers/misc/cxl/file.c | 4 ++-- drivers/misc/cxl/irq.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/cxl/file.c b/drivers/misc/cxl/file.c index e3f4b69527a9..c8c8bfa2679b 100644 --- a/drivers/misc/cxl/file.c +++ b/drivers/misc/cxl/file.c @@ -251,7 +251,7 @@ long afu_ioctl(struct file *file, unsigned int cmd, unsigned long arg) return -EINVAL; } -long afu_compat_ioctl(struct file *file, unsigned int cmd, +static long afu_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) { return afu_ioctl(file, cmd, arg); @@ -396,7 +396,7 @@ const struct file_operations afu_fops = { .mmap = afu_mmap, }; -const struct file_operations afu_master_fops = { +static const struct file_operations afu_master_fops = { .owner = THIS_MODULE, .open = afu_master_open, .poll = afu_poll, diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c index 680cd263436d..77e5d0e7ebe1 100644 --- a/drivers/misc/cxl/irq.c +++ b/drivers/misc/cxl/irq.c @@ -405,7 +405,7 @@ void cxl_release_psl_irq(struct cxl_afu *afu) kfree(afu->psl_irq_name); } -void afu_irq_name_free(struct cxl_context *ctx) +static void afu_irq_name_free(struct cxl_context *ctx) { struct cxl_irq_name *irq_name, *tmp; @@ -464,7 +464,7 @@ out: return -ENOMEM; } -void afu_register_hwirqs(struct cxl_context *ctx) +static void afu_register_hwirqs(struct cxl_context *ctx) { irq_hw_number_t hwirq; struct cxl_irq_name *irq_name;