| Message ID | 1416586748-12936-5-git-send-email-guido@vanguardiasur.com.ar |
|---|---|
| State | Accepted |
| Headers | show |
Dear Guido Martínez, On Fri, 21 Nov 2014 13:19:03 -0300, Guido Martínez wrote: > Reset permissions for rsynced packages (when using OVERRIDE_SRCDIR) to > 755/644. We do this under the assumption that source files shouldn't > care about their permissions, except possibly for the exec bit. > > This guarantees that if a package uses 'rsync -a' or 'cp -p' to copy > a file from its build dir to the target, it'll end up with the same > permissions on the target every time. > > Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> > --- > package/pkg-generic.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thomas
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 9643a30..ec2989f 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -117,7 +117,7 @@ $(BUILD_DIR)/%/.stamp_rsynced: @$(call MESSAGE,"Syncing from source dir $(SRCDIR)") @test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1) $(foreach hook,$($(PKG)_PRE_RSYNC_HOOKS),$(call $(hook))$(sep)) - rsync -au $(RSYNC_VCS_EXCLUSIONS) $(SRCDIR)/ $(@D) + rsync -au --chmod=u=rwX,go=rX $(RSYNC_VCS_EXCLUSIONS) $(SRCDIR)/ $(@D) $(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep)) $(Q)touch $@
Reset permissions for rsynced packages (when using OVERRIDE_SRCDIR) to 755/644. We do this under the assumption that source files shouldn't care about their permissions, except possibly for the exec bit. This guarantees that if a package uses 'rsync -a' or 'cp -p' to copy a file from its build dir to the target, it'll end up with the same permissions on the target every time. Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> --- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)