Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.2/patches/811420/?format=api
{ "id": 811420, "url": "http://patchwork.ozlabs.org/api/1.2/patches/811420/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/patch/20170908093302.518-1-colin.king@canonical.com/", "project": { "id": 24, "url": "http://patchwork.ozlabs.org/api/1.2/projects/24/?format=api", "name": "Firmware Test Suite development", "link_name": "fwts", "list_id": "fwts-devel.lists.ubuntu.com", "list_email": "fwts-devel@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908093302.518-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-09-08T09:33:02", "name": "lib: fwts_checksum: object sizes should be size_t rather than int", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4a5c47e42dd0c8415092ee8ed6b812b005928237", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/1.2/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/fwts/patch/20170908093302.518-1-colin.king@canonical.com/mbox/", "series": [ { "id": 2154, "url": "http://patchwork.ozlabs.org/api/1.2/series/2154/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/list/?series=2154", "date": "2017-09-08T09:33:02", "name": "lib: fwts_checksum: object sizes should be size_t rather than int", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2154/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811420/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811420/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<fwts-devel-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)", "Received": [ "from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpXDc4pDpz9ryv;\n\tFri, 8 Sep 2017 19:33:04 +1000 (AEST)", "from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <fwts-devel-bounces@lists.ubuntu.com>)\n\tid 1dqFep-0003w5-B8; Fri, 08 Sep 2017 09:33:03 +0000", "from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <colin.king@canonical.com>)\n\tid 1dqFeo-0003vw-O9\n\tfor fwts-devel@lists.ubuntu.com; Fri, 08 Sep 2017 09:33:02 +0000", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1dqFeo-0002F8-E6; Fri, 08 Sep 2017 09:33:02 +0000" ], "From": "Colin King <colin.king@canonical.com>", "To": "fwts-devel@lists.ubuntu.com", "Subject": "[PATCH] lib: fwts_checksum: object sizes should be size_t rather\n\tthan int", "Date": "Fri, 8 Sep 2017 10:33:02 +0100", "Message-Id": "<20170908093302.518-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.14.1", "MIME-Version": "1.0", "X-BeenThere": "fwts-devel@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Firmware Test Suite Development <fwts-devel.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/fwts-devel>,\n\t<mailto:fwts-devel-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/fwts-devel>", "List-Post": "<mailto:fwts-devel@lists.ubuntu.com>", "List-Help": "<mailto:fwts-devel-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/fwts-devel>,\n\t<mailto:fwts-devel-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "fwts-devel-bounces@lists.ubuntu.com", "Sender": "\"fwts-devel\" <fwts-devel-bounces@lists.ubuntu.com>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nChecksum lengths should be on size_t sizes rather than ints.\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n src/lib/include/fwts_checksum.h | 2 +-\n src/lib/src/fwts_checksum.c | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/lib/include/fwts_checksum.h b/src/lib/include/fwts_checksum.h\nindex 6aa21359..f1a6626f 100644\n--- a/src/lib/include/fwts_checksum.h\n+++ b/src/lib/include/fwts_checksum.h\n@@ -22,6 +22,6 @@\n \n #include \"fwts.h\"\n \n-uint8_t fwts_checksum(const uint8_t *data, const int length);\n+uint8_t fwts_checksum(const uint8_t *data, const size_t length);\n \n #endif\ndiff --git a/src/lib/src/fwts_checksum.c b/src/lib/src/fwts_checksum.c\nindex 27ab8820..f7760a99 100644\n--- a/src/lib/src/fwts_checksum.c\n+++ b/src/lib/src/fwts_checksum.c\n@@ -23,9 +23,9 @@\n * fwts_checksum()\n *\tchecksum a uint8_t * buffer\n */\n-uint8_t fwts_checksum(const uint8_t *data, const int length)\n+uint8_t fwts_checksum(const uint8_t *data, const size_t length)\n {\n-\tint \ti;\n+\tsize_t i;\n \tuint8_t checksum = 0;\n \n \tfor (i = 0; i < length; i++)\n", "prefixes": [] }