From patchwork Fri Sep 8 09:33:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 811420 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 3xpXDc4pDpz9ryv; Fri, 8 Sep 2017 19:33:04 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1dqFep-0003w5-B8; Fri, 08 Sep 2017 09:33:03 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1dqFeo-0003vw-O9 for fwts-devel@lists.ubuntu.com; Fri, 08 Sep 2017 09:33:02 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1dqFeo-0002F8-E6; Fri, 08 Sep 2017 09:33:02 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_checksum: object sizes should be size_t rather than int Date: Fri, 8 Sep 2017 10:33:02 +0100 Message-Id: <20170908093302.518-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" From: Colin Ian King Checksum lengths should be on size_t sizes rather than ints. Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/lib/include/fwts_checksum.h | 2 +- src/lib/src/fwts_checksum.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/include/fwts_checksum.h b/src/lib/include/fwts_checksum.h index 6aa21359..f1a6626f 100644 --- a/src/lib/include/fwts_checksum.h +++ b/src/lib/include/fwts_checksum.h @@ -22,6 +22,6 @@ #include "fwts.h" -uint8_t fwts_checksum(const uint8_t *data, const int length); +uint8_t fwts_checksum(const uint8_t *data, const size_t length); #endif diff --git a/src/lib/src/fwts_checksum.c b/src/lib/src/fwts_checksum.c index 27ab8820..f7760a99 100644 --- a/src/lib/src/fwts_checksum.c +++ b/src/lib/src/fwts_checksum.c @@ -23,9 +23,9 @@ * fwts_checksum() * checksum a uint8_t * buffer */ -uint8_t fwts_checksum(const uint8_t *data, const int length) +uint8_t fwts_checksum(const uint8_t *data, const size_t length) { - int i; + size_t i; uint8_t checksum = 0; for (i = 0; i < length; i++)