[{"id":1766395,"web_url":"http://patchwork.ozlabs.org/comment/1766395/","msgid":"<23df4e95-d1e8-2179-5a57-eabd5b805765@canonical.com>","list_archive_url":null,"date":"2017-09-11T16:51:30","subject":"ACK: [PATCH] lib: fwts_checksum: object sizes should be size_t\n\trather than int","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-08 02:33 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> Checksum lengths should be on size_t sizes rather than ints.\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/lib/include/fwts_checksum.h | 2 +-\n> src/lib/src/fwts_checksum.c | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/lib/include/fwts_checksum.h b/src/lib/include/fwts_checksum.h\n> index 6aa21359..f1a6626f 100644\n> --- a/src/lib/include/fwts_checksum.h\n> +++ b/src/lib/include/fwts_checksum.h\n> @@ -22,6 +22,6 @@\n> \n> #include \"fwts.h\"\n> \n> -uint8_t fwts_checksum(const uint8_t *data, const int length);\n> +uint8_t fwts_checksum(const uint8_t *data, const size_t length);\n> \n> #endif\n> diff --git a/src/lib/src/fwts_checksum.c b/src/lib/src/fwts_checksum.c\n> index 27ab8820..f7760a99 100644\n> --- a/src/lib/src/fwts_checksum.c\n> +++ b/src/lib/src/fwts_checksum.c\n> @@ -23,9 +23,9 @@\n> * fwts_checksum()\n> *\tchecksum a uint8_t * buffer\n> */\n> -uint8_t fwts_checksum(const uint8_t *data, const int length)\n> +uint8_t fwts_checksum(const uint8_t *data, const size_t length)\n> {\n> -\tint \ti;\n> +\tsize_t i;\n> \tuint8_t checksum = 0;\n> \n> \tfor (i = 0; i < length; i++)\n> \n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrYqH1sdjz9s83;\n\tTue, 12 Sep 2017 02:51:39 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1drRvu-0005Lf-3U; Mon, 11 Sep 2017 16:51:38 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1drRvs-0005LS-Sd\n\tfor fwts-devel@lists.ubuntu.com; Mon, 11 Sep 2017 16:51:36 +0000","from mail-pg0-f71.google.com ([74.125.83.71])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1drRvs-0003Fm-HA\n\tfor fwts-devel@lists.ubuntu.com; Mon, 11 Sep 2017 16:51:36 +0000","by mail-pg0-f71.google.com with SMTP id t3so17459674pgt.7\n\tfor ;\n\tMon, 11 Sep 2017 09:51:36 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\tt125sm15484978pgc.50.2017.09.11.09.51.31\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 09:51:34 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=VS0tZJQlyCwWDeYVr6ilMO3uMTF1BAa7YPEijd/vhl0=;\n\tb=rXU+lTwAmQZtWKSld3kSqHINmcV6xObUcku94nGy8dDvHtS5D9oMki78eO1n7VVroV\n\thvcSrmHk2nQa5oSiQA8yxH3Ulq5zI7RZiXGKRfUlFOK8tBXgpfl4m5dPtQFj1MEqLE/q\n\tTe/Jk7X0dBgQ9Zt5MTYyTA9o9LGGbAtMFMsT5ZdIHqNe8RKCK/KP68yTdMjckwwPT+z1\n\tFEdPg15rRCQK9UA+J47nOCzs83F3F2SLGVVuY1bZV1qvFaR013dFAxyzUq/EJpcecvxI\n\t+r7+UOmYXnwaJIw/0YBcXRGKvBz4R3PLRvpF+mHxu3A+QG02Y9UdrDRmRTwjFlja4zG8\n\tT0Rw==","X-Gm-Message-State":"AHPjjUgKa7KNoHM6jWz6Rh2plmueYJwSE54WfO8R7YGJuwqTAteOnVur\n\tBZOdF3QUahlgvVEEWRjeeBqs1Uj5g8TMWGGkmirFr1+IDyT2mIkgsjqG5GWAT3HbzIrPE4/v5EX\n\tjl/9o1SF5/g+LKy0lzjem99OJrhjqgO8=","X-Received":["by 10.84.236.6 with SMTP id q6mr13778149plk.265.1505148695008;\n\tMon, 11 Sep 2017 09:51:35 -0700 (PDT)","by 10.84.236.6 with SMTP id q6mr13778146plk.265.1505148694835;\n\tMon, 11 Sep 2017 09:51:34 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7S183BtfA8X6tiuTvPYx3v7uEmlBx9XYay/hYltPPP+XlFCItS8FJx3X3469pp6nDO6SJHOw==","Subject":"ACK: [PATCH] lib: fwts_checksum: object sizes should be size_t\n\trather than int","To":"fwts-devel@lists.ubuntu.com","References":"<20170908093302.518-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"<23df4e95-d1e8-2179-5a57-eabd5b805765@canonical.com>","Date":"Mon, 11 Sep 2017 09:51:30 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170908093302.518-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1772599,"web_url":"http://patchwork.ozlabs.org/comment/1772599/","msgid":"","list_archive_url":null,"date":"2017-09-21T09:16:22","subject":"ACK: [PATCH] lib: fwts_checksum: object sizes should be size_t\n\trather than int","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/08/2017 05:33 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> Checksum lengths should be on size_t sizes rather than ints.\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/lib/include/fwts_checksum.h | 2 +-\n> src/lib/src/fwts_checksum.c | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/lib/include/fwts_checksum.h b/src/lib/include/fwts_checksum.h\n> index 6aa21359..f1a6626f 100644\n> --- a/src/lib/include/fwts_checksum.h\n> +++ b/src/lib/include/fwts_checksum.h\n> @@ -22,6 +22,6 @@\n> \n> #include \"fwts.h\"\n> \n> -uint8_t fwts_checksum(const uint8_t *data, const int length);\n> +uint8_t fwts_checksum(const uint8_t *data, const size_t length);\n> \n> #endif\n> diff --git a/src/lib/src/fwts_checksum.c b/src/lib/src/fwts_checksum.c\n> index 27ab8820..f7760a99 100644\n> --- a/src/lib/src/fwts_checksum.c\n> +++ b/src/lib/src/fwts_checksum.c\n> @@ -23,9 +23,9 @@\n> * fwts_checksum()\n> *\tchecksum a uint8_t * buffer\n> */\n> -uint8_t fwts_checksum(const uint8_t *data, const int length)\n> +uint8_t fwts_checksum(const uint8_t *data, const size_t length)\n> {\n> -\tint \ti;\n> +\tsize_t i;\n> \tuint8_t checksum = 0;\n> \n> \tfor (i = 0; i < length; i++)\n> \n\n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyWFS211Mz9t3w;\n\tThu, 21 Sep 2017 19:16:28 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1duxat-0001LX-3I; Thu, 21 Sep 2017 09:16:27 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1duxas-0001LN-4i\n\tfor fwts-devel@lists.ubuntu.com; Thu, 21 Sep 2017 09:16:26 +0000","from [175.181.226.10] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1duxar-0004MD-KS\n\tfor fwts-devel@lists.ubuntu.com; Thu, 21 Sep 2017 09:16:25 +0000"],"Subject":"ACK: [PATCH] lib: fwts_checksum: object sizes should be size_t\n\trather than int","To":"fwts-devel@lists.ubuntu.com","References":"<20170908093302.518-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"","Date":"Thu, 21 Sep 2017 17:16:22 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170908093302.518-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]