Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 810266,
    "url": "http://patchwork.ozlabs.org/api/1.2/patches/810266/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170905194958.3436-1-zahari.doychev@linux.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/1.2/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170905194958.3436-1-zahari.doychev@linux.com>",
    "list_archive_url": null,
    "date": "2017-09-05T19:49:58",
    "name": "[next,v2] rocker: fix kcalloc parameter order",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6cc61c8ee49c08f2204e93bc83232eabc4b04d6b",
    "submitter": {
        "id": 70274,
        "url": "http://patchwork.ozlabs.org/api/1.2/people/70274/?format=api",
        "name": "Zahari Doychev",
        "email": "zahari.doychev@linux.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/1.2/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170905194958.3436-1-zahari.doychev@linux.com/mbox/",
    "series": [
        {
            "id": 1639,
            "url": "http://patchwork.ozlabs.org/api/1.2/series/1639/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1639",
            "date": "2017-09-05T19:49:58",
            "name": "[next,v2] rocker: fix kcalloc parameter order",
            "version": 2,
            "mbox": "http://patchwork.ozlabs.org/series/1639/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/810266/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/810266/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"KDbc6Paa\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmy455rBwz9sNV\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  6 Sep 2017 05:50:13 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752490AbdIETuM (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 5 Sep 2017 15:50:12 -0400",
            "from mail-wm0-f67.google.com ([74.125.82.67]:33011 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752186AbdIETuK (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 5 Sep 2017 15:50:10 -0400",
            "by mail-wm0-f67.google.com with SMTP id 187so3753532wmn.0\n\tfor <netdev@vger.kernel.org>; Tue, 05 Sep 2017 12:50:09 -0700 (PDT)",
            "from revolt.blackmail ([2a02:810d:1500:e01:4216:7eff:feaa:ea6b])\n\tby smtp.gmail.com with ESMTPSA id\n\tm10sm566044eda.30.2017.09.05.12.50.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 12:50:07 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id;\n\tbh=smnMBrHwTxC8lfKqIwA4PPM0c1cfxkLWNMB5J+Rsvac=;\n\tb=KDbc6PaaPft3zizeehj9ozHOCU3WhXE3GhjXTfFvvquvSuqEnhcN6uVKF5R/vTWakw\n\t9UWmfa+Gm4PxPgjwLfu38lH3sMV5GSeGmkSW96yF/Q6yuk8BJxywPkoP4MvTh8iPH8Po\n\tisV1FdHZ440iMWm4CN8PN40sX25Mva57l58iOKwwQeg6S6K1PwVU8ghN7Ve6IsJDqJ/Y\n\t4uw76IdYTwTaagtWoF2/Oz25r/M9Hwn6OO6dtfWB86WuB9OsQpgQ9Otq8WUdXM46pBeB\n\t2zjcs5H+eFoNIVe+Pt7krcZTfkgSWCfYVk4hwPSu057WYGAHxNlYoMBpitipZaYt2Svd\n\tJRbw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id;\n\tbh=smnMBrHwTxC8lfKqIwA4PPM0c1cfxkLWNMB5J+Rsvac=;\n\tb=KuStrEcHZ2C5t19WKsMSl+RCeM+LLhCNW24BNVOI4WgX7JdXxhOyhBpj56oh9UGEs4\n\tAMS4BALwrsB/3C0+x6xWRwrrOfPpcx1CLrniPH5LsR4SSNH2TgEpr+bPjAQck3yOdIco\n\t2k3YYfLmHayUtcOZN3abaKR2Ex5dqRlozz34UWIeFMmKFpbnRkP4MyHGxcweLqpk+D1E\n\t3Cu2Y4VkbvLYksDQNNzQ6XXnJSC79jVGAZTo9LQjEeH2G2BZYw5nZDXMNx8zyg4twfTo\n\tW6RoYwlepZc6IxTOh7AiuPSotlVe2ove9rKUe2tALgDuYCzwL6bNhMppCd3+6OqXIhcU\n\t1FfQ==",
        "X-Gm-Message-State": "AHPjjUjYKyO28PrE/EkG7fJ4MfACC25Tt+isaqdmPIDPMmPYTZispgFE\n\tNIMzVBRquqRzn9nL",
        "X-Google-Smtp-Source": "ADKCNb5icXFZiJEt8YU+XcabJrrrfIKmIkul7WUXgbXTUZKAyPS2lKTbA7XmvZDmngtsYHhB5syMiQ==",
        "X-Received": "by 10.80.134.141 with SMTP id r13mr4118881eda.152.1504641008928; \n\tTue, 05 Sep 2017 12:50:08 -0700 (PDT)",
        "From": "Zahari Doychev <zahari.doychev@linux.com>",
        "To": "jiri@resnulli.us, netdev@vger.kernel.org",
        "Cc": "Zahari Doychev <zahari.doychev@linux.com>",
        "Subject": "[PATCH][next v2] rocker: fix kcalloc parameter order",
        "Date": "Tue,  5 Sep 2017 21:49:58 +0200",
        "Message-Id": "<20170905194958.3436-1-zahari.doychev@linux.com>",
        "X-Mailer": "git-send-email 2.13.0",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "The function calls to kcalloc use wrong parameter order and incorrect flags\nvalues. GFP_KERNEL is used instead of flags now and the order is corrected.\n\nThe change was done using the following coccinelle script:\n\n@@\nexpression E1,E2;\ntype T;\n@@\n\n-kcalloc(E1, E2, sizeof(T))\n+kcalloc(E2, sizeof(T), GFP_KERNEL)\n\nSigned-off-by: Zahari Doychev <zahari.doychev@linux.com>\n---\n drivers/net/ethernet/rocker/rocker_ofdpa.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c\nindex da4e26b53a52..0653b70723a3 100644\n--- a/drivers/net/ethernet/rocker/rocker_ofdpa.c\n+++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c\n@@ -1177,7 +1177,7 @@ static int ofdpa_group_l2_fan_out(struct ofdpa_port *ofdpa_port,\n \tentry->group_id = group_id;\n \tentry->group_count = group_count;\n \n-\tentry->group_ids = kcalloc(flags, group_count, sizeof(u32));\n+\tentry->group_ids = kcalloc(group_count, sizeof(u32), GFP_KERNEL);\n \tif (!entry->group_ids) {\n \t\tkfree(entry);\n \t\treturn -ENOMEM;\n@@ -1456,7 +1456,7 @@ static int ofdpa_port_vlan_flood_group(struct ofdpa_port *ofdpa_port,\n \tint err = 0;\n \tint i;\n \n-\tgroup_ids = kcalloc(flags, port_count, sizeof(u32));\n+\tgroup_ids = kcalloc(port_count, sizeof(u32), GFP_KERNEL);\n \tif (!group_ids)\n \t\treturn -ENOMEM;\n \n",
    "prefixes": [
        "next",
        "v2"
    ]
}