From patchwork Tue Sep 5 19:49:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zahari Doychev X-Patchwork-Id: 810266 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b="KDbc6Paa"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xmy455rBwz9sNV for ; Wed, 6 Sep 2017 05:50:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbdIETuM (ORCPT ); Tue, 5 Sep 2017 15:50:12 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33011 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbdIETuK (ORCPT ); Tue, 5 Sep 2017 15:50:10 -0400 Received: by mail-wm0-f67.google.com with SMTP id 187so3753532wmn.0 for ; Tue, 05 Sep 2017 12:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=smnMBrHwTxC8lfKqIwA4PPM0c1cfxkLWNMB5J+Rsvac=; b=KDbc6PaaPft3zizeehj9ozHOCU3WhXE3GhjXTfFvvquvSuqEnhcN6uVKF5R/vTWakw 9UWmfa+Gm4PxPgjwLfu38lH3sMV5GSeGmkSW96yF/Q6yuk8BJxywPkoP4MvTh8iPH8Po isV1FdHZ440iMWm4CN8PN40sX25Mva57l58iOKwwQeg6S6K1PwVU8ghN7Ve6IsJDqJ/Y 4uw76IdYTwTaagtWoF2/Oz25r/M9Hwn6OO6dtfWB86WuB9OsQpgQ9Otq8WUdXM46pBeB 2zjcs5H+eFoNIVe+Pt7krcZTfkgSWCfYVk4hwPSu057WYGAHxNlYoMBpitipZaYt2Svd JRbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=smnMBrHwTxC8lfKqIwA4PPM0c1cfxkLWNMB5J+Rsvac=; b=KuStrEcHZ2C5t19WKsMSl+RCeM+LLhCNW24BNVOI4WgX7JdXxhOyhBpj56oh9UGEs4 AMS4BALwrsB/3C0+x6xWRwrrOfPpcx1CLrniPH5LsR4SSNH2TgEpr+bPjAQck3yOdIco 2k3YYfLmHayUtcOZN3abaKR2Ex5dqRlozz34UWIeFMmKFpbnRkP4MyHGxcweLqpk+D1E 3Cu2Y4VkbvLYksDQNNzQ6XXnJSC79jVGAZTo9LQjEeH2G2BZYw5nZDXMNx8zyg4twfTo W6RoYwlepZc6IxTOh7AiuPSotlVe2ove9rKUe2tALgDuYCzwL6bNhMppCd3+6OqXIhcU 1FfQ== X-Gm-Message-State: AHPjjUjYKyO28PrE/EkG7fJ4MfACC25Tt+isaqdmPIDPMmPYTZispgFE NIMzVBRquqRzn9nL X-Google-Smtp-Source: ADKCNb5icXFZiJEt8YU+XcabJrrrfIKmIkul7WUXgbXTUZKAyPS2lKTbA7XmvZDmngtsYHhB5syMiQ== X-Received: by 10.80.134.141 with SMTP id r13mr4118881eda.152.1504641008928; Tue, 05 Sep 2017 12:50:08 -0700 (PDT) Received: from revolt.blackmail ([2a02:810d:1500:e01:4216:7eff:feaa:ea6b]) by smtp.gmail.com with ESMTPSA id m10sm566044eda.30.2017.09.05.12.50.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Sep 2017 12:50:07 -0700 (PDT) From: Zahari Doychev To: jiri@resnulli.us, netdev@vger.kernel.org Cc: Zahari Doychev Subject: [PATCH][next v2] rocker: fix kcalloc parameter order Date: Tue, 5 Sep 2017 21:49:58 +0200 Message-Id: <20170905194958.3436-1-zahari.doychev@linux.com> X-Mailer: git-send-email 2.13.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The function calls to kcalloc use wrong parameter order and incorrect flags values. GFP_KERNEL is used instead of flags now and the order is corrected. The change was done using the following coccinelle script: @@ expression E1,E2; type T; @@ -kcalloc(E1, E2, sizeof(T)) +kcalloc(E2, sizeof(T), GFP_KERNEL) Signed-off-by: Zahari Doychev --- drivers/net/ethernet/rocker/rocker_ofdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c index da4e26b53a52..0653b70723a3 100644 --- a/drivers/net/ethernet/rocker/rocker_ofdpa.c +++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c @@ -1177,7 +1177,7 @@ static int ofdpa_group_l2_fan_out(struct ofdpa_port *ofdpa_port, entry->group_id = group_id; entry->group_count = group_count; - entry->group_ids = kcalloc(flags, group_count, sizeof(u32)); + entry->group_ids = kcalloc(group_count, sizeof(u32), GFP_KERNEL); if (!entry->group_ids) { kfree(entry); return -ENOMEM; @@ -1456,7 +1456,7 @@ static int ofdpa_port_vlan_flood_group(struct ofdpa_port *ofdpa_port, int err = 0; int i; - group_ids = kcalloc(flags, port_count, sizeof(u32)); + group_ids = kcalloc(port_count, sizeof(u32), GFP_KERNEL); if (!group_ids) return -ENOMEM;