[{"id":1763688,"web_url":"http://patchwork.ozlabs.org/comment/1763688/","msgid":"<20170905.145740.1996370074892542800.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-05T21:57:40","subject":"Re: [PATCH][next v2] rocker: fix kcalloc parameter order","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Zahari Doychev \nDate: Tue, 5 Sep 2017 21:49:58 +0200\n\n> The function calls to kcalloc use wrong parameter order and incorrect flags\n> values. GFP_KERNEL is used instead of flags now and the order is corrected.\n> \n> The change was done using the following coccinelle script:\n> \n> @@\n> expression E1,E2;\n> type T;\n> @@\n> \n> -kcalloc(E1, E2, sizeof(T))\n> +kcalloc(E2, sizeof(T), GFP_KERNEL)\n> \n> Signed-off-by: Zahari Doychev \n\nApplied, thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn0vD75BJz9s7h\n\tfor ;\n\tWed, 6 Sep 2017 07:57:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753550AbdIEV5m (ORCPT );\n\tTue, 5 Sep 2017 17:57:42 -0400","from shards.monkeyblade.net ([184.105.139.130]:40060 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752819AbdIEV5l (ORCPT\n\t); Tue, 5 Sep 2017 17:57:41 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 3BBA313DBD548;\n\tTue, 5 Sep 2017 14:57:41 -0700 (PDT)"],"Date":"Tue, 05 Sep 2017 14:57:40 -0700 (PDT)","Message-Id":"<20170905.145740.1996370074892542800.davem@davemloft.net>","To":"zahari.doychev@linux.com","Cc":"jiri@resnulli.us, netdev@vger.kernel.org","Subject":"Re: [PATCH][next v2] rocker: fix kcalloc parameter order","From":"David Miller ","In-Reply-To":"<20170905194958.3436-1-zahari.doychev@linux.com>","References":"<20170905194958.3436-1-zahari.doychev@linux.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 05 Sep 2017 14:57:41 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]