[U-Boot,01/13] mailbox: check ops prior calling

Message ID	300f8ca074d22481ec299ddfa29c23887148633e.1569591296.git.michal.simek@xilinx.com
State	Deferred
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Michal Simek <michal.simek@xilinx.com> To: u-boot@lists.denx.de, git@xilinx.com Date: Fri, 27 Sep 2019 15:34:52 +0200 Message-Id: <300f8ca074d22481ec299ddfa29c23887148633e.1569591296.git.michal.simek@xilinx.com> In-Reply-To: <cover.1569591296.git.michal.simek@xilinx.com> References: <cover.1569591296.git.michal.simek@xilinx.com> In-Reply-To: <cover.1569591296.git.michal.simek@xilinx.com> References: <cover.1569591296.git.michal.simek@xilinx.com> Cc: ibai.erkiaga-elorza@xilinx.com, luca@lucaceresoli.net Subject: [U-Boot] [PATCH 01/13] mailbox: check ops prior calling Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	arm64: zynqmp: Clean communication with PMUFW \| expand [U-Boot,00/13] arm64: zynqmp: Clean communication with PMUFW [U-Boot,01/13] mailbox: check ops prior calling [U-Boot,02/13] mailbox: allow subnode for mbox regs [U-Boot,03/13] mailbox: zynqmp: ipi mailbox driver [U-Boot,04/13] firmware: zynqmp: Add zynqmp-power support [U-Boot,05/13] arm64: zynqmp: add firmware and mailbox node to DT [U-Boot,06/13] arm64: zynqmp: Cleanup PM SMC macro composition [U-Boot,07/13] firmware: zynqmp: get fw version with mailbox driver [U-Boot,08/13] firmware: zynqmp: create firmware header [U-Boot,09/13] arm64: zynqmp: use firmware driver to get version [U-Boot,10/13] arm64: zynqmp: remove old fw version function [U-Boot,11/13] arm64: zynqmp: probe firmware driver [U-Boot,12/13] firmware: zynqmp: Separate function for sending message via mailbox [U-Boot,13/13] arm64: zynqmp: Use mailbox driver for PMUFW config loading

Message ID

300f8ca074d22481ec299ddfa29c23887148633e.1569591296.git.michal.simek@xilinx.com

State

Deferred

Headers

From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de,
	git@xilinx.com
Date: Fri, 27 Sep 2019 15:34:52 +0200
Message-Id: <300f8ca074d22481ec299ddfa29c23887148633e.1569591296.git.michal.simek@xilinx.com>
In-Reply-To: <cover.1569591296.git.michal.simek@xilinx.com>
References: <cover.1569591296.git.michal.simek@xilinx.com>
In-Reply-To: <cover.1569591296.git.michal.simek@xilinx.com>
References: <cover.1569591296.git.michal.simek@xilinx.com>
Cc: ibai.erkiaga-elorza@xilinx.com, luca@lucaceresoli.net
Subject: [U-Boot] [PATCH 01/13] mailbox: check ops prior calling
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

arm64: zynqmp: Clean communication with PMUFW | expand

Commit Message

Michal Simek Sept. 27, 2019, 1:34 p.m. UTC

From: Ibai Erkiaga <ibai.erkiaga-elorza@xilinx.com>

Check if request and free operations are present prior calling to the
functions.

Signed-off-by: Ibai Erkiaga <ibai.erkiaga-elorza@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/mailbox/mailbox-uclass.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/mailbox-uclass.c b/drivers/mailbox/mailbox-uclass.c
index 1b4a5863c9e5..809f26b20258 100644
--- a/drivers/mailbox/mailbox-uclass.c
+++ b/drivers/mailbox/mailbox-uclass.c
@@ -63,7 +63,8 @@  int mbox_get_by_index(struct udevice *dev, int index, struct mbox_chan *chan)
 		return ret;
 	}
 
-	ret = ops->request(chan);
+	if (ops->request)
+		ret = ops->request(chan);
 	if (ret) {
 		debug("ops->request() failed: %d\n", ret);
 		return ret;
@@ -94,7 +95,10 @@  int mbox_free(struct mbox_chan *chan)
 
 	debug("%s(chan=%p)\n", __func__, chan);
 
-	return ops->free(chan);
+	if (ops->free)
+		return ops->free(chan);
+
+	return 0;
 }
 
 int mbox_send(struct mbox_chan *chan, const void *data)

[U-Boot,01/13] mailbox: check ops prior calling

Commit Message

Patch