mbox series

[U-Boot,00/13] arm64: zynqmp: Clean communication with PMUFW

Message ID cover.1569591296.git.michal.simek@xilinx.com
Headers show
Series arm64: zynqmp: Clean communication with PMUFW | expand

Message

Michal Simek Sept. 27, 2019, 1:34 p.m. UTC 
Hi,

This patch series using ZynqMP firmware driver to provide a interface to
communicate with the PMU Firmware. As part of the series a mailbox driver
is also implemented to handle communication through ipi interface.

There are two new wiring:
1. Reading PMUFW version via firmware driver
 - mailbox driver in case of SPL
 - SMC in case of full U-Boot
2. Using the same patch for loading PMUFW configuration object

The whole series is based on several patches I have sent already that's why
I am providing a branch which also contains this series.
https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze/tree/next

Thanks,
Michal


Ibai Erkiaga (10):
  mailbox: check ops prior calling
  mailbox: allow subnode for mbox regs
  mailbox: zynqmp: ipi mailbox driver
  firmware: zynqmp: Add zynqmp-power support
  arm64: zynqmp: add firmware and mailbox node to DT
  firmware: zynqmp: get fw version with mailbox driver
  firmware: zynqmp: create firmware header
  arm64: zynqmp: use firmware driver to get version
  arm64: zynqmp: remove old fw version function
  arm64: zynqmp: probe firmware driver

Michal Simek (3):
  arm64: zynqmp: Cleanup PM SMC macro composition
  firmware: zynqmp: Separate function for sending message via mailbox
  arm64: zynqmp: Use mailbox driver for PMUFW config loading

 MAINTAINERS                                   |   2 +
 arch/arm/Kconfig                              |   3 +
 arch/arm/dts/zynqmp.dtsi                      |  44 +++++-
 arch/arm/mach-zynqmp/Makefile                 |   4 -
 arch/arm/mach-zynqmp/cpu.c                    |  24 +---
 arch/arm/mach-zynqmp/include/mach/sys_proto.h |  24 +---
 arch/arm/mach-zynqmp/pmu_ipc.c                | 112 ---------------
 board/xilinx/zynqmp/cmds.c                    |   1 +
 board/xilinx/zynqmp/zynqmp.c                  |  19 +--
 drivers/firmware/Kconfig                      |   2 +
 drivers/firmware/firmware-zynqmp.c            | 131 +++++++++++++++++
 drivers/fpga/zynqmppl.c                       |   5 +-
 drivers/mailbox/Kconfig                       |   6 +
 drivers/mailbox/Makefile                      |   1 +
 drivers/mailbox/mailbox-uclass.c              |  19 ++-
 drivers/mailbox/zynqmp-ipi.c                  | 134 ++++++++++++++++++
 include/zynqmp_firmware.h                     |  37 +++++
 17 files changed, 388 insertions(+), 180 deletions(-)
 delete mode 100644 arch/arm/mach-zynqmp/pmu_ipc.c
 create mode 100644 drivers/mailbox/zynqmp-ipi.c
 create mode 100644 include/zynqmp_firmware.h

Comments

Luca Ceresoli Oct. 2, 2019, 9:33 a.m. UTC | #1 
Hi Michal, Ibai,

On 27/09/19 15:34, Michal Simek wrote:
> Hi,
> 
> This patch series using ZynqMP firmware driver to provide a interface to
> communicate with the PMU Firmware. As part of the series a mailbox driver
> is also implemented to handle communication through ipi interface.
> 
> There are two new wiring:
> 1. Reading PMUFW version via firmware driver
>  - mailbox driver in case of SPL
>  - SMC in case of full U-Boot
> 2. Using the same patch for loading PMUFW configuration object
> 
> The whole series is based on several patches I have sent already that's why
> I am providing a branch which also contains this series.
> https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze/tree/next
> 
> Thanks,
> Michal

Good to see this work going on, thanks!

I can't review in detail most of the patches, but I'm still replying
with some (mostly minor) comments.