diff mbox series

[2/3] serial: msm_serial: remove .clk_rate from debug UART

Message ID 20240415105028.432404-2-robert.marko@sartura.hr
State Accepted
Delegated to: Caleb Connolly
Headers show
Series [1/3] serial: allow selecting MSM debug UART with ARCH_IPQ40XX | expand

Commit Message

Robert Marko April 15, 2024, 10:49 a.m. UTC
MSM serial in DEBUG UART mode is trying to set .clk_rate, but the
msm_serial_data structure does not have such property at all, so lets
remove it as otherwise it will fail compiling.

Fixes: 90023bdfe979 ("serial: msm: add debug UART")
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 drivers/serial/serial_msm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Caleb Connolly April 15, 2024, 11:22 a.m. UTC | #1
On 15/04/2024 11:49, Robert Marko wrote:
> MSM serial in DEBUG UART mode is trying to set .clk_rate, but the
> msm_serial_data structure does not have such property at all, so lets
> remove it as otherwise it will fail compiling.

Well that's embarrasing... Thanks :D
> 
> Fixes: 90023bdfe979 ("serial: msm: add debug UART")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>  drivers/serial/serial_msm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c
> index ac4280c6c4..8044d38518 100644
> --- a/drivers/serial/serial_msm.c
> +++ b/drivers/serial/serial_msm.c
> @@ -242,7 +242,6 @@ U_BOOT_DRIVER(serial_msm) = {
>  
>  static struct msm_serial_data init_serial_data = {
>  	.base = CONFIG_VAL(DEBUG_UART_BASE),
> -	.clk_rate = 7372800,
>  };
>  
>  #include <debug_uart.h>
diff mbox series

Patch

diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c
index ac4280c6c4..8044d38518 100644
--- a/drivers/serial/serial_msm.c
+++ b/drivers/serial/serial_msm.c
@@ -242,7 +242,6 @@  U_BOOT_DRIVER(serial_msm) = {
 
 static struct msm_serial_data init_serial_data = {
 	.base = CONFIG_VAL(DEBUG_UART_BASE),
-	.clk_rate = 7372800,
 };
 
 #include <debug_uart.h>