| Message ID | 20240415105028.432404-1-robert.marko@sartura.hr |
|---|---|
| State | Accepted |
| Delegated to: | Caleb Connolly |
| Headers | show |
| Series | [1/3] serial: allow selecting MSM debug UART with ARCH_IPQ40XX | expand |
Hi Robert, Happy to see someone working on those IPQ platforms. If it makes sense to then I'd be happy to adopt them under ARCH_SNAPDRAGON at some point? I'm not hugely familiar with the usecase here (but eager to learn more!). On 15/04/2024 11:49, Robert Marko wrote: > Currently, DEBUG_UART_MSM depends on ARCH_SNAPDRAGON only, but IPQ40XX > devices also use the same UART HW so they can also use the debug UART. > > So, allow selecting DEBUG_UART_MSM when using ARCH_IPQ40XX as well. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > drivers/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig > index 8b19e2684e..1fe4607598 100644 > --- a/drivers/serial/Kconfig > +++ b/drivers/serial/Kconfig > @@ -321,7 +321,7 @@ config DEBUG_UART_S5P > > config DEBUG_UART_MSM > bool "Qualcomm QUP UART debug" > - depends on ARCH_SNAPDRAGON > + depends on ARCH_SNAPDRAGON || ARCH_IPQ40XX > help > Select this to enable a debug UART using the serial_msm driver. You > will need to provide parameters to make this work. The driver will
On Mon, Apr 15, 2024 at 1:21 PM Caleb Connolly <caleb.connolly@linaro.org> wrote: > > Hi Robert, > > Happy to see someone working on those IPQ platforms. If it makes sense > to then I'd be happy to adopt them under ARCH_SNAPDRAGON at some point? > I'm not hugely familiar with the usecase here (but eager to learn more!). Well, IPQ40xx is quite a popular WiSoC family and its cheap but the stock bootloader limits any kind of custom use case, so here we are. Regards, Robert > > On 15/04/2024 11:49, Robert Marko wrote: > > Currently, DEBUG_UART_MSM depends on ARCH_SNAPDRAGON only, but IPQ40XX > > devices also use the same UART HW so they can also use the debug UART. > > > > So, allow selecting DEBUG_UART_MSM when using ARCH_IPQ40XX as well. > > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> > > --- > > drivers/serial/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig > > index 8b19e2684e..1fe4607598 100644 > > --- a/drivers/serial/Kconfig > > +++ b/drivers/serial/Kconfig > > @@ -321,7 +321,7 @@ config DEBUG_UART_S5P > > > > config DEBUG_UART_MSM > > bool "Qualcomm QUP UART debug" > > - depends on ARCH_SNAPDRAGON > > + depends on ARCH_SNAPDRAGON || ARCH_IPQ40XX > > help > > Select this to enable a debug UART using the serial_msm driver. You > > will need to provide parameters to make this work. The driver will > > -- > // Caleb (they/them)
On Mon, 15 Apr 2024 12:49:25 +0200, Robert Marko wrote: > Currently, DEBUG_UART_MSM depends on ARCH_SNAPDRAGON only, but IPQ40XX > devices also use the same UART HW so they can also use the debug UART. > > So, allow selecting DEBUG_UART_MSM when using ARCH_IPQ40XX as well. > > Applied, thanks! [1/3] serial: allow selecting MSM debug UART with ARCH_IPQ40XX commit: aa7fdad4c87d5c665e0f1b74cf7986768d452a4e [2/3] serial: msm_serial: remove .clk_rate from debug UART commit: aaba69b461ff7c3118272964d3a807a030277e28 Best regards,
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 8b19e2684e..1fe4607598 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -321,7 +321,7 @@ config DEBUG_UART_S5P config DEBUG_UART_MSM bool "Qualcomm QUP UART debug" - depends on ARCH_SNAPDRAGON + depends on ARCH_SNAPDRAGON || ARCH_IPQ40XX help Select this to enable a debug UART using the serial_msm driver. You will need to provide parameters to make this work. The driver will
Currently, DEBUG_UART_MSM depends on ARCH_SNAPDRAGON only, but IPQ40XX devices also use the same UART HW so they can also use the debug UART. So, allow selecting DEBUG_UART_MSM when using ARCH_IPQ40XX as well. Signed-off-by: Robert Marko <robert.marko@sartura.hr> --- drivers/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)