diff mbox series

[v2,3/3] board: helios-4: add config fragment for spi booting

Message ID 20240202-helios4-spi-v2-3-df085461d894@solid-run.com
State Accepted
Commit e58704070621eda667557c6cb4690c46b18ae012
Delegated to: Stefan Roese
Headers show
Series arm: mvebu: helios-4: add config fragment for spi booting et al | expand

Commit Message

Josua Mayer Feb. 2, 2024, 3:13 p.m. UTC
Add a config fragment with required differences for booting from spi
flash instead of sd-card (default).

Settings for environment location are based on vendor u-boot:
https://github.com/kobol-io/u-boot/blob/helios4/include/configs/helios4.h#L59

The fragment can be applied on top of helios4_defconfig by make:
make helios4_defconfig spiboot.config

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 board/kobol/helios4/spiboot.config | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Tom Rini Feb. 2, 2024, 4:06 p.m. UTC | #1
On Fri, Feb 02, 2024 at 04:13:34PM +0100, Josua Mayer wrote:

> Add a config fragment with required differences for booting from spi
> flash instead of sd-card (default).
> 
> Settings for environment location are based on vendor u-boot:
> https://github.com/kobol-io/u-boot/blob/helios4/include/configs/helios4.h#L59
> 
> The fragment can be applied on top of helios4_defconfig by make:
> make helios4_defconfig spiboot.config
> 
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  board/kobol/helios4/spiboot.config | 4 ++++

Can you please follow-up by adding doc/board/kobol/ content (and adding
to the index and making sure make htmldocs is happy) ? Thanks!
Stefan Roese March 5, 2024, 10:32 a.m. UTC | #2
On 2/2/24 16:13, Josua Mayer wrote:
> Add a config fragment with required differences for booting from spi
> flash instead of sd-card (default).
> 
> Settings for environment location are based on vendor u-boot:
> https://github.com/kobol-io/u-boot/blob/helios4/include/configs/helios4.h#L59
> 
> The fragment can be applied on top of helios4_defconfig by make:
> make helios4_defconfig spiboot.config
> 
> Signed-off-by: Josua Mayer <josua@solid-run.com>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
>   board/kobol/helios4/spiboot.config | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/board/kobol/helios4/spiboot.config b/board/kobol/helios4/spiboot.config
> new file mode 100644
> index 0000000000..5ffb7d2e3b
> --- /dev/null
> +++ b/board/kobol/helios4/spiboot.config
> @@ -0,0 +1,4 @@
> +CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI=y
> +# CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC is not set
> +CONFIG_ENV_OFFSET=0x100000
> +CONFIG_ENV_SECT_SIZE=0x10000
> 

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/board/kobol/helios4/spiboot.config b/board/kobol/helios4/spiboot.config
new file mode 100644
index 0000000000..5ffb7d2e3b
--- /dev/null
+++ b/board/kobol/helios4/spiboot.config
@@ -0,0 +1,4 @@ 
+CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI=y
+# CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC is not set
+CONFIG_ENV_OFFSET=0x100000
+CONFIG_ENV_SECT_SIZE=0x10000