diff mbox series

[v2,2/3] arm: mvebu: helios4_defconfig: enable setexpr command

Message ID 20240202-helios4-spi-v2-2-df085461d894@solid-run.com
State Accepted
Commit 18c73e30e1aa412a47ab460eb2ccb8fb9551e8ad
Delegated to: Stefan Roese
Headers show
Series arm: mvebu: helios-4: add config fragment for spi booting et al | expand

Commit Message

Josua Mayer Feb. 2, 2024, 3:13 p.m. UTC
Update the helios4 defconfig to enable the 'setexpr' command, which is a
default and useful for various complex boot-scripts.

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 configs/helios4_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Dennis Gilmore Feb. 12, 2024, 8:40 p.m. UTC | #1
I am curious about your use cases for this. as ideally all systems use the
generic distro boot paths and it is not needed for them.

Dennis

On Fri, Feb 2, 2024 at 9:13 AM Josua Mayer <josua@solid-run.com> wrote:

> Update the helios4 defconfig to enable the 'setexpr' command, which is a
> default and useful for various complex boot-scripts.
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  configs/helios4_defconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/configs/helios4_defconfig b/configs/helios4_defconfig
> index 04194004f0..73f0638344 100644
> --- a/configs/helios4_defconfig
> +++ b/configs/helios4_defconfig
> @@ -44,7 +44,6 @@ CONFIG_CMD_MMC=y
>  CONFIG_CMD_PCI=y
>  CONFIG_CMD_SPI=y
>  CONFIG_CMD_USB=y
> -# CONFIG_CMD_SETEXPR is not set
>  CONFIG_CMD_TFTPPUT=y
>  CONFIG_CMD_CACHE=y
>  CONFIG_CMD_TIME=y
>
> --
> 2.35.3
>
>
Josua Mayer Feb. 13, 2024, 1:07 p.m. UTC | #2
Hi Dennis,

Use-case is with separate boot and rootfs partitions to calculate
next partition number as argument for further commands:

setexpr openwrt_rootpart ${distro_bootpart} + 1
part uuid ${devtype} ${devnum}:${openwrt_rootpart} uuid
setenv bootargs ${bootargs} root=PARTUUID=${uuid} rootfstype=auto rootwait

- Josua Mayer

Am 12.02.24 um 21:40 schrieb Dennis Gilmore:
> I am curious about your use cases for this. as ideally all systems use the generic distro boot paths and it is not needed for them.
>
> Dennis
>
> On Fri, Feb 2, 2024 at 9:13 AM Josua Mayer <josua@solid-run.com> wrote:
>
>     Update the helios4 defconfig to enable the 'setexpr' command, which is a
>     default and useful for various complex boot-scripts.
>
>     Signed-off-by: Josua Mayer <josua@solid-run.com>
>     ---
>      configs/helios4_defconfig | 1 -
>      1 file changed, 1 deletion(-)
>
>     diff --git a/configs/helios4_defconfig b/configs/helios4_defconfig
>     index 04194004f0..73f0638344 100644
>     --- a/configs/helios4_defconfig
>     +++ b/configs/helios4_defconfig
>     @@ -44,7 +44,6 @@ CONFIG_CMD_MMC=y
>      CONFIG_CMD_PCI=y
>      CONFIG_CMD_SPI=y
>      CONFIG_CMD_USB=y
>     -# CONFIG_CMD_SETEXPR is not set
>      CONFIG_CMD_TFTPPUT=y
>      CONFIG_CMD_CACHE=y
>      CONFIG_CMD_TIME=y
>
>     -- 
>     2.35.3
>
>
>
> -- 
> Dennis Gilmore
> Senior Manager Systems Enablement OpenShift Development
Stefan Roese March 5, 2024, 10:32 a.m. UTC | #3
On 2/2/24 16:13, Josua Mayer wrote:
> Update the helios4 defconfig to enable the 'setexpr' command, which is a
> default and useful for various complex boot-scripts.
> 
> Signed-off-by: Josua Mayer <josua@solid-run.com>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
>   configs/helios4_defconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/configs/helios4_defconfig b/configs/helios4_defconfig
> index 04194004f0..73f0638344 100644
> --- a/configs/helios4_defconfig
> +++ b/configs/helios4_defconfig
> @@ -44,7 +44,6 @@ CONFIG_CMD_MMC=y
>   CONFIG_CMD_PCI=y
>   CONFIG_CMD_SPI=y
>   CONFIG_CMD_USB=y
> -# CONFIG_CMD_SETEXPR is not set
>   CONFIG_CMD_TFTPPUT=y
>   CONFIG_CMD_CACHE=y
>   CONFIG_CMD_TIME=y
> 

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/configs/helios4_defconfig b/configs/helios4_defconfig
index 04194004f0..73f0638344 100644
--- a/configs/helios4_defconfig
+++ b/configs/helios4_defconfig
@@ -44,7 +44,6 @@  CONFIG_CMD_MMC=y
 CONFIG_CMD_PCI=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_USB=y
-# CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TFTPPUT=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y