diff mbox series

[v1,3/9] stm32mp: dram_init: Fix AARCH64 compilation warnings

Message ID 20231027144304.1002307-4-patrice.chotard@foss.st.com
State Accepted
Commit ee15c72da261b2d4b27ffcdccc2af8b2797c37fc
Delegated to: Patrick Delaunay
Headers show
Series Add STM32MP2 SoCs and STM32MP257F-EV board support | expand

Commit Message

Patrice CHOTARD Oct. 27, 2023, 2:42 p.m. UTC
From: Patrick Delaunay <patrick.delaunay@foss.st.com>

When building with AARCH64 defconfig, we got warnings for debug
message
- format '%x' expects argument of type 'unsigned int',
   but argument 3 has type 'size_t' {aka 'long unsigned int'}).
- format '%lx' expects argument of type 'long unsigned int',
  but argument 2 has type 'phys_addr_t' {aka 'long long unsigned
  int'}

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---

 arch/arm/mach-stm32mp/dram_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Patrick Delaunay Nov. 9, 2023, 9:13 a.m. UTC | #1
Hi,


On 10/27/23 16:42, Patrice Chotard wrote:
> From: Patrick Delaunay <patrick.delaunay@foss.st.com>
>
> When building with AARCH64 defconfig, we got warnings for debug
> message
> - format '%x' expects argument of type 'unsigned int',
>     but argument 3 has type 'size_t' {aka 'long unsigned int'}).
> - format '%lx' expects argument of type 'long unsigned int',
>    but argument 2 has type 'phys_addr_t' {aka 'long long unsigned
>    int'}
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>
>   arch/arm/mach-stm32mp/dram_init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-stm32mp/dram_init.c b/arch/arm/mach-stm32mp/dram_init.c
> index a1e77a42e4f..cb35ed60ca1 100644
> --- a/arch/arm/mach-stm32mp/dram_init.c
> +++ b/arch/arm/mach-stm32mp/dram_init.c
> @@ -36,7 +36,7 @@ int dram_init(void)
>   		log_debug("Cannot get RAM size: %d\n", ret);
>   		return ret;
>   	}
> -	log_debug("RAM init base=%lx, size=%x\n", ram.base, ram.size);
> +	log_debug("RAM init base=%p, size=%zx\n", (void *)ram.base, ram.size);
>   
>   	gd->ram_size = ram.size;
>   


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick
Patrice CHOTARD Nov. 10, 2023, 1:20 p.m. UTC | #2
On 10/27/23 16:42, Patrice Chotard wrote:
> From: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> When building with AARCH64 defconfig, we got warnings for debug
> message
> - format '%x' expects argument of type 'unsigned int',
>    but argument 3 has type 'size_t' {aka 'long unsigned int'}).
> - format '%lx' expects argument of type 'long unsigned int',
>   but argument 2 has type 'phys_addr_t' {aka 'long long unsigned
>   int'}
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
> 
>  arch/arm/mach-stm32mp/dram_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-stm32mp/dram_init.c b/arch/arm/mach-stm32mp/dram_init.c
> index a1e77a42e4f..cb35ed60ca1 100644
> --- a/arch/arm/mach-stm32mp/dram_init.c
> +++ b/arch/arm/mach-stm32mp/dram_init.c
> @@ -36,7 +36,7 @@ int dram_init(void)
>  		log_debug("Cannot get RAM size: %d\n", ret);
>  		return ret;
>  	}
> -	log_debug("RAM init base=%lx, size=%x\n", ram.base, ram.size);
> +	log_debug("RAM init base=%p, size=%zx\n", (void *)ram.base, ram.size);
>  
>  	gd->ram_size = ram.size;
>  
Applied to u-boot-stm32/next

Thanks
Patrice
Patrice CHOTARD Nov. 10, 2023, 1:21 p.m. UTC | #3
On 11/9/23 10:13, Patrick DELAUNAY wrote:
> Hi,
> 
> 
> On 10/27/23 16:42, Patrice Chotard wrote:
>> From: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>
>> When building with AARCH64 defconfig, we got warnings for debug
>> message
>> - format '%x' expects argument of type 'unsigned int',
>>     but argument 3 has type 'size_t' {aka 'long unsigned int'}).
>> - format '%lx' expects argument of type 'long unsigned int',
>>    but argument 2 has type 'phys_addr_t' {aka 'long long unsigned
>>    int'}
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>
>>   arch/arm/mach-stm32mp/dram_init.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-stm32mp/dram_init.c b/arch/arm/mach-stm32mp/dram_init.c
>> index a1e77a42e4f..cb35ed60ca1 100644
>> --- a/arch/arm/mach-stm32mp/dram_init.c
>> +++ b/arch/arm/mach-stm32mp/dram_init.c
>> @@ -36,7 +36,7 @@ int dram_init(void)
>>           log_debug("Cannot get RAM size: %d\n", ret);
>>           return ret;
>>       }
>> -    log_debug("RAM init base=%lx, size=%x\n", ram.base, ram.size);
>> +    log_debug("RAM init base=%p, size=%zx\n", (void *)ram.base, ram.size);
>>         gd->ram_size = ram.size;
>>   
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 
Applied to u-boot-stm32/next

Thanks
Patrice
diff mbox series

Patch

diff --git a/arch/arm/mach-stm32mp/dram_init.c b/arch/arm/mach-stm32mp/dram_init.c
index a1e77a42e4f..cb35ed60ca1 100644
--- a/arch/arm/mach-stm32mp/dram_init.c
+++ b/arch/arm/mach-stm32mp/dram_init.c
@@ -36,7 +36,7 @@  int dram_init(void)
 		log_debug("Cannot get RAM size: %d\n", ret);
 		return ret;
 	}
-	log_debug("RAM init base=%lx, size=%x\n", ram.base, ram.size);
+	log_debug("RAM init base=%p, size=%zx\n", (void *)ram.base, ram.size);
 
 	gd->ram_size = ram.size;