diff mbox series

[v1,2/9] stm32mp: dram_init: Get RAM size from DT if no RAM driver found

Message ID 20231027144304.1002307-3-patrice.chotard@foss.st.com
State Accepted
Commit dba8d92a3da482f9e3d44181711ce4e08e2ac6b1
Delegated to: Patrick Delaunay
Headers show
Series Add STM32MP2 SoCs and STM32MP257F-EV board support | expand

Commit Message

Patrice CHOTARD Oct. 27, 2023, 2:42 p.m. UTC 
From: Patrice Chotard <patrice.chotard@st.com>

In case there is no RAM driver retrieve RAM size from DT as fallback.

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---

 arch/arm/mach-stm32mp/dram_init.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Patrick Delaunay Nov. 9, 2023, 9:11 a.m. UTC | #1 
Hi,

On 10/27/23 16:42, Patrice Chotard wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
>
> In case there is no RAM driver retrieve RAM size from DT as fallback.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>
>   arch/arm/mach-stm32mp/dram_init.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-stm32mp/dram_init.c b/arch/arm/mach-stm32mp/dram_init.c
> index 7f37b0d2aa2..a1e77a42e4f 100644
> --- a/arch/arm/mach-stm32mp/dram_init.c
> +++ b/arch/arm/mach-stm32mp/dram_init.c
> @@ -24,8 +24,11 @@ int dram_init(void)
>   	int ret;
>   
>   	ret = uclass_get_device(UCLASS_RAM, 0, &dev);
> -	if (ret) {
> -		log_debug("RAM init failed: %d\n", ret);
> +	/* in case there is no RAM driver, retrieve DDR size from DT */
> +	if (ret == -ENODEV) {
> +		return fdtdec_setup_mem_size_base();
> +	} else if (ret) {
> +		log_err("RAM init failed: %d\n", ret);
>   		return ret;
>   	}
>   	ret = ram_get_info(dev, &ram);


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick
Patrice CHOTARD Nov. 10, 2023, 1:20 p.m. UTC | #2 
On 11/9/23 10:11, Patrick DELAUNAY wrote:
> Hi,
> 
> On 10/27/23 16:42, Patrice Chotard wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> In case there is no RAM driver retrieve RAM size from DT as fallback.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>
>>   arch/arm/mach-stm32mp/dram_init.c | 7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-stm32mp/dram_init.c b/arch/arm/mach-stm32mp/dram_init.c
>> index 7f37b0d2aa2..a1e77a42e4f 100644
>> --- a/arch/arm/mach-stm32mp/dram_init.c
>> +++ b/arch/arm/mach-stm32mp/dram_init.c
>> @@ -24,8 +24,11 @@ int dram_init(void)
>>       int ret;
>>         ret = uclass_get_device(UCLASS_RAM, 0, &dev);
>> -    if (ret) {
>> -        log_debug("RAM init failed: %d\n", ret);
>> +    /* in case there is no RAM driver, retrieve DDR size from DT */
>> +    if (ret == -ENODEV) {
>> +        return fdtdec_setup_mem_size_base();
>> +    } else if (ret) {
>> +        log_err("RAM init failed: %d\n", ret);
>>           return ret;
>>       }
>>       ret = ram_get_info(dev, &ram);
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 
Applied to u-boot-stm32/next

Thanks
Patrice
diff mbox series

Patch

diff --git a/arch/arm/mach-stm32mp/dram_init.c b/arch/arm/mach-stm32mp/dram_init.c
index 7f37b0d2aa2..a1e77a42e4f 100644
--- a/arch/arm/mach-stm32mp/dram_init.c
+++ b/arch/arm/mach-stm32mp/dram_init.c
@@ -24,8 +24,11 @@  int dram_init(void)
 	int ret;
 
 	ret = uclass_get_device(UCLASS_RAM, 0, &dev);
-	if (ret) {
-		log_debug("RAM init failed: %d\n", ret);
+	/* in case there is no RAM driver, retrieve DDR size from DT */
+	if (ret == -ENODEV) {
+		return fdtdec_setup_mem_size_base();
+	} else if (ret) {
+		log_err("RAM init failed: %d\n", ret);
 		return ret;
 	}
 	ret = ram_get_info(dev, &ram);