| Message ID | 20221101050835.2421-3-samuel@sholland.org |
|---|---|
| State | Deferred |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | sunxi: Prepare platform Kconfig to support multiple architectures | expand |
On Tue, 1 Nov 2022 00:08:14 -0500 Samuel Holland <samuel@sholland.org> wrote: > Two of these selections are redundant and have no effect: > - DM_KEYBOARD is selected by USB_KEYBOARD > - DM_MMC is selected by MMC > > This selection has no effect by default and is unnecessarily strong: > - USB_STORAGE is implied by DISTRO_DEFAULTS With patch 01/22 removed (for now), this disables DM_KEYBOARD on 15 boards, it looks like for those without USB. I wouldn't be aware of any other keyboard type supported on Allwinner boards, so the change is fine: > Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > > arch/arm/Kconfig | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index d3a1f03b36..939f76867e 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1144,8 +1144,6 @@ config ARCH_SUNXI > select DM_I2C if I2C > select DM_SPI if SPI > select DM_SPI_FLASH if SPI > - select DM_KEYBOARD > - select DM_MMC if MMC > select DM_SCSI if SCSI > select DM_SERIAL > select GPIO_EXTRA_HEADER > @@ -1163,7 +1161,6 @@ config ARCH_SUNXI > select SYS_THUMB_BUILD if !ARM64 > select USB if DISTRO_DEFAULTS > select USB_KEYBOARD if DISTRO_DEFAULTS && USB_HOST > - select USB_STORAGE if DISTRO_DEFAULTS && USB_HOST > select SPL_USE_TINY_PRINTF > select USE_PREBOOT > select SYS_RELOC_GD_ENV_ADDR
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index d3a1f03b36..939f76867e 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1144,8 +1144,6 @@ config ARCH_SUNXI select DM_I2C if I2C select DM_SPI if SPI select DM_SPI_FLASH if SPI - select DM_KEYBOARD - select DM_MMC if MMC select DM_SCSI if SCSI select DM_SERIAL select GPIO_EXTRA_HEADER @@ -1163,7 +1161,6 @@ config ARCH_SUNXI select SYS_THUMB_BUILD if !ARM64 select USB if DISTRO_DEFAULTS select USB_KEYBOARD if DISTRO_DEFAULTS && USB_HOST - select USB_STORAGE if DISTRO_DEFAULTS && USB_HOST select SPL_USE_TINY_PRINTF select USE_PREBOOT select SYS_RELOC_GD_ENV_ADDR
Two of these selections are redundant and have no effect: - DM_KEYBOARD is selected by USB_KEYBOARD - DM_MMC is selected by MMC This selection has no effect by default and is unnecessarily strong: - USB_STORAGE is implied by DISTRO_DEFAULTS Signed-off-by: Samuel Holland <samuel@sholland.org> --- arch/arm/Kconfig | 3 --- 1 file changed, 3 deletions(-)