| Message ID | 20220509072936.12899-3-rogerq@kernel.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | k3-am642-evm-u-boot: Use binman to generate u-boot.img and tispl.bin | expand |
On Mon, May 09, 2022 at 10:29:35AM +0300, Roger Quadros wrote: > This is required for overlays to work at SPL. > > Signed-off-by: Roger Quadros <rogerq@kernel.org> This breaks booting my dra7xx_evm and I get no output in SPL.
On 10/06/2022 16:42, Tom Rini wrote: > On Mon, May 09, 2022 at 10:29:35AM +0300, Roger Quadros wrote: > >> This is required for overlays to work at SPL. >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> > > This breaks booting my dra7xx_evm and I get no output in SPL. > Thanks for checking. I'll try to debug what's wrong using beagle_x15. Is SPL size increase to blame? Maybe we should enable this only based on some config symbol? cheers, -roger
On Sat, Jun 11, 2022 at 11:43:48AM +0300, Roger Quadros wrote: > On 10/06/2022 16:42, Tom Rini wrote: > > On Mon, May 09, 2022 at 10:29:35AM +0300, Roger Quadros wrote: > > > >> This is required for overlays to work at SPL. > >> > >> Signed-off-by: Roger Quadros <rogerq@kernel.org> > > > > This breaks booting my dra7xx_evm and I get no output in SPL. > > > > Thanks for checking. I'll try to debug what's wrong using beagle_x15. > Is SPL size increase to blame? > > Maybe we should enable this only based on some config symbol? We're likely running out of memory space in one way or another, yes. So making this opt-in when needed rather than default is probably best.
diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c index 641d6a2e3e..d904f679ae 100644 --- a/tools/fdtgrep.c +++ b/tools/fdtgrep.c @@ -1230,6 +1230,10 @@ int main(int argc, char *argv[]) disp.fout = stdout; } + /* include symbol table */ + if (value_add(&disp, &disp.value_head, FDT_IS_NODE, 1, "/__symbols__")) + usage("Cannot add __symbols__ value"); + /* Run the grep and output the results */ ret = do_fdtgrep(&disp, filename); if (disp.output_fname)
This is required for overlays to work at SPL. Signed-off-by: Roger Quadros <rogerq@kernel.org> --- tools/fdtgrep.c | 4 ++++ 1 file changed, 4 insertions(+)