| Message ID | 20210303034647.20928-1-ashe@kivikakk.ee |
|---|---|
| State | Accepted |
| Commit | 1bed576d4144236f280427420296c3590d360729 |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | video: SIMPLE_PANEL depends on DM_GPIO | expand |
On Wed, 3 Mar 2021 14:46:47 +1100 Asherah Connor ashe@kivikakk.ee wrote: ... > drivers/video/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to u-boot-video/master, thanks! -- Anatolij
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 667157c2e9..220c008f8a 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -209,7 +209,7 @@ config PANEL config SIMPLE_PANEL bool "Enable simple panel support" - depends on PANEL && BACKLIGHT + depends on PANEL && BACKLIGHT && DM_GPIO default y help This turns on a simple panel driver that enables a compatible
SIMPLE_PANEL currently only depends on PANEL && BACKLIGHT, but the code makes references to dm_gpio_set_value and gpio_request_by_name. These are defined in drivers/gpio/gpio-uclass.c, so a dependency on DM_GPIO corrects these link errors: aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_set_backlight': /home/kameliya/u-boot/drivers/video/simple_panel.c:42: undefined reference to `dm_gpio_set_value' aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_enable_backlight': /home/kameliya/u-boot/drivers/video/simple_panel.c:27: undefined reference to `dm_gpio_set_value' aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_of_to_plat': /home/kameliya/u-boot/drivers/video/simple_panel.c:72: undefined reference to `gpio_request_by_name' This issue is only exposed if you have a board which enables CONFIG_DM_VIDEO without CONFIG_DM_GPIO; so far, none do, but soon a QEMU board may. Signed-off-by: Asherah Connor <ashe@kivikakk.ee> --- drivers/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)