From patchwork Wed Mar 3 03:46:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asherah Connor X-Patchwork-Id: 1446471 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kivikakk.ee header.i=@kivikakk.ee header.a=rsa-sha256 header.s=fm1 header.b=c0E0d2lV; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=IDh2S+8Q; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Dr0Ml01x7z9sSC for ; Wed, 3 Mar 2021 14:48:08 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8E102828A2; Wed, 3 Mar 2021 04:47:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kivikakk.ee Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kivikakk.ee header.i=@kivikakk.ee header.b="c0E0d2lV"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="IDh2S+8Q"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 42DF1828A3; Wed, 3 Mar 2021 04:47:54 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 39D508287F for ; Wed, 3 Mar 2021 04:47:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kivikakk.ee Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ashe@kivikakk.ee Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 30B0512AA; Tue, 2 Mar 2021 22:47:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 02 Mar 2021 22:47:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kivikakk.ee; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=C5RUGEz3ztfm4Jpwdd2Vj0IMXK 6lruFvfmehjNPSJU8=; b=c0E0d2lVRaIvt509iBd5W1i2k+nSggk5e7OJypxyjl AASRust19rfDfzGA7Io0A2V7gdDr2RH3D+qFlKCcvOle35fws24HZK61B/VNy/FD yjdfVOr1yXbjC/HPMaSSXcO6IHxjRdZOzxaqZvpWHtY5tTY2m1/aBwdq0qpOfdl8 tXNAC8t+Z+7CXKvDpO1DaKtph70ptF/Ut4h1aFFdhZ7Xbk8lU1ZcP6cJfp0ECMNf 5AmwzqUFPMo+eyBFZWTDWaGGzpRH/+SoRd4pxZMmT9agoR4uRCGAzZCQAczZG/v3 ii6F+xvjEVxymATTMm3jE3wISD6ACd7Sx8wu3siVYzLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=C5RUGEz3ztfm4Jpwd d2Vj0IMXK6lruFvfmehjNPSJU8=; b=IDh2S+8Qdwa8gzPOu2GFNsZhdBpSaZ/EM 0x6ewZ1ZoLNUBw7385OkQqxzdbK4jWhRAmSJwjLwb0o7choVp/z5wxv7++Ss/mZ8 xYkj+tNEiaO8Qie7ttj1J0OCjnaYEwxq/NkddN0wYcQ8hn5Lki3/csGWVBHjktv8 5pGWi/obMGt154XsqF7Ifs03gDV+3UPgxAa5r7C+ox8rwMcnbadUuIMfCkWQbfhZ he1fRcJktU7Rvprq+YpojkC/AlJkkNVWfwFnYtzw/ge/mqFmlS3c5EmFJHOe6Gnr nb6OjilxZZ+guQS3BxtinlYterl3IVw/p6fPNpdyFEIr+TcixXDNw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtuddgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeetshhhvghrrghh ucevohhnnhhorhcuoegrshhhvgeskhhivhhikhgrkhhkrdgvvgeqnecuggftrfgrthhtvg hrnhepjeejjeelhedvuedtgeeuieekffdvtedvfeejueffueettdeitdfhgfekieefieef necukfhppeduudelrddukedrfedurddufeehnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomheprghshhgvsehkihhvihhkrghkkhdrvggv X-ME-Proxy: Received: from ravenlin.tomodachi (119-18-31-135.77121f.mel.static.aussiebb.net [119.18.31.135]) by mail.messagingengine.com (Postfix) with ESMTPA id EA344108005C; Tue, 2 Mar 2021 22:47:45 -0500 (EST) From: Asherah Connor To: u-boot@lists.denx.de Cc: Heinrich Schuchardt , Asherah Connor , Anatolij Gustschin Subject: [PATCH] video: SIMPLE_PANEL depends on DM_GPIO Date: Wed, 3 Mar 2021 14:46:47 +1100 Message-Id: <20210303034647.20928-1-ashe@kivikakk.ee> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean SIMPLE_PANEL currently only depends on PANEL && BACKLIGHT, but the code makes references to dm_gpio_set_value and gpio_request_by_name. These are defined in drivers/gpio/gpio-uclass.c, so a dependency on DM_GPIO corrects these link errors: aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_set_backlight': /home/kameliya/u-boot/drivers/video/simple_panel.c:42: undefined reference to `dm_gpio_set_value' aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_enable_backlight': /home/kameliya/u-boot/drivers/video/simple_panel.c:27: undefined reference to `dm_gpio_set_value' aarch64-linux-gnu-ld.bfd: drivers/built-in.o: in function `simple_panel_of_to_plat': /home/kameliya/u-boot/drivers/video/simple_panel.c:72: undefined reference to `gpio_request_by_name' This issue is only exposed if you have a board which enables CONFIG_DM_VIDEO without CONFIG_DM_GPIO; so far, none do, but soon a QEMU board may. Signed-off-by: Asherah Connor --- drivers/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 667157c2e9..220c008f8a 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -209,7 +209,7 @@ config PANEL config SIMPLE_PANEL bool "Enable simple panel support" - depends on PANEL && BACKLIGHT + depends on PANEL && BACKLIGHT && DM_GPIO default y help This turns on a simple panel driver that enables a compatible