mbox series

[v3,0/9] video: sunxi: rework DE2 driver

Message ID 20210422001434.11367-1-andre.przywara@arm.com
Headers show
Series video: sunxi: rework DE2 driver | expand

Message

Andre Przywara April 22, 2021, 12:14 a.m. UTC 
Hi Anatolij,

can you please take this series? This is the first part of Jernej's
rework, which was checked quite thoroughly. I left out the patches
with issues for a later post.
I pushed a branch to:
https://source.denx.de/u-boot/custodians/u-boot-sunxi/-/commits/de2-fixes-part1/

Thanks,
Andre
-----------------

This series is the first part of a major rework to the DE2 mixer and
accompanying DW-HDMI platform driver. Main goal was to drop redundant
device specific code, and later use the DT as a source of information.
The latter part has still issues (breaks on A64), so this version only
covers the first part of the cleanups.

Besides those cleanups the first patches now filter the HDMI modes based
on the pixel clock and search for additional detailed timings in the EDID
extension block. This change allows to use 4K monitors - the base EDID
block typically presents only a 4k@60 timing, which exceeds the maximum
DE2 pixel clock. Other suitable timings, which are appropriate for this
HDMI 1.4 compliant controller, are contained in extension block.

Tested on an H5 and an A64 board.

Jernej Skrabec (9):
  video: sunxi: Add mode_valid callback to sunxi_dw_hdmi
  common: edid: check for digital display earlier
  common: edid: extract code for detailed timing search
  common: edid: Search for valid timing in extension block
  video: sunxi: Use DW-HDMI hpd function
  video: sunxi: Remove check for ddc-i2c-bus property
  video: sunxi: Remove TV probe from DE2
  video: sunxi: dw-hdmi: read source_id later
  video: sunxi: de2: switch to public uclass functions

 common/edid.c                       | 68 ++++++++++++++++++++---------
 drivers/video/sunxi/sunxi_de2.c     | 44 +++++--------------
 drivers/video/sunxi/sunxi_dw_hdmi.c | 48 ++++++--------------
 3 files changed, 72 insertions(+), 88 deletions(-)

Comments

Anatolij Gustschin April 24, 2021, 2:39 p.m. UTC | #1 
On Thu, 22 Apr 2021 01:14:25 +0100
Andre Przywara andre.przywara@arm.com wrote:
...
> Jernej Skrabec (9):
>   video: sunxi: Add mode_valid callback to sunxi_dw_hdmi
>   common: edid: check for digital display earlier
>   common: edid: extract code for detailed timing search
>   common: edid: Search for valid timing in extension block
>   video: sunxi: Use DW-HDMI hpd function
>   video: sunxi: Remove check for ddc-i2c-bus property
>   video: sunxi: Remove TV probe from DE2
>   video: sunxi: dw-hdmi: read source_id later
>   video: sunxi: de2: switch to public uclass functions
> 
>  common/edid.c                       | 68 ++++++++++++++++++++---------
>  drivers/video/sunxi/sunxi_de2.c     | 44 +++++--------------
>  drivers/video/sunxi/sunxi_dw_hdmi.c | 48 ++++++--------------
>  3 files changed, 72 insertions(+), 88 deletions(-)

Series applied to u-boot-video/master, thanks!

--
Anatolij