diff mbox series

[v3,2/9] common: edid: check for digital display earlier

Message ID 20210422001434.11367-3-andre.przywara@arm.com
State Accepted
Commit 4fb0c3c43fbb4d28c80dc4019cdcbf57bf153021
Delegated to: Anatolij Gustschin
Headers show
Series video: sunxi: rework DE2 driver | expand

Commit Message

Andre Przywara April 22, 2021, 12:14 a.m. UTC 
From: Jernej Skrabec <jernej.skrabec@siol.net>

When searching for detailed timing in EDID, check for digital display
earlier. There is no point parsing other parameters if this flag is not
present.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 common/edid.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/common/edid.c b/common/edid.c
index 553ab8fd01a..1cb7177742e 100644
--- a/common/edid.c
+++ b/common/edid.c
@@ -185,6 +185,11 @@  int edid_get_timing_validate(u8 *buf, int buf_size,
 		return -EINVAL;
 	}
 
+	if (!EDID1_INFO_VIDEO_INPUT_DIGITAL(*edid)) {
+		debug("%s: Not a digital display\n", __func__);
+		return -ENOSYS;
+	}
+
 	if (!EDID1_INFO_FEATURE_PREFERRED_TIMING_MODE(*edid)) {
 		debug("%s: No preferred timing\n", __func__);
 		return -ENOENT;
@@ -211,10 +216,6 @@  int edid_get_timing_validate(u8 *buf, int buf_size,
 	if (!timing_done)
 		return -EINVAL;
 
-	if (!EDID1_INFO_VIDEO_INPUT_DIGITAL(*edid)) {
-		debug("%s: Not a digital display\n", __func__);
-		return -ENOSYS;
-	}
 	if (edid->version != 1 || edid->revision < 4) {
 		debug("%s: EDID version %d.%d does not have required info\n",
 		      __func__, edid->version, edid->revision);