mbox series

[v4,00/12] Add support for pinmux status command on beaglebone

Message ID 20210411073950.24772-1-dariobin@libero.it
Headers show
Series Add support for pinmux status command on beaglebone | expand

Message

Dario Binacchi April 11, 2021, 7:39 a.m. UTC
The series was born from the need to check the pinmux setting of a
peripheral on a beaglebone board. I then ran the 'pinmux status -a'
command but it failed because some operations (get_pin_muxing,
get_pin_name and get_pins_count) were missing in the 'pinctrl-single'
driver.

The patch series can be cleanly applied to the HEAD of the master which
at the time of release points to 3f2e3c7845
("Merge tag 'u-boot-stm32-20210409' of https://source.denx.de/u-boot/custodians/u-boot-stm")

Changes in v4:
- Added CONFIG_PINCTRL_SINGLE to sandbox_flattree_defconfig to fix
  sandbox_flattree test errors.

Changes in v3:
- Added Pratyush Yadav review tag.
- Updated commit message.
- Added Pratyush Yadav review tag.
- Added Pratyush Yadav review tag.
- Added Simon Glass review tag.
- Added Simon Glass review tag.
- Added Simon Glass review tag.

Changes in v2:
- Added Simon Glass review tag.
- Updated commit message.
- Added Simon Glass review tag.
- Added Pratyush Yadav review tag.
- Updated commit message
- Split in 2 commits
- Check dev_read_addr_size return value.
- Updated commit message.
- Added Simon Glass review tag.
- Updated commit message.
- Remove pointer to access functions.
- Added Simon Glass review tag.
- Added Simon Glass review tag.
- Added Simon Glass review tag.
- Added error checking when the 'width' property is missing.
- Fix coding style.

Dario Binacchi (12):
  pinctrl: single: fix format of structure documentation
  pinctrl: single: fix the loop counter variable type
  pinctrl: single: fix offset management
  pinctrl: single: fix debug messages formatting
  pinctrl: single: get register area size by device API
  pinctrl: single: check "register-width" DT property
  pinctrl: single: change function mask default value
  pinctrl: single: add register access functions
  pinctrl: single: add get_pins_count operation
  pinctrl: single: add get_pin_name operation
  pinctrl: single: add get_pin_muxing operation
  test: pinmux: add test for 'pinctrl-single' driver

 arch/sandbox/dts/test.dts          |  72 +++++
 configs/sandbox_defconfig          |   1 +
 configs/sandbox_flattree_defconfig |   1 +
 drivers/pinctrl/pinctrl-single.c   | 474 +++++++++++++++++++++++++----
 test/dm/pinmux.c                   |  91 +++++-
 5 files changed, 574 insertions(+), 65 deletions(-)

Comments

Lokesh Vutla April 12, 2021, 6:18 a.m. UTC | #1
On 11/04/21 1:09 pm, Dario Binacchi wrote:
> 
> The series was born from the need to check the pinmux setting of a
> peripheral on a beaglebone board. I then ran the 'pinmux status -a'
> command but it failed because some operations (get_pin_muxing,
> get_pin_name and get_pins_count) were missing in the 'pinctrl-single'
> driver.
> 
> The patch series can be cleanly applied to the HEAD of the master which
> at the time of release points to 3f2e3c7845
> ("Merge tag 'u-boot-stm32-20210409' of https://source.denx.de/u-boot/custodians/u-boot-stm")

I do not see any errors now. Applied to u-boot-ti/for-rc

Thanks and regards,
Lokesh

> Changes in v4:
> - Added CONFIG_PINCTRL_SINGLE to sandbox_flattree_defconfig to fix
>   sandbox_flattree test errors.
> 
> Changes in v3:
> - Added Pratyush Yadav review tag.
> - Updated commit message.
> - Added Pratyush Yadav review tag.
> - Added Pratyush Yadav review tag.
> - Added Simon Glass review tag.
> - Added Simon Glass review tag.
> - Added Simon Glass review tag.
> 
> Changes in v2:
> - Added Simon Glass review tag.
> - Updated commit message.
> - Added Simon Glass review tag.
> - Added Pratyush Yadav review tag.
> - Updated commit message
> - Split in 2 commits
> - Check dev_read_addr_size return value.
> - Updated commit message.
> - Added Simon Glass review tag.
> - Updated commit message.
> - Remove pointer to access functions.
> - Added Simon Glass review tag.
> - Added Simon Glass review tag.
> - Added Simon Glass review tag.
> - Added error checking when the 'width' property is missing.
> - Fix coding style.
> 
> Dario Binacchi (12):
>   pinctrl: single: fix format of structure documentation
>   pinctrl: single: fix the loop counter variable type
>   pinctrl: single: fix offset management
>   pinctrl: single: fix debug messages formatting
>   pinctrl: single: get register area size by device API
>   pinctrl: single: check "register-width" DT property
>   pinctrl: single: change function mask default value
>   pinctrl: single: add register access functions
>   pinctrl: single: add get_pins_count operation
>   pinctrl: single: add get_pin_name operation
>   pinctrl: single: add get_pin_muxing operation
>   test: pinmux: add test for 'pinctrl-single' driver
> 
>  arch/sandbox/dts/test.dts          |  72 +++++
>  configs/sandbox_defconfig          |   1 +
>  configs/sandbox_flattree_defconfig |   1 +
>  drivers/pinctrl/pinctrl-single.c   | 474 +++++++++++++++++++++++++----
>  test/dm/pinmux.c                   |  91 +++++-
>  5 files changed, 574 insertions(+), 65 deletions(-)
>