Message ID | 20210515173716.358295-7-philmd@redhat.com |
---|---|
State | New |
Headers | show |
Series | hw: Various Kconfig fixes | expand |
On Sun, May 16, 2021 at 3:44 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART > emulation") added a dependency on the SERIAL model, but forgot to > add the Kconfig selector. > Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when > building the MICROCHIP_PFSOC machine stand-alone: > > /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create': > hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init' > > Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") > Acked-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > Cc: Bin Meng <bin.meng@windriver.com> > Cc: Alistair Francis <alistair.francis@wdc.com> > --- > hw/char/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/char/Kconfig b/hw/char/Kconfig > index 4cf36ac637b..2e4f620b13e 100644 > --- a/hw/char/Kconfig > +++ b/hw/char/Kconfig > @@ -61,6 +61,7 @@ config AVR_USART > > config MCHP_PFSOC_MMUART > bool > + select SERIAL > > config SIFIVE_UART > bool > -- > 2.26.3 > >
On Sun, May 16, 2021 at 1:44 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART > emulation") added a dependency on the SERIAL model, but forgot to > add the Kconfig selector. > Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when > building the MICROCHIP_PFSOC machine stand-alone: > > /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `mchp_pfsoc_mmuart_create': > hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init' > > Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") > Acked-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Cc: Bin Meng <bin.meng@windriver.com> > Cc: Alistair Francis <alistair.francis@wdc.com> > --- > hw/char/Kconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/hw/char/Kconfig b/hw/char/Kconfig index 4cf36ac637b..2e4f620b13e 100644 --- a/hw/char/Kconfig +++ b/hw/char/Kconfig @@ -61,6 +61,7 @@ config AVR_USART config MCHP_PFSOC_MMUART bool + select SERIAL config SIFIVE_UART bool