| Message ID | 1567786819-22142-2-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v8,01/32] riscv: hw: Remove duplicated "hw/hw.h" inclusion | expand |
On Fri, Sep 6, 2019 at 9:20 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > Commit a27bd6c779ba ("Include hw/qdev-properties.h less") wrongly > added "hw/hw.h" to sifive_prci.c and sifive_test.c. > > Another inclusion of "hw/hw.h" was later added via > commit 650d103d3ea9 ("Include hw/hw.h exactly where needed"), that > resulted in duplicated inclusion of "hw/hw.h". > > Fixes: a27bd6c779ba ("Include hw/qdev-properties.h less") > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > > --- > > Changes in v8: > - newly included in v8 to ease patch inter dependencies > > hw/riscv/sifive_prci.c | 1 - > hw/riscv/sifive_test.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/hw/riscv/sifive_prci.c b/hw/riscv/sifive_prci.c > index 9837b61..562bc3d 100644 > --- a/hw/riscv/sifive_prci.c > +++ b/hw/riscv/sifive_prci.c > @@ -19,7 +19,6 @@ > */ > > #include "qemu/osdep.h" > -#include "hw/hw.h" > #include "hw/sysbus.h" > #include "qemu/module.h" > #include "target/riscv/cpu.h" > diff --git a/hw/riscv/sifive_test.c b/hw/riscv/sifive_test.c > index afbb3aa..3a14f9f 100644 > --- a/hw/riscv/sifive_test.c > +++ b/hw/riscv/sifive_test.c > @@ -19,7 +19,6 @@ > */ > > #include "qemu/osdep.h" > -#include "hw/hw.h" > #include "hw/sysbus.h" > #include "qemu/module.h" > #include "target/riscv/cpu.h" > -- > 2.7.4 > >
On Fri, 06 Sep 2019 09:19:48 PDT (-0700), bmeng.cn@gmail.com wrote: > Commit a27bd6c779ba ("Include hw/qdev-properties.h less") wrongly > added "hw/hw.h" to sifive_prci.c and sifive_test.c. > > Another inclusion of "hw/hw.h" was later added via > commit 650d103d3ea9 ("Include hw/hw.h exactly where needed"), that > resulted in duplicated inclusion of "hw/hw.h". > > Fixes: a27bd6c779ba ("Include hw/qdev-properties.h less") > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > > --- > > Changes in v8: > - newly included in v8 to ease patch inter dependencies > > hw/riscv/sifive_prci.c | 1 - > hw/riscv/sifive_test.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/hw/riscv/sifive_prci.c b/hw/riscv/sifive_prci.c > index 9837b61..562bc3d 100644 > --- a/hw/riscv/sifive_prci.c > +++ b/hw/riscv/sifive_prci.c > @@ -19,7 +19,6 @@ > */ > > #include "qemu/osdep.h" > -#include "hw/hw.h" > #include "hw/sysbus.h" > #include "qemu/module.h" > #include "target/riscv/cpu.h" > diff --git a/hw/riscv/sifive_test.c b/hw/riscv/sifive_test.c > index afbb3aa..3a14f9f 100644 > --- a/hw/riscv/sifive_test.c > +++ b/hw/riscv/sifive_test.c > @@ -19,7 +19,6 @@ > */ > > #include "qemu/osdep.h" > -#include "hw/hw.h" > #include "hw/sysbus.h" > #include "qemu/module.h" > #include "target/riscv/cpu.h" Revieweb-by: Palmer Dabbelt <palmer@sifive.com>
diff --git a/hw/riscv/sifive_prci.c b/hw/riscv/sifive_prci.c index 9837b61..562bc3d 100644 --- a/hw/riscv/sifive_prci.c +++ b/hw/riscv/sifive_prci.c @@ -19,7 +19,6 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/sysbus.h" #include "qemu/module.h" #include "target/riscv/cpu.h" diff --git a/hw/riscv/sifive_test.c b/hw/riscv/sifive_test.c index afbb3aa..3a14f9f 100644 --- a/hw/riscv/sifive_test.c +++ b/hw/riscv/sifive_test.c @@ -19,7 +19,6 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/sysbus.h" #include "qemu/module.h" #include "target/riscv/cpu.h"
Commit a27bd6c779ba ("Include hw/qdev-properties.h less") wrongly added "hw/hw.h" to sifive_prci.c and sifive_test.c. Another inclusion of "hw/hw.h" was later added via commit 650d103d3ea9 ("Include hw/hw.h exactly where needed"), that resulted in duplicated inclusion of "hw/hw.h". Fixes: a27bd6c779ba ("Include hw/qdev-properties.h less") Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- Changes in v8: - newly included in v8 to ease patch inter dependencies hw/riscv/sifive_prci.c | 1 - hw/riscv/sifive_test.c | 1 - 2 files changed, 2 deletions(-)