| Message ID | 20220630120845.3356144-7-bryan.odonoghue@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | msm8916/msm8939 DSI controller and DSI PHY bindings fixes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 29 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 30 June 2022 15:08:44 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: >Add in missing clock and clock-names declarations to the 28nm DSI PHY. >When converting from .txt to .yaml we missed these. > >Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") >Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >--- > .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > >diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml >index 3d8540a06fe22..9ecd513d93661 100644 >--- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml >+++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml >@@ -19,6 +19,21 @@ properties: > - qcom,dsi-phy-28nm-lp > - qcom,dsi-phy-28nm-8960 > >+ clocks: >+ minItems: 1 >+ maxItems: 2 >+ >+ clock-names: >+ items: >+ - const: iface >+ description: AHB clock >+ - const: iface_clk >+ description: AHB clock >+ - const: ref >+ description: Block reference clock >+ minItems: 1 >+ maxItems: 2 This looks incorrect. You have 3 items, but maxItems in 2 Also I'd put description to the clocks node. Clock-names are self-descriptive enough. >+ > reg: > items: > - description: dsi pll register set >@@ -36,6 +51,8 @@ properties: > > required: > - compatible >+ - clocks >+ - clock-names > - reg > - reg-names > - vddio-supply
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > Add in missing clock and clock-names declarations to the 28nm DSI PHY. > When converting from .txt to .yaml we missed these. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++ You need to fix all your subject prefixes. It's confusing to see again clocks being fixed for the DSI bindings. dt-bindings: msm: dsi-phy-28nm: and similarly for other cases. > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > index 3d8540a06fe22..9ecd513d93661 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > @@ -19,6 +19,21 @@ properties: > - qcom,dsi-phy-28nm-lp > - qcom,dsi-phy-28nm-8960 > > + clocks: > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + items: > + - const: iface > + description: AHB clock Descriptions goes to clocks. > + - const: iface_clk > + description: AHB clock > + - const: ref > + description: Block reference clock > + minItems: 1 > + maxItems: 2 Did you test it? Three items vs maxItems:2? > + > reg: > items: > - description: dsi pll register set > @@ -36,6 +51,8 @@ properties: > > required: > - compatible > + - clocks > + - clock-names > - reg > - reg-names > - vddio-supply Best regards, Krzysztof
On 30/06/2022 15:08, Bryan O'Donoghue wrote: > Add in missing clock and clock-names declarations to the 28nm DSI PHY. > When converting from .txt to .yaml we missed these. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> I checked the schema. I think you can drop this patch. The issue that you probably saw with apq8064 should be solved in the dtsi, not in the schema. > --- > .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > index 3d8540a06fe22..9ecd513d93661 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > @@ -19,6 +19,21 @@ properties: > - qcom,dsi-phy-28nm-lp > - qcom,dsi-phy-28nm-8960 > > + clocks: > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + items: > + - const: iface > + description: AHB clock > + - const: iface_clk > + description: AHB clock > + - const: ref > + description: Block reference clock > + minItems: 1 > + maxItems: 2 > + > reg: > items: > - description: dsi pll register set > @@ -36,6 +51,8 @@ properties: > > required: > - compatible > + - clocks > + - clock-names > - reg > - reg-names > - vddio-supply
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml index 3d8540a06fe22..9ecd513d93661 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml @@ -19,6 +19,21 @@ properties: - qcom,dsi-phy-28nm-lp - qcom,dsi-phy-28nm-8960 + clocks: + minItems: 1 + maxItems: 2 + + clock-names: + items: + - const: iface + description: AHB clock + - const: iface_clk + description: AHB clock + - const: ref + description: Block reference clock + minItems: 1 + maxItems: 2 + reg: items: - description: dsi pll register set @@ -36,6 +51,8 @@ properties: required: - compatible + - clocks + - clock-names - reg - reg-names - vddio-supply
Add in missing clock and clock-names declarations to the 28nm DSI PHY. When converting from .txt to .yaml we missed these. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)