| Message ID | 20220630120845.3356144-4-bryan.odonoghue@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | msm8916/msm8939 DSI controller and DSI PHY bindings fixes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 7 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 30 June 2022 15:08:41 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: >The existing msm8916.dtsi does not depend on nor require power-domains. >Drop from the list of required. > >Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") >Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >--- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >index 101adec8d9152..91324f0828448 100644 >--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >@@ -136,7 +136,6 @@ required: > - phy-names > - assigned-clocks > - assigned-clock-parents >- - power-domains > - ports > > additionalProperties: false
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > The existing msm8916.dtsi does not depend on nor require power-domains. > Drop from the list of required. That's not good reason. The bindings are about hardware so the question is whether being a part of power domain or toggling power domain on/off is considered required for the DSI. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index 101adec8d9152..91324f0828448 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -136,7 +136,6 @@ required: > - phy-names > - assigned-clocks > - assigned-clock-parents > - - power-domains > - ports > > additionalProperties: false Best regards, Krzysztof
On 30/06/2022 20:01, Krzysztof Kozlowski wrote: > On 30/06/2022 14:08, Bryan O'Donoghue wrote: >> The existing msm8916.dtsi does not depend on nor require power-domains. >> Drop from the list of required. > > That's not good reason. The bindings are about hardware so the question > is whether being a part of power domain or toggling power domain on/off > is considered required for the DSI. AFAIK no but, I will check this again and if it is definitely not required, I'll churn the commit log to describe it better.
On Thu, Jun 30, 2022 at 08:49:03PM +0100, Bryan O'Donoghue wrote: > On 30/06/2022 20:01, Krzysztof Kozlowski wrote: > > On 30/06/2022 14:08, Bryan O'Donoghue wrote: > > > The existing msm8916.dtsi does not depend on nor require power-domains. > > > Drop from the list of required. > > > > That's not good reason. The bindings are about hardware so the question > > is whether being a part of power domain or toggling power domain on/off > > is considered required for the DSI. > > AFAIK no but, I will check this again and if it is definitely not required, > I'll churn the commit log to describe it better. > The power domain in the DSI node is used together with the OPP table to vote for performance states depending on the clock frequency of the byte clock. In the downstream kernel this is part of the clock driver. In mainline this needs to be done in the consumer driver. The MSM8916 port was never really optimized for power usage. With incomplete interconnect support etc the power domains tend to be at maximum state most of the time, so it does not cause any issues if you forget to vote for performance states in some places. In general, the situation on MSM8916/MSM8939 is not really any different from newer SoCs. The downstream MSM8916 gcc driver contains: static struct rcg_clk byte0_clk_src = { /* ... */ .c = { /* ... */ VDD_DIG_FMAX_MAP2(LOW, 94400000, NOMINAL, 188500000), }, }; which should be ideally translated into an OPP table with power-domains = <&rpmpd MSM8916_VDDCX>; similar to newer SoCs. (I'm not saying that "power-domains" should be required, just that it could be added for MSM8916/MSM8939 if someone wants to properly power-optimize them...) Thanks, Stephan
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index 101adec8d9152..91324f0828448 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -136,7 +136,6 @@ required: - phy-names - assigned-clocks - assigned-clock-parents - - power-domains - ports additionalProperties: false
The existing msm8916.dtsi does not depend on nor require power-domains. Drop from the list of required. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 - 1 file changed, 1 deletion(-)