| Message ID | 20220630120845.3356144-2-bryan.odonoghue@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | msm8916/msm8939 DSI controller and DSI PHY bindings fixes | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 8 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 30 June 2022 15:08:39 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: >The driver doesn't care about the name of the phy in DTS. msm8916 has since >2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". > >There's no reason to have a constraint on the name here, simply to have a >name. Remove the redundant const in favour of maxItems: 1. > >Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") >Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >--- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >index 880bfe930830c..717a5d255ffe4 100644 >--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >@@ -49,7 +49,7 @@ properties: > maxItems: 1 > > phy-names: >- const: dsi >+ maxItems: 1 > > "#address-cells": true >
On 30/06/2022 14:08, Bryan O'Donoghue wrote: > The driver doesn't care about the name of the phy in DTS. msm8916 has since > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". > > There's no reason to have a constraint on the name here, simply to have a > name. Remove the redundant const in favour of maxItems: 1. For single entry the names field could be as well removed. But if it is there, let's make it specific, not generic. Therefore instead add allOf:if:then restricting it per variants. Best regards, Krzysztof
On Thu, Jun 30, 2022 at 08:59:03PM +0200, Krzysztof Kozlowski wrote: > On 30/06/2022 14:08, Bryan O'Donoghue wrote: > > The driver doesn't care about the name of the phy in DTS. msm8916 has since > > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". > > > > There's no reason to have a constraint on the name here, simply to have a > > name. Remove the redundant const in favour of maxItems: 1. > > For single entry the names field could be as well removed. But if it is > there, let's make it specific, not generic. Therefore instead add > allOf:if:then restricting it per variants. If we really don't care, an if/then seems excessive. Just mark as deprecated and remove it in all the dts files. Rob
On Thu, Jun 30, 2022 at 01:08:39PM +0100, Bryan O'Donoghue wrote: > The driver doesn't care about the name of the phy in DTS. msm8916 has since > 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". Also, for the subject, it's 'phy-names' not 'phy-name'. > There's no reason to have a constraint on the name here, simply to have a > name. Remove the redundant const in favour of maxItems: 1. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index 880bfe930830c..717a5d255ffe4 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -49,7 +49,7 @@ properties: > maxItems: 1 > > phy-names: > - const: dsi > + maxItems: 1 > > "#address-cells": true > > -- > 2.36.1 > >
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index 880bfe930830c..717a5d255ffe4 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -49,7 +49,7 @@ properties: maxItems: 1 phy-names: - const: dsi + maxItems: 1 "#address-cells": true
The driver doesn't care about the name of the phy in DTS. msm8916 has since 2016 named the phy "dsi-phy" with later SoCs taking the name "dsi". There's no reason to have a constraint on the name here, simply to have a name. Remove the redundant const in favour of maxItems: 1. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)