| Message ID | 1418628525-16528-1-git-send-email-harninder.rai@freescale.com |
|---|---|
| State | Accepted |
| Delegated to: | York Sun |
| Headers | show |
On 12/14/2014 11:28 PM, Harninder Rai wrote: > Signed-off-by: Harninder Rai <harninder.rai@freescale.com> > --- > include/configs/BSC9131RDB.h | 1 + > include/configs/BSC9132QDS.h | 1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/configs/BSC9131RDB.h b/include/configs/BSC9131RDB.h > index adb8146..6f1022e 100644 > --- a/include/configs/BSC9131RDB.h > +++ b/include/configs/BSC9131RDB.h > @@ -430,6 +430,7 @@ extern unsigned long get_sdram_size(void); > #define CONFIG_UBOOTPATH "u-boot.bin" /* U-Boot image on TFTP server */ > > #define CONFIG_BAUDRATE 115200 > +#define CONFIG_BOOTDELAY 10 /* -1 disable auto-boot */ > > #define CONFIG_EXTRA_ENV_SETTINGS \ > "netdev=eth0\0" \ > diff --git a/include/configs/BSC9132QDS.h b/include/configs/BSC9132QDS.h > index 2722a32..66ca461 100644 > --- a/include/configs/BSC9132QDS.h > +++ b/include/configs/BSC9132QDS.h > @@ -672,6 +672,7 @@ combinations. this should be removed later > #define CONFIG_UBOOTPATH "u-boot.bin" > > #define CONFIG_BAUDRATE 115200 > +#define CONFIG_BOOTDELAY 10 /* -1 disable auto-boot */ > > #ifdef CONFIG_SDCARD > #define CONFIG_DEF_HWCONFIG "hwconfig=usb1:dr_mode=host,phy_type=ulpi\0" > The change is trivial. Do you mind to explain why you need this change? York
> > The change is trivial. Do you mind to explain why you need this change? Thanks for the review. This change is required to give user some time to interrupt the booting process Also, this will allow the system to boot from flash after power-on (does help in automation testing) Is this sufficient for a commit message? Harry++ > > York
You understand this is the default value of the said variable. You can save your environmental variable when you boot up. You can save it to any value you want, and this default value doesn't matter any more, until you erase it. York
I am not sure I followed you completely but if I just use CONFIG_BOOTDELAY then I get the following compilation error
common/autoboot.c: In function 'bootdelay_process':
common/autoboot.c:247:68: error: expected expression before ';' token
Is there something which I am missing?
Thanks and Regards
Harry++
From: Sun York-R58495
Sent: Tuesday, December 16, 2014 11:46 AM
To: Rai Harninder-B01044; u-boot@lists.denx.de
Subject: RE: [PATCH] powerpc/913x: Add config flag for bootdelay
You understand this is the default value of the said variable. You can save your environmental variable when you boot up. You can save it to any value you want, and this default value doesn't matter any more, until you erase it.
York
On 12/16/2014 02:55 AM, Rai Harninder-B01044 wrote: > I am not sure I followed you completely but if I just use CONFIG_BOOTDELAY then > I get the following compilation error > > > > common/autoboot.c: In function 'bootdelay_process': > > common/autoboot.c:247:68: error: expected expression before ';' token > > > > Is there something which I am missing? > I am guessing you has some extra character for the CONFIG_BOOTDELAY. Anyway, since you are on this line common/autoboot.c:247, you can see the "bootdelay" variable one line above. Your purpose of adding delay to boot is easily implemented by these command under u-boot setenv bootdelay 10 saveenv There is no need to change the code for this purpose. York
> I am guessing you has some extra character for the CONFIG_BOOTDELAY. Anyway, > since you are on this line common/autoboot.c:247, you can see the "bootdelay" > variable one line above. Your purpose of adding delay to boot is easily > implemented by these command under u-boot > > setenv bootdelay 10 > saveenv > > There is no need to change the code for this purpose. Thanks for the review. Let me look into this Harry++ > > York >
On 12/21/2014 09:22 PM, Rai Harninder-B01044 wrote: >> I am guessing you has some extra character for the CONFIG_BOOTDELAY. Anyway, >> since you are on this line common/autoboot.c:247, you can see the "bootdelay" >> variable one line above. Your purpose of adding delay to boot is easily >> implemented by these command under u-boot >> >> setenv bootdelay 10 >> saveenv >> >> There is no need to change the code for this purpose. > Thanks for the review. Let me look into this > I took another look at this patch. It is harmless and adding the default value is correct. I will accept this patch and add commit message. York
On 12/15/2014 01:28 AM, Harninder Rai wrote: > Signed-off-by: Harninder Rai <harninder.rai@freescale.com> > --- Applied to u-boot-mpc85xx master branch, awaiting upstream. York
diff --git a/include/configs/BSC9131RDB.h b/include/configs/BSC9131RDB.h index adb8146..6f1022e 100644 --- a/include/configs/BSC9131RDB.h +++ b/include/configs/BSC9131RDB.h @@ -430,6 +430,7 @@ extern unsigned long get_sdram_size(void); #define CONFIG_UBOOTPATH "u-boot.bin" /* U-Boot image on TFTP server */ #define CONFIG_BAUDRATE 115200 +#define CONFIG_BOOTDELAY 10 /* -1 disable auto-boot */ #define CONFIG_EXTRA_ENV_SETTINGS \ "netdev=eth0\0" \ diff --git a/include/configs/BSC9132QDS.h b/include/configs/BSC9132QDS.h index 2722a32..66ca461 100644 --- a/include/configs/BSC9132QDS.h +++ b/include/configs/BSC9132QDS.h @@ -672,6 +672,7 @@ combinations. this should be removed later #define CONFIG_UBOOTPATH "u-boot.bin" #define CONFIG_BAUDRATE 115200 +#define CONFIG_BOOTDELAY 10 /* -1 disable auto-boot */ #ifdef CONFIG_SDCARD #define CONFIG_DEF_HWCONFIG "hwconfig=usb1:dr_mode=host,phy_type=ulpi\0"
Signed-off-by: Harninder Rai <harninder.rai@freescale.com> --- include/configs/BSC9131RDB.h | 1 + include/configs/BSC9132QDS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)